From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: "Mark A. Greer" <mgreer@animalcreek.com>,
"Kasatkin, Dmitry" <dmitry.kasatkin@intel.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
davem@davemloft.net, rmk+kernel@arm.linux.org.uk,
khilman@deeprootsystems.com
Subject: Re: [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod
Date: Fri, 9 Nov 2012 10:00:31 -0800 [thread overview]
Message-ID: <20121109180031.GQ6801@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1211091709000.20703@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [121109 09:13]:
> On Fri, 9 Nov 2012, Mark A. Greer wrote:
>
> > On Fri, Nov 09, 2012 at 06:10:20PM +0200, Kasatkin, Dmitry wrote:
> >
> > > Why not using macros as it was before?
> > >
> > > OMAP24XX_SEC_SHA1MD5_BASE
> >
> > I am following the precedent set in the existing code of that file
> > which uses the actual address instead of a macro (except for uart).
> >
> > I have no preference but I believe that is how Paul prefers it.
> >
> > Paul?
>
> My upstream prefers the raw addresses, I believe, under the rationale that
> it allows the macro definitions to be removed from arch/arm/mach-omap2.
> This reduces the total number of lines of code in that directory - and
> this is currently an overriding concern of my upstreams.
>
> So, yes the address format in your patch is fine.
Yes that should be the only place where that address is defined.
If OMAP24XX_SEC_SHA1MD5_BASE is used in multiple locations, then
it makes sense to define it in some local header.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod
Date: Fri, 9 Nov 2012 10:00:31 -0800 [thread overview]
Message-ID: <20121109180031.GQ6801@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1211091709000.20703@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [121109 09:13]:
> On Fri, 9 Nov 2012, Mark A. Greer wrote:
>
> > On Fri, Nov 09, 2012 at 06:10:20PM +0200, Kasatkin, Dmitry wrote:
> >
> > > Why not using macros as it was before?
> > >
> > > OMAP24XX_SEC_SHA1MD5_BASE
> >
> > I am following the precedent set in the existing code of that file
> > which uses the actual address instead of a macro (except for uart).
> >
> > I have no preference but I believe that is how Paul prefers it.
> >
> > Paul?
>
> My upstream prefers the raw addresses, I believe, under the rationale that
> it allows the macro definitions to be removed from arch/arm/mach-omap2.
> This reduces the total number of lines of code in that directory - and
> this is currently an overriding concern of my upstreams.
>
> So, yes the address format in your patch is fine.
Yes that should be the only place where that address is defined.
If OMAP24XX_SEC_SHA1MD5_BASE is used in multiple locations, then
it makes sense to define it in some local header.
Regards,
Tony
next prev parent reply other threads:[~2012-11-09 18:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 2:57 [PATCH v3 0/7] crypto: omap-sham updates Mark A. Greer
2012-11-07 2:57 ` Mark A. Greer
2012-11-07 2:57 ` [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod Mark A. Greer
2012-11-07 2:57 ` Mark A. Greer
2012-11-09 16:10 ` Kasatkin, Dmitry
2012-11-09 16:10 ` Kasatkin, Dmitry
2012-11-09 17:07 ` Mark A. Greer
2012-11-09 17:07 ` Mark A. Greer
2012-11-09 17:11 ` Paul Walmsley
2012-11-09 17:11 ` Paul Walmsley
2012-11-09 18:00 ` Tony Lindgren [this message]
2012-11-09 18:00 ` Tony Lindgren
2012-11-09 18:20 ` Mark A. Greer
2012-11-09 18:20 ` Mark A. Greer
2012-11-07 2:57 ` [PATCH v3 2/7] ARM: OMAP2xxx: hwmod: Add DMA support for SHAM module Mark A. Greer
2012-11-07 2:57 ` Mark A. Greer
2012-11-07 2:57 ` [PATCH v3 3/7] ARM: OMAP3xxx: hwmod: Convert SHAM crypto device data to hwmod Mark A. Greer
2012-11-07 2:57 ` Mark A. Greer
2012-11-09 16:11 ` Kasatkin, Dmitry
2012-11-09 16:11 ` Kasatkin, Dmitry
2012-11-07 2:57 ` [PATCH v3 4/7] ARM: OMAP2+: Remove unnecessary message when no SHA IP is present Mark A. Greer
2012-11-07 2:57 ` Mark A. Greer
2012-11-07 2:57 ` [PATCH v3 5/7] crypto: omap-sham: Convert to use pm_runtime API Mark A. Greer
2012-11-07 2:57 ` Mark A. Greer
2012-11-14 1:12 ` Kevin Hilman
2012-11-14 1:12 ` Kevin Hilman
2012-11-07 2:57 ` [PATCH v3 6/7] crypto: omap-sham: Add code to use dmaengine API Mark A. Greer
2012-11-07 2:57 ` Mark A. Greer
2012-11-07 2:57 ` [PATCH v3 7/7] crypto: omap_sham: Remove usage of private DMA API Mark A. Greer
2012-11-07 2:57 ` Mark A. Greer
2012-11-09 16:28 ` Kasatkin, Dmitry
2012-11-09 16:28 ` Kasatkin, Dmitry
2012-11-09 17:17 ` Mark A. Greer
2012-11-09 17:17 ` Mark A. Greer
2012-11-14 7:47 ` Kasatkin, Dmitry
2012-11-14 7:47 ` Kasatkin, Dmitry
2012-11-14 16:47 ` Mark A. Greer
2012-11-14 16:47 ` Mark A. Greer
2012-11-16 22:40 ` Mark A. Greer
2012-11-16 22:40 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121109180031.GQ6801@atomide.com \
--to=tony@atomide.com \
--cc=davem@davemloft.net \
--cc=dmitry.kasatkin@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=paul@pwsan.com \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.