* [PATCH] meta-toolchain-arago: de-bashify
@ 2012-11-12 22:33 Franklin S. Cooper Jr
2012-11-12 23:20 ` Denys Dmytriyenko
0 siblings, 1 reply; 4+ messages in thread
From: Franklin S. Cooper Jr @ 2012-11-12 22:33 UTC (permalink / raw)
To: meta-arago; +Cc: Franklin S. Cooper Jr
* Replacing "echo -e" with "printf".
* This mimics a previous de-bashify patch applied to this same recipe.
Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
.../recipes-core/meta/meta-toolchain-arago.bb | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
index 09996d6..3d3fb0d 100644
--- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
+++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
@@ -4,7 +4,7 @@ TOOLCHAIN_OUTPUTNAME ?= "${SDK_NAME}-${ARMPKGARCH}-${TARGET_OS}-sdk-${SDK_ARCH}"
require recipes-core/meta/meta-toolchain.bb
-PR = "r7"
+PR = "r8"
SDKTARGETSYSROOT = "${SDKPATH}/${ARAGO_TARGET_SYS}"
@@ -54,15 +54,15 @@ toolchain_create_sdk_env_script () {
echo 'export OECORE_ACLOCAL_OPTS="-I $SDK_PATH/usr/share/aclocal"' >> $script
echo 'export OECORE_DISTRO_VERSION="${DISTRO_VERSION}"' >> $script
echo 'export OECORE_SDK_VERSION="${SDK_VERSION}"' >> $script
- echo -e 'export CPP="\x24{TARGET_PREFIX}gcc -E"' >> $script
- echo -e 'export NM=\x24{TARGET_PREFIX}nm' >> $script
- echo -e 'export RANLIB=\x24{TARGET_PREFIX}ranlib' >> $script
- echo -e 'export OBJCOPY=\x24{TARGET_PREFIX}objcopy' >> $script
- echo -e 'export STRIP=\x24{TARGET_PREFIX}strip' >> $script
- echo -e 'export AS=\x24{TARGET_PREFIX}as' >> $script
- echo -e 'export AR=\x24{TARGET_PREFIX}ar' >> $script
- echo -e 'export OBJDUMP=\x24{TARGET_PREFIX}objdump' >> $script
- echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
+ printf 'export CPP="\x24{TARGET_PREFIX}gcc -E"\n' >> $script
+ printf 'export NM=\x24{TARGET_PREFIX}nm\n' >> $script
+ printf 'export RANLIB=\x24{TARGET_PREFIX}ranlib\n' >> $script
+ printf 'export OBJCOPY=\x24{TARGET_PREFIX}objcopy\n' >> $script
+ printf 'export STRIP=\x24{TARGET_PREFIX}strip\n' >> $script
+ printf 'export AS=\x24{TARGET_PREFIX}as\n' >> $script
+ printf 'export AR=\x24{TARGET_PREFIX}ar\n' >> $script
+ printf 'export OBJDUMP=\x24{TARGET_PREFIX}objdump\n' >> $script
+ echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
}
populate_sdk_ipk_append () {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] meta-toolchain-arago: de-bashify
2012-11-12 22:33 [PATCH] meta-toolchain-arago: de-bashify Franklin S. Cooper Jr
@ 2012-11-12 23:20 ` Denys Dmytriyenko
2012-11-12 23:40 ` Cooper Jr., Franklin
0 siblings, 1 reply; 4+ messages in thread
From: Denys Dmytriyenko @ 2012-11-12 23:20 UTC (permalink / raw)
To: Franklin S. Cooper Jr; +Cc: meta-arago, Franklin S. Cooper Jr
On Mon, Nov 12, 2012 at 04:33:18PM -0600, Franklin S. Cooper Jr wrote:
> * Replacing "echo -e" with "printf".
> * This mimics a previous de-bashify patch applied to this same recipe.
>
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
How is it different from this:
http://arago-project.org/git/?p=meta-arago.git;a=commitdiff;h=7f47dbad47a44c8d16c12139260a00b80d603e71
I'd suggest you update your tree to the latest code base...
> ---
> .../recipes-core/meta/meta-toolchain-arago.bb | 20 ++++++++++----------
> 1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> index 09996d6..3d3fb0d 100644
> --- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> +++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> @@ -4,7 +4,7 @@ TOOLCHAIN_OUTPUTNAME ?= "${SDK_NAME}-${ARMPKGARCH}-${TARGET_OS}-sdk-${SDK_ARCH}"
>
> require recipes-core/meta/meta-toolchain.bb
>
> -PR = "r7"
> +PR = "r8"
>
> SDKTARGETSYSROOT = "${SDKPATH}/${ARAGO_TARGET_SYS}"
>
> @@ -54,15 +54,15 @@ toolchain_create_sdk_env_script () {
> echo 'export OECORE_ACLOCAL_OPTS="-I $SDK_PATH/usr/share/aclocal"' >> $script
> echo 'export OECORE_DISTRO_VERSION="${DISTRO_VERSION}"' >> $script
> echo 'export OECORE_SDK_VERSION="${SDK_VERSION}"' >> $script
> - echo -e 'export CPP="\x24{TARGET_PREFIX}gcc -E"' >> $script
> - echo -e 'export NM=\x24{TARGET_PREFIX}nm' >> $script
> - echo -e 'export RANLIB=\x24{TARGET_PREFIX}ranlib' >> $script
> - echo -e 'export OBJCOPY=\x24{TARGET_PREFIX}objcopy' >> $script
> - echo -e 'export STRIP=\x24{TARGET_PREFIX}strip' >> $script
> - echo -e 'export AS=\x24{TARGET_PREFIX}as' >> $script
> - echo -e 'export AR=\x24{TARGET_PREFIX}ar' >> $script
> - echo -e 'export OBJDUMP=\x24{TARGET_PREFIX}objdump' >> $script
> - echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
> + printf 'export CPP="\x24{TARGET_PREFIX}gcc -E"\n' >> $script
> + printf 'export NM=\x24{TARGET_PREFIX}nm\n' >> $script
> + printf 'export RANLIB=\x24{TARGET_PREFIX}ranlib\n' >> $script
> + printf 'export OBJCOPY=\x24{TARGET_PREFIX}objcopy\n' >> $script
> + printf 'export STRIP=\x24{TARGET_PREFIX}strip\n' >> $script
> + printf 'export AS=\x24{TARGET_PREFIX}as\n' >> $script
> + printf 'export AR=\x24{TARGET_PREFIX}ar\n' >> $script
> + printf 'export OBJDUMP=\x24{TARGET_PREFIX}objdump\n' >> $script
> + echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
> }
>
> populate_sdk_ipk_append () {
> --
> 1.7.0.4
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] meta-toolchain-arago: de-bashify
2012-11-12 23:20 ` Denys Dmytriyenko
@ 2012-11-12 23:40 ` Cooper Jr., Franklin
2012-11-12 23:49 ` Denys Dmytriyenko
0 siblings, 1 reply; 4+ messages in thread
From: Cooper Jr., Franklin @ 2012-11-12 23:40 UTC (permalink / raw)
To: Denys Dmytriyenko, Franklin S. Cooper Jr; +Cc: meta-arago@arago-project.org
-----Original Message-----
From: Denys Dmytriyenko [mailto:denis@denix.org]
Sent: Monday, November 12, 2012 5:20 PM
To: Franklin S. Cooper Jr
Cc: meta-arago@arago-project.org; Cooper Jr., Franklin
Subject: Re: [meta-arago] [PATCH] meta-toolchain-arago: de-bashify
On Mon, Nov 12, 2012 at 04:33:18PM -0600, Franklin S. Cooper Jr wrote:
> * Replacing "echo -e" with "printf".
> * This mimics a previous de-bashify patch applied to this same recipe.
>
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
How is it different from this:
http://arago-project.org/git/?p=meta-arago.git;a=commitdiff;h=7f47dbad47a44c8d16c12139260a00b80d603e71
I'd suggest you update your tree to the latest code base...
Franklin:
I see what happened. http://arago-project.org/pipermail/meta-arago/2012-November/000483.html you made a comment about pulling in this environment variables into meta-toolchain-arago and I made that change. You ended up doing the same thing that my patch http://arago-project.org/pipermail/meta-arago/2012-November/000520.html also did. Which this patch builds on top of.
> ---
> .../recipes-core/meta/meta-toolchain-arago.bb | 20 ++++++++++----------
> 1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> index 09996d6..3d3fb0d 100644
> --- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> +++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> @@ -4,7 +4,7 @@ TOOLCHAIN_OUTPUTNAME ?= "${SDK_NAME}-${ARMPKGARCH}-${TARGET_OS}-sdk-${SDK_ARCH}"
>
> require recipes-core/meta/meta-toolchain.bb
>
> -PR = "r7"
> +PR = "r8"
>
> SDKTARGETSYSROOT = "${SDKPATH}/${ARAGO_TARGET_SYS}"
>
> @@ -54,15 +54,15 @@ toolchain_create_sdk_env_script () {
> echo 'export OECORE_ACLOCAL_OPTS="-I $SDK_PATH/usr/share/aclocal"' >> $script
> echo 'export OECORE_DISTRO_VERSION="${DISTRO_VERSION}"' >> $script
> echo 'export OECORE_SDK_VERSION="${SDK_VERSION}"' >> $script
> - echo -e 'export CPP="\x24{TARGET_PREFIX}gcc -E"' >> $script
> - echo -e 'export NM=\x24{TARGET_PREFIX}nm' >> $script
> - echo -e 'export RANLIB=\x24{TARGET_PREFIX}ranlib' >> $script
> - echo -e 'export OBJCOPY=\x24{TARGET_PREFIX}objcopy' >> $script
> - echo -e 'export STRIP=\x24{TARGET_PREFIX}strip' >> $script
> - echo -e 'export AS=\x24{TARGET_PREFIX}as' >> $script
> - echo -e 'export AR=\x24{TARGET_PREFIX}ar' >> $script
> - echo -e 'export OBJDUMP=\x24{TARGET_PREFIX}objdump' >> $script
> - echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
> + printf 'export CPP="\x24{TARGET_PREFIX}gcc -E"\n' >> $script
> + printf 'export NM=\x24{TARGET_PREFIX}nm\n' >> $script
> + printf 'export RANLIB=\x24{TARGET_PREFIX}ranlib\n' >> $script
> + printf 'export OBJCOPY=\x24{TARGET_PREFIX}objcopy\n' >> $script
> + printf 'export STRIP=\x24{TARGET_PREFIX}strip\n' >> $script
> + printf 'export AS=\x24{TARGET_PREFIX}as\n' >> $script
> + printf 'export AR=\x24{TARGET_PREFIX}ar\n' >> $script
> + printf 'export OBJDUMP=\x24{TARGET_PREFIX}objdump\n' >> $script
> + echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
> }
>
> populate_sdk_ipk_append () {
> --
> 1.7.0.4
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] meta-toolchain-arago: de-bashify
2012-11-12 23:40 ` Cooper Jr., Franklin
@ 2012-11-12 23:49 ` Denys Dmytriyenko
0 siblings, 0 replies; 4+ messages in thread
From: Denys Dmytriyenko @ 2012-11-12 23:49 UTC (permalink / raw)
To: Cooper Jr., Franklin; +Cc: meta-arago@arago-project.org
On Mon, Nov 12, 2012 at 11:40:09PM +0000, Cooper Jr., Franklin wrote:
>
>
> -----Original Message-----
> From: Denys Dmytriyenko [mailto:denis@denix.org]
> Sent: Monday, November 12, 2012 5:20 PM
> To: Franklin S. Cooper Jr
> Cc: meta-arago@arago-project.org; Cooper Jr., Franklin
> Subject: Re: [meta-arago] [PATCH] meta-toolchain-arago: de-bashify
>
> On Mon, Nov 12, 2012 at 04:33:18PM -0600, Franklin S. Cooper Jr wrote:
> > * Replacing "echo -e" with "printf".
> > * This mimics a previous de-bashify patch applied to this same recipe.
> >
> > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>
> How is it different from this:
> http://arago-project.org/git/?p=meta-arago.git;a=commitdiff;h=7f47dbad47a44c8d16c12139260a00b80d603e71
>
> I'd suggest you update your tree to the latest code base...
>
> Franklin:
> I see what happened.
> http://arago-project.org/pipermail/meta-arago/2012-November/000483.html you
> made a comment about pulling in this environment variables into
> meta-toolchain-arago and I made that change. You ended up doing the same
> thing that my patch
> http://arago-project.org/pipermail/meta-arago/2012-November/000520.html also
> did. Which this patch builds on top of.
I see, yes, I merged those vars into the base recipe and replaced echo with
printf. Wondering why it didn't give you a conflict, since you had to rebase
your work...
> > ---
> > .../recipes-core/meta/meta-toolchain-arago.bb | 20 ++++++++++----------
> > 1 files changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> > index 09996d6..3d3fb0d 100644
> > --- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> > +++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> > @@ -4,7 +4,7 @@ TOOLCHAIN_OUTPUTNAME ?= "${SDK_NAME}-${ARMPKGARCH}-${TARGET_OS}-sdk-${SDK_ARCH}"
> >
> > require recipes-core/meta/meta-toolchain.bb
> >
> > -PR = "r7"
> > +PR = "r8"
> >
> > SDKTARGETSYSROOT = "${SDKPATH}/${ARAGO_TARGET_SYS}"
> >
> > @@ -54,15 +54,15 @@ toolchain_create_sdk_env_script () {
> > echo 'export OECORE_ACLOCAL_OPTS="-I $SDK_PATH/usr/share/aclocal"' >> $script
> > echo 'export OECORE_DISTRO_VERSION="${DISTRO_VERSION}"' >> $script
> > echo 'export OECORE_SDK_VERSION="${SDK_VERSION}"' >> $script
> > - echo -e 'export CPP="\x24{TARGET_PREFIX}gcc -E"' >> $script
> > - echo -e 'export NM=\x24{TARGET_PREFIX}nm' >> $script
> > - echo -e 'export RANLIB=\x24{TARGET_PREFIX}ranlib' >> $script
> > - echo -e 'export OBJCOPY=\x24{TARGET_PREFIX}objcopy' >> $script
> > - echo -e 'export STRIP=\x24{TARGET_PREFIX}strip' >> $script
> > - echo -e 'export AS=\x24{TARGET_PREFIX}as' >> $script
> > - echo -e 'export AR=\x24{TARGET_PREFIX}ar' >> $script
> > - echo -e 'export OBJDUMP=\x24{TARGET_PREFIX}objdump' >> $script
> > - echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
> > + printf 'export CPP="\x24{TARGET_PREFIX}gcc -E"\n' >> $script
> > + printf 'export NM=\x24{TARGET_PREFIX}nm\n' >> $script
> > + printf 'export RANLIB=\x24{TARGET_PREFIX}ranlib\n' >> $script
> > + printf 'export OBJCOPY=\x24{TARGET_PREFIX}objcopy\n' >> $script
> > + printf 'export STRIP=\x24{TARGET_PREFIX}strip\n' >> $script
> > + printf 'export AS=\x24{TARGET_PREFIX}as\n' >> $script
> > + printf 'export AR=\x24{TARGET_PREFIX}ar\n' >> $script
> > + printf 'export OBJDUMP=\x24{TARGET_PREFIX}objdump\n' >> $script
> > + echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
> > }
> >
> > populate_sdk_ipk_append () {
> > --
> > 1.7.0.4
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> >
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-12 23:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-12 22:33 [PATCH] meta-toolchain-arago: de-bashify Franklin S. Cooper Jr
2012-11-12 23:20 ` Denys Dmytriyenko
2012-11-12 23:40 ` Cooper Jr., Franklin
2012-11-12 23:49 ` Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.