From: Thierry Reding <thierry.reding@avionic-design.de>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: linux-fbdev@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
devicetree-discuss@lists.ozlabs.org,
dri-devel@lists.freedesktop.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Rob Herring <robherring2@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
kernel@pengutronix.de,
Guennady Liakhovetski <g.liakhovetski@gmx.de>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v8 5/6] drm_modes: add videomode helpers
Date: Tue, 13 Nov 2012 11:31:14 +0000 [thread overview]
Message-ID: <20121113113114.GD30049@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1352734626-27412-6-git-send-email-s.trumtrar@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On Mon, Nov 12, 2012 at 04:37:05PM +0100, Steffen Trumtrar wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
[...]
> +#if IS_ENABLED(CONFIG_VIDEOMODE)
> +int videomode_to_display_mode(struct videomode *vm, struct drm_display_mode *dmode)
This one as well may be more consistently named
drm_display_mode_from_videomode().
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
[...]
> +extern int videomode_to_display_mode(struct videomode *vm,
> + struct drm_display_mode *dmode);
And this also needs protection or a dummy.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: linux-fbdev@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
devicetree-discuss@lists.ozlabs.org,
dri-devel@lists.freedesktop.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Rob Herring <robherring2@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
kernel@pengutronix.de,
Guennady Liakhovetski <g.liakhovetski@gmx.de>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v8 5/6] drm_modes: add videomode helpers
Date: Tue, 13 Nov 2012 12:31:14 +0100 [thread overview]
Message-ID: <20121113113114.GD30049@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1352734626-27412-6-git-send-email-s.trumtrar@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 580 bytes --]
On Mon, Nov 12, 2012 at 04:37:05PM +0100, Steffen Trumtrar wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
[...]
> +#if IS_ENABLED(CONFIG_VIDEOMODE)
> +int videomode_to_display_mode(struct videomode *vm, struct drm_display_mode *dmode)
This one as well may be more consistently named
drm_display_mode_from_videomode().
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
[...]
> +extern int videomode_to_display_mode(struct videomode *vm,
> + struct drm_display_mode *dmode);
And this also needs protection or a dummy.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: devicetree-discuss@lists.ozlabs.org,
Rob Herring <robherring2@gmail.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Guennady Liakhovetski <g.liakhovetski@gmx.de>,
linux-media@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Stephen Warren <swarren@wwwdotorg.org>,
kernel@pengutronix.de
Subject: Re: [PATCH v8 5/6] drm_modes: add videomode helpers
Date: Tue, 13 Nov 2012 12:31:14 +0100 [thread overview]
Message-ID: <20121113113114.GD30049@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1352734626-27412-6-git-send-email-s.trumtrar@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On Mon, Nov 12, 2012 at 04:37:05PM +0100, Steffen Trumtrar wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
[...]
> +#if IS_ENABLED(CONFIG_VIDEOMODE)
> +int videomode_to_display_mode(struct videomode *vm, struct drm_display_mode *dmode)
This one as well may be more consistently named
drm_display_mode_from_videomode().
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
[...]
> +extern int videomode_to_display_mode(struct videomode *vm,
> + struct drm_display_mode *dmode);
And this also needs protection or a dummy.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-13 11:31 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 15:37 [PATCH v8 0/6] of: add display helper Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-12 15:37 ` [PATCH v8 1/6] video: add display_timing and videomode Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-13 10:41 ` Thierry Reding
2012-11-13 10:41 ` Thierry Reding
[not found] ` <20121113104159.GA18645-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-13 13:14 ` Steffen Trumtrar
2012-11-13 13:14 ` Steffen Trumtrar
2012-11-13 13:14 ` Steffen Trumtrar
2012-11-14 10:56 ` Thierry Reding
2012-11-14 10:56 ` Thierry Reding
[not found] ` <20121114105634.GA31801-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-14 10:59 ` Steffen Trumtrar
2012-11-14 10:59 ` Steffen Trumtrar
2012-11-14 10:59 ` Steffen Trumtrar
2012-11-14 11:02 ` Thierry Reding
2012-11-14 11:02 ` Thierry Reding
[not found] ` <20121114110215.GA31999-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-14 11:10 ` Steffen Trumtrar
2012-11-14 11:10 ` Steffen Trumtrar
2012-11-14 11:10 ` Steffen Trumtrar
2012-11-14 11:17 ` Thierry Reding
2012-11-14 11:17 ` Thierry Reding
2012-11-12 15:37 ` [PATCH v8 2/6] video: add of helper for videomode Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-12 18:58 ` Sascha Hauer
2012-11-12 18:58 ` Sascha Hauer
2012-11-13 8:32 ` Steffen Trumtrar
2012-11-13 8:32 ` Steffen Trumtrar
2012-11-12 19:00 ` Alexey Klimov
2012-11-12 19:00 ` Alexey Klimov
2012-11-13 10:53 ` Steffen Trumtrar
2012-11-13 10:53 ` Steffen Trumtrar
2012-11-12 20:40 ` Stephen Warren
2012-11-12 20:40 ` Stephen Warren
2012-11-13 12:59 ` Steffen Trumtrar
2012-11-13 12:59 ` Steffen Trumtrar
2012-11-13 11:08 ` Thierry Reding
2012-11-13 11:08 ` Thierry Reding
2012-11-13 17:46 ` Stephen Warren
2012-11-13 17:46 ` Stephen Warren
[not found] ` <50A2878D.8020707-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-13 17:51 ` Thierry Reding
2012-11-13 17:51 ` Thierry Reding
2012-11-13 17:51 ` Thierry Reding
[not found] ` <20121113175147.GA2597-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-13 18:13 ` Mitch Bradley
2012-11-13 18:13 ` Mitch Bradley
2012-11-13 18:13 ` Mitch Bradley
2012-11-13 19:17 ` Thierry Reding
2012-11-13 19:17 ` Thierry Reding
2012-11-14 10:59 ` Thierry Reding
2012-11-14 10:59 ` Thierry Reding
2012-11-12 15:37 ` [PATCH v8 3/6] fbmon: add videomode helpers Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-13 11:22 ` Thierry Reding
2012-11-13 11:22 ` Thierry Reding
2012-11-13 13:28 ` Steffen Trumtrar
2012-11-13 13:28 ` Steffen Trumtrar
2012-11-12 15:37 ` [PATCH v8 4/6] fbmon: add of_videomode helpers Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-13 11:28 ` Thierry Reding
2012-11-13 11:28 ` Thierry Reding
2012-11-12 15:37 ` [PATCH v8 5/6] drm_modes: add videomode helpers Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-13 11:31 ` Thierry Reding [this message]
2012-11-13 11:31 ` Thierry Reding
2012-11-13 11:31 ` Thierry Reding
2012-11-12 15:37 ` [PATCH v8 6/6] drm_modes: add of_videomode helpers Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-13 11:35 ` Thierry Reding
2012-11-13 11:35 ` Thierry Reding
2012-11-13 13:30 ` Steffen Trumtrar
2012-11-13 13:30 ` Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113113114.GD30049@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=g.liakhovetski@gmx.de \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=robherring2@gmail.com \
--cc=s.trumtrar@pengutronix.de \
--cc=swarren@wwwdotorg.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.