From: Thierry Reding <thierry.reding@avionic-design.de>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Steffen Trumtrar
<s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Guennady Liakhovetski
<g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v8 2/6] video: add of helper for videomode
Date: Tue, 13 Nov 2012 17:51:47 +0000 [thread overview]
Message-ID: <20121113175147.GA2597@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <50A2878D.8020707-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]
On Tue, Nov 13, 2012 at 10:46:53AM -0700, Stephen Warren wrote:
> On 11/13/2012 04:08 AM, Thierry Reding wrote:
> > On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote:
> >> This adds support for reading display timings from DT or/and
> >> convert one of those timings to a videomode. The
> >> of_display_timing implementation supports multiple children where
> >> each property can have up to 3 values. All children are read into
> >> an array, that can be queried. of_get_videomode converts exactly
> >> one of that timings to a struct videomode.
>
> >> diff --git
> >> a/Documentation/devicetree/bindings/video/display-timings.txt
> >> b/Documentation/devicetree/bindings/video/display-timings.txt
>
> >> + - clock-frequency: displayclock in Hz
> >
> > "display clock"?
>
> I /think/ I had suggested naming this clock-frequency before so that
> the property name would be more standardized; other bindings use that
> same name. But I'm not too attached to the name I guess.
That's not what I meant. I think "displayclock" should be two words in
the description of the property. The property name is fine.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Steffen Trumtrar
<s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Guennady Liakhovetski
<g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v8 2/6] video: add of helper for videomode
Date: Tue, 13 Nov 2012 18:51:47 +0100 [thread overview]
Message-ID: <20121113175147.GA2597@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <50A2878D.8020707-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1161 bytes --]
On Tue, Nov 13, 2012 at 10:46:53AM -0700, Stephen Warren wrote:
> On 11/13/2012 04:08 AM, Thierry Reding wrote:
> > On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote:
> >> This adds support for reading display timings from DT or/and
> >> convert one of those timings to a videomode. The
> >> of_display_timing implementation supports multiple children where
> >> each property can have up to 3 values. All children are read into
> >> an array, that can be queried. of_get_videomode converts exactly
> >> one of that timings to a struct videomode.
>
> >> diff --git
> >> a/Documentation/devicetree/bindings/video/display-timings.txt
> >> b/Documentation/devicetree/bindings/video/display-timings.txt
>
> >> + - clock-frequency: displayclock in Hz
> >
> > "display clock"?
>
> I /think/ I had suggested naming this clock-frequency before so that
> the property name would be more standardized; other bindings use that
> same name. But I'm not too attached to the name I guess.
That's not what I meant. I think "displayclock" should be two words in
the description of the property. The property name is fine.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
devicetree-discuss@lists.ozlabs.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robherring2@gmail.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Guennady Liakhovetski <g.liakhovetski@gmx.de>,
linux-media@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
kernel@pengutronix.de
Subject: Re: [PATCH v8 2/6] video: add of helper for videomode
Date: Tue, 13 Nov 2012 18:51:47 +0100 [thread overview]
Message-ID: <20121113175147.GA2597@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <50A2878D.8020707@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]
On Tue, Nov 13, 2012 at 10:46:53AM -0700, Stephen Warren wrote:
> On 11/13/2012 04:08 AM, Thierry Reding wrote:
> > On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote:
> >> This adds support for reading display timings from DT or/and
> >> convert one of those timings to a videomode. The
> >> of_display_timing implementation supports multiple children where
> >> each property can have up to 3 values. All children are read into
> >> an array, that can be queried. of_get_videomode converts exactly
> >> one of that timings to a struct videomode.
>
> >> diff --git
> >> a/Documentation/devicetree/bindings/video/display-timings.txt
> >> b/Documentation/devicetree/bindings/video/display-timings.txt
>
> >> + - clock-frequency: displayclock in Hz
> >
> > "display clock"?
>
> I /think/ I had suggested naming this clock-frequency before so that
> the property name would be more standardized; other bindings use that
> same name. But I'm not too attached to the name I guess.
That's not what I meant. I think "displayclock" should be two words in
the description of the property. The property name is fine.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-13 17:51 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 15:37 [PATCH v8 0/6] of: add display helper Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-12 15:37 ` [PATCH v8 1/6] video: add display_timing and videomode Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-13 10:41 ` Thierry Reding
2012-11-13 10:41 ` Thierry Reding
[not found] ` <20121113104159.GA18645-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-13 13:14 ` Steffen Trumtrar
2012-11-13 13:14 ` Steffen Trumtrar
2012-11-13 13:14 ` Steffen Trumtrar
2012-11-14 10:56 ` Thierry Reding
2012-11-14 10:56 ` Thierry Reding
[not found] ` <20121114105634.GA31801-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-14 10:59 ` Steffen Trumtrar
2012-11-14 10:59 ` Steffen Trumtrar
2012-11-14 10:59 ` Steffen Trumtrar
2012-11-14 11:02 ` Thierry Reding
2012-11-14 11:02 ` Thierry Reding
[not found] ` <20121114110215.GA31999-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-14 11:10 ` Steffen Trumtrar
2012-11-14 11:10 ` Steffen Trumtrar
2012-11-14 11:10 ` Steffen Trumtrar
2012-11-14 11:17 ` Thierry Reding
2012-11-14 11:17 ` Thierry Reding
2012-11-12 15:37 ` [PATCH v8 2/6] video: add of helper for videomode Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-12 18:58 ` Sascha Hauer
2012-11-12 18:58 ` Sascha Hauer
2012-11-13 8:32 ` Steffen Trumtrar
2012-11-13 8:32 ` Steffen Trumtrar
2012-11-12 19:00 ` Alexey Klimov
2012-11-12 19:00 ` Alexey Klimov
2012-11-13 10:53 ` Steffen Trumtrar
2012-11-13 10:53 ` Steffen Trumtrar
2012-11-12 20:40 ` Stephen Warren
2012-11-12 20:40 ` Stephen Warren
2012-11-13 12:59 ` Steffen Trumtrar
2012-11-13 12:59 ` Steffen Trumtrar
2012-11-13 11:08 ` Thierry Reding
2012-11-13 11:08 ` Thierry Reding
2012-11-13 17:46 ` Stephen Warren
2012-11-13 17:46 ` Stephen Warren
[not found] ` <50A2878D.8020707-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-13 17:51 ` Thierry Reding [this message]
2012-11-13 17:51 ` Thierry Reding
2012-11-13 17:51 ` Thierry Reding
[not found] ` <20121113175147.GA2597-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-13 18:13 ` Mitch Bradley
2012-11-13 18:13 ` Mitch Bradley
2012-11-13 18:13 ` Mitch Bradley
2012-11-13 19:17 ` Thierry Reding
2012-11-13 19:17 ` Thierry Reding
2012-11-14 10:59 ` Thierry Reding
2012-11-14 10:59 ` Thierry Reding
2012-11-12 15:37 ` [PATCH v8 3/6] fbmon: add videomode helpers Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-13 11:22 ` Thierry Reding
2012-11-13 11:22 ` Thierry Reding
2012-11-13 13:28 ` Steffen Trumtrar
2012-11-13 13:28 ` Steffen Trumtrar
2012-11-12 15:37 ` [PATCH v8 4/6] fbmon: add of_videomode helpers Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-13 11:28 ` Thierry Reding
2012-11-13 11:28 ` Thierry Reding
2012-11-12 15:37 ` [PATCH v8 5/6] drm_modes: add videomode helpers Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-13 11:31 ` Thierry Reding
2012-11-13 11:31 ` Thierry Reding
2012-11-13 11:31 ` Thierry Reding
2012-11-12 15:37 ` [PATCH v8 6/6] drm_modes: add of_videomode helpers Steffen Trumtrar
2012-11-12 15:37 ` Steffen Trumtrar
2012-11-13 11:35 ` Thierry Reding
2012-11-13 11:35 ` Thierry Reding
2012-11-13 13:30 ` Steffen Trumtrar
2012-11-13 13:30 ` Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113175147.GA2597@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=g.liakhovetski-Mmb7MZpHnFY@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=tomi.valkeinen-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.