From: Kumar amit mehta <gmate.amit@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, alan@lxorguk.ukuu.org.uk,
wfp5p@virginia.edu, geert@linux-m68k.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: dgrp: dgrp_tty.c: Audit the return values of get/put_user()
Date: Mon, 19 Nov 2012 13:20:29 +0000 [thread overview]
Message-ID: <20121119130829.GB3275@gmail.com> (raw)
In-Reply-To: <20121119111553.GC6186@mwanda>
On Mon, Nov 19, 2012 at 02:15:54PM +0300, Dan Carpenter wrote:
> On Mon, Nov 19, 2012 at 04:25:31PM +0530, Kumar Amit Mehta wrote:
> > -- fix for missing audits for return values of get_user() and put_user().
> > -- Remove the TIOCSSOFTCAR ioctl handling from dgrp driver.
>
> These should be done in separate commits.
>
> Are the calls to access_ok() still needed if we check get_user() and
> put_user()?
>
You are right, access_ok() would become redundant if we check get/put_user().
Also, After sending one patch for removing TIOCSSOFTCAR ioctl handler from dgrp
driver, I realized that I should be sending two patches as patch series. Please
correct me if I'm wrong.
Regards,
Amit
WARNING: multiple messages have this Message-ID (diff)
From: Kumar amit mehta <gmate.amit@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, alan@lxorguk.ukuu.org.uk,
wfp5p@virginia.edu, geert@linux-m68k.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: dgrp: dgrp_tty.c: Audit the return values of get/put_user()
Date: Mon, 19 Nov 2012 18:38:29 +0530 [thread overview]
Message-ID: <20121119130829.GB3275@gmail.com> (raw)
In-Reply-To: <20121119111553.GC6186@mwanda>
On Mon, Nov 19, 2012 at 02:15:54PM +0300, Dan Carpenter wrote:
> On Mon, Nov 19, 2012 at 04:25:31PM +0530, Kumar Amit Mehta wrote:
> > -- fix for missing audits for return values of get_user() and put_user().
> > -- Remove the TIOCSSOFTCAR ioctl handling from dgrp driver.
>
> These should be done in separate commits.
>
> Are the calls to access_ok() still needed if we check get_user() and
> put_user()?
>
You are right, access_ok() would become redundant if we check get/put_user().
Also, After sending one patch for removing TIOCSSOFTCAR ioctl handler from dgrp
driver, I realized that I should be sending two patches as patch series. Please
correct me if I'm wrong.
Regards,
Amit
next prev parent reply other threads:[~2012-11-19 13:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 10:55 [PATCH] staging: dgrp: dgrp_tty.c: Audit the return values of get/put_user() Kumar Amit Mehta
2012-11-19 11:07 ` Kumar Amit Mehta
2012-11-19 11:15 ` Dan Carpenter
2012-11-19 11:15 ` Dan Carpenter
2012-11-19 13:08 ` Kumar amit mehta [this message]
2012-11-19 13:20 ` Kumar amit mehta
2012-11-19 13:39 ` Dan Carpenter
2012-11-19 13:39 ` Dan Carpenter
2012-11-21 22:11 ` Greg KH
2012-11-21 22:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119130829.GB3275@gmail.com \
--to=gmate.amit@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.