All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kumar amit mehta <gmate.amit@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org, geert@linux-m68k.org,
	alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] staging: dgrp: dgrp_tty.c: Audit the return values of get/put_user()
Date: Wed, 21 Nov 2012 22:11:39 +0000	[thread overview]
Message-ID: <20121121221139.GA7682@kroah.com> (raw)
In-Reply-To: <20121119130829.GB3275@gmail.com>

On Mon, Nov 19, 2012 at 06:38:29PM +0530, Kumar amit mehta wrote:
> On Mon, Nov 19, 2012 at 02:15:54PM +0300, Dan Carpenter wrote:
> > On Mon, Nov 19, 2012 at 04:25:31PM +0530, Kumar Amit Mehta wrote:
> > > -- fix for missing audits for return values of get_user() and put_user().
> > > -- Remove the TIOCSSOFTCAR ioctl handling from dgrp driver.
> > 
> > These should be done in separate commits.
> > 
> > Are the calls to access_ok() still needed if we check get_user() and
> > put_user()?
> >
> You are right, access_ok() would become redundant if we check get/put_user().
> Also, After sending one patch for removing TIOCSSOFTCAR ioctl handler from dgrp
> driver, I realized that I should be sending two patches as patch series. Please
> correct me if I'm wrong.

Yes, please resend, as I can't apply this one, and the other patch you
sent me as they conflict.  So please resend them both in proper format.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Kumar amit mehta <gmate.amit@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org, geert@linux-m68k.org,
	alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] staging: dgrp: dgrp_tty.c: Audit the return values of get/put_user()
Date: Wed, 21 Nov 2012 14:11:39 -0800	[thread overview]
Message-ID: <20121121221139.GA7682@kroah.com> (raw)
In-Reply-To: <20121119130829.GB3275@gmail.com>

On Mon, Nov 19, 2012 at 06:38:29PM +0530, Kumar amit mehta wrote:
> On Mon, Nov 19, 2012 at 02:15:54PM +0300, Dan Carpenter wrote:
> > On Mon, Nov 19, 2012 at 04:25:31PM +0530, Kumar Amit Mehta wrote:
> > > -- fix for missing audits for return values of get_user() and put_user().
> > > -- Remove the TIOCSSOFTCAR ioctl handling from dgrp driver.
> > 
> > These should be done in separate commits.
> > 
> > Are the calls to access_ok() still needed if we check get_user() and
> > put_user()?
> >
> You are right, access_ok() would become redundant if we check get/put_user().
> Also, After sending one patch for removing TIOCSSOFTCAR ioctl handler from dgrp
> driver, I realized that I should be sending two patches as patch series. Please
> correct me if I'm wrong.

Yes, please resend, as I can't apply this one, and the other patch you
sent me as they conflict.  So please resend them both in proper format.

thanks,

greg k-h

  parent reply	other threads:[~2012-11-21 22:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 10:55 [PATCH] staging: dgrp: dgrp_tty.c: Audit the return values of get/put_user() Kumar Amit Mehta
2012-11-19 11:07 ` Kumar Amit Mehta
2012-11-19 11:15 ` Dan Carpenter
2012-11-19 11:15   ` Dan Carpenter
2012-11-19 13:08   ` Kumar amit mehta
2012-11-19 13:20     ` Kumar amit mehta
2012-11-19 13:39     ` Dan Carpenter
2012-11-19 13:39       ` Dan Carpenter
2012-11-21 22:11     ` Greg KH [this message]
2012-11-21 22:11       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121121221139.GA7682@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=geert@linux-m68k.org \
    --cc=gmate.amit@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.