From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anton Arapov <anton@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/7] uprobes: Kill the "uprobe != NULL" check in uprobe_unregister()
Date: Fri, 23 Nov 2012 21:28:02 +0100 [thread overview]
Message-ID: <20121123202802.GA18884@redhat.com> (raw)
In-Reply-To: <20121123202741.GA18858@redhat.com>
Trivial. uprobe can't be NULL after mutex_unlock(), it was already used.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
kernel/events/uprobes.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index e9f22ed..13b247c 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -900,8 +900,7 @@ void uprobe_unregister(struct inode *inode, loff_t offset, struct uprobe_consume
}
mutex_unlock(uprobes_hash(inode));
- if (uprobe)
- put_uprobe(uprobe);
+ put_uprobe(uprobe);
}
static struct rb_node *
--
1.5.5.1
next prev parent reply other threads:[~2012-11-23 20:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 20:27 [PATCH 0/7] uprobes: register/unregister preparations for filtering Oleg Nesterov
2012-11-23 20:28 ` [PATCH 1/7] uprobes: Move __set_bit(UPROBE_SKIP_SSTEP) into alloc_uprobe() Oleg Nesterov
2012-12-10 5:56 ` Srikar Dronamraju
2012-11-23 20:28 ` Oleg Nesterov [this message]
2012-12-10 6:00 ` [PATCH 2/7] uprobes: Kill the "uprobe != NULL" check in uprobe_unregister() Srikar Dronamraju
2012-11-23 20:28 ` [PATCH 3/7] uprobes: Kill the pointless inode/uc checks in register/unregister Oleg Nesterov
2012-12-10 6:19 ` Srikar Dronamraju
2012-12-10 19:12 ` Oleg Nesterov
2012-12-13 10:35 ` Srikar Dronamraju
2012-12-13 13:15 ` Oleg Nesterov
2012-12-13 14:08 ` Srikar Dronamraju
2012-12-13 14:12 ` Srikar Dronamraju
2012-11-23 20:28 ` [PATCH 4/7] uprobes: Kill uprobe_consumer->filter() Oleg Nesterov
2012-12-10 12:02 ` Srikar Dronamraju
2012-11-23 20:28 ` [PATCH 5/7] uprobes: Introduce filter_chain() Oleg Nesterov
2012-11-24 16:08 ` Oleg Nesterov
2012-12-10 12:04 ` Srikar Dronamraju
2012-11-23 20:28 ` [PATCH 6/7] uprobes: _unregister() should always do register_for_each_vma(false) Oleg Nesterov
2012-11-23 20:28 ` [PATCH 7/7] uprobes: _register() should always do register_for_each_vma(true) Oleg Nesterov
2012-12-13 10:26 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121123202802.GA18884@redhat.com \
--to=oleg@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.