From: Dan Carpenter <dan.carpenter@oracle.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Russ Anderson <rja@sgi.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
walter harms <wharms@bfs.de>
Subject: Re: [patch v3] x86, UV: integer wrap bug in uv_hub_ipi_value()
Date: Sun, 02 Dec 2012 17:35:18 +0000 [thread overview]
Message-ID: <20121202173517.GB6568@mwanda> (raw)
In-Reply-To: <20121202172842.GA20110@elgon.mountain>
On Sun, Dec 02, 2012 at 08:28:43PM +0300, Dan Carpenter wrote:
> This is a static checker fix. The problem is that we store the bits
> from "uv_apicid_hibits" into "apicid" (the high 16 bits) but then we
> shift it 16 bit to the left. "apicid" is an int so it wraps and we lose
> them.
>
> I have also simplified uv_wakeup_secondary() a little based on a
> suggestion.
This was supposed to say "suggestions from Walter Harms." but I
pressed "u" in vim instead of "i" because they are next to each
other so that that got deleted. @%$@#$%@%$. I'll resend.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Russ Anderson <rja@sgi.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
walter harms <wharms@bfs.de>
Subject: Re: [patch v3] x86, UV: integer wrap bug in uv_hub_ipi_value()
Date: Sun, 2 Dec 2012 20:35:18 +0300 [thread overview]
Message-ID: <20121202173517.GB6568@mwanda> (raw)
In-Reply-To: <20121202172842.GA20110@elgon.mountain>
On Sun, Dec 02, 2012 at 08:28:43PM +0300, Dan Carpenter wrote:
> This is a static checker fix. The problem is that we store the bits
> from "uv_apicid_hibits" into "apicid" (the high 16 bits) but then we
> shift it 16 bit to the left. "apicid" is an int so it wraps and we lose
> them.
>
> I have also simplified uv_wakeup_secondary() a little based on a
> suggestion.
This was supposed to say "suggestions from Walter Harms." but I
pressed "u" in vim instead of "i" because they are next to each
other so that that got deleted. @%$@#$%@%$. I'll resend.
regards,
dan carpenter
next prev parent reply other threads:[~2012-12-02 17:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 15:16 [patch] x86, UV: integer wrap bug in uv_hub_ipi_value() Dan Carpenter
2012-11-17 15:16 ` Dan Carpenter
2012-11-20 0:48 ` Russ Anderson
2012-11-20 0:48 ` Russ Anderson
2012-11-20 4:28 ` Dan Carpenter
2012-11-20 4:28 ` Dan Carpenter
2012-11-20 4:55 ` H. Peter Anvin
2012-11-20 4:55 ` H. Peter Anvin
2012-11-20 11:10 ` Alan Cox
2012-11-20 16:27 ` Russ Anderson
2012-11-20 16:27 ` Russ Anderson
2012-11-20 17:09 ` H. Peter Anvin
2012-11-20 17:09 ` H. Peter Anvin
2012-11-20 17:07 ` Russ Anderson
2012-11-20 17:07 ` Russ Anderson
2012-11-21 7:39 ` Dan Carpenter
2012-11-21 7:39 ` Dan Carpenter
2012-12-02 10:44 ` [patch v2] " Dan Carpenter
2012-12-02 10:44 ` Dan Carpenter
2012-12-02 15:33 ` walter harms
2012-12-02 15:33 ` walter harms
2012-12-02 17:28 ` [patch v3] " Dan Carpenter
2012-12-02 17:28 ` Dan Carpenter
2012-12-02 17:35 ` Dan Carpenter [this message]
2012-12-02 17:35 ` Dan Carpenter
2012-12-03 7:58 ` [patch v4] " Dan Carpenter
2012-12-03 7:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121202173517.GB6568@mwanda \
--to=dan.carpenter@oracle.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rja@sgi.com \
--cc=tglx@linutronix.de \
--cc=wharms@bfs.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.