From: "H. Peter Anvin" <hpa@zytor.com>
To: Russ Anderson <rja@sgi.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Dan Carpenter <dan.carpenter@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dimitri Sivanich <sivanich@sgi.com>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] x86, UV: integer wrap bug in uv_hub_ipi_value()
Date: Tue, 20 Nov 2012 17:09:01 +0000 [thread overview]
Message-ID: <50ABB92D.5090401@zytor.com> (raw)
In-Reply-To: <20121120162706.GB11150@sgi.com>
On 11/20/2012 08:27 AM, Russ Anderson wrote:
>
> I very much agree. I prefer u32, u64 (etc) because they are
> unambiguous. It removes all doubt as to the actual meaning.
>
> Conversly, the fact that "long" has different meanings makes
> it at best problematic. Was the code written assuming "long"
> was 32 or 64 bits? Having data types that can have different
> sizes is just asking for trouble.
>
In the Linux kernel context, "long" effectively means the native size
(size_t/intptr_t/ptrdiff_t).
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Russ Anderson <rja@sgi.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Dan Carpenter <dan.carpenter@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dimitri Sivanich <sivanich@sgi.com>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] x86, UV: integer wrap bug in uv_hub_ipi_value()
Date: Tue, 20 Nov 2012 09:09:01 -0800 [thread overview]
Message-ID: <50ABB92D.5090401@zytor.com> (raw)
In-Reply-To: <20121120162706.GB11150@sgi.com>
On 11/20/2012 08:27 AM, Russ Anderson wrote:
>
> I very much agree. I prefer u32, u64 (etc) because they are
> unambiguous. It removes all doubt as to the actual meaning.
>
> Conversly, the fact that "long" has different meanings makes
> it at best problematic. Was the code written assuming "long"
> was 32 or 64 bits? Having data types that can have different
> sizes is just asking for trouble.
>
In the Linux kernel context, "long" effectively means the native size
(size_t/intptr_t/ptrdiff_t).
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-11-20 17:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 15:16 [patch] x86, UV: integer wrap bug in uv_hub_ipi_value() Dan Carpenter
2012-11-17 15:16 ` Dan Carpenter
2012-11-20 0:48 ` Russ Anderson
2012-11-20 0:48 ` Russ Anderson
2012-11-20 4:28 ` Dan Carpenter
2012-11-20 4:28 ` Dan Carpenter
2012-11-20 4:55 ` H. Peter Anvin
2012-11-20 4:55 ` H. Peter Anvin
2012-11-20 11:10 ` Alan Cox
2012-11-20 16:27 ` Russ Anderson
2012-11-20 16:27 ` Russ Anderson
2012-11-20 17:09 ` H. Peter Anvin [this message]
2012-11-20 17:09 ` H. Peter Anvin
2012-11-20 17:07 ` Russ Anderson
2012-11-20 17:07 ` Russ Anderson
2012-11-21 7:39 ` Dan Carpenter
2012-11-21 7:39 ` Dan Carpenter
2012-12-02 10:44 ` [patch v2] " Dan Carpenter
2012-12-02 10:44 ` Dan Carpenter
2012-12-02 15:33 ` walter harms
2012-12-02 15:33 ` walter harms
2012-12-02 17:28 ` [patch v3] " Dan Carpenter
2012-12-02 17:28 ` Dan Carpenter
2012-12-02 17:35 ` Dan Carpenter
2012-12-02 17:35 ` Dan Carpenter
2012-12-03 7:58 ` [patch v4] " Dan Carpenter
2012-12-03 7:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ABB92D.5090401@zytor.com \
--to=hpa@zytor.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rja@sgi.com \
--cc=sivanich@sgi.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.