From: Greg KH <gregkh@linuxfoundation.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, wfp5p@virginia.edu
Subject: Re: [GIT PULL] Remove __dev* markings from the networking drivers
Date: Tue, 4 Dec 2012 12:30:52 -0800 [thread overview]
Message-ID: <20121204203052.GB32674@kroah.com> (raw)
In-Reply-To: <20121204.131726.103739824056368439.davem@davemloft.net>
On Tue, Dec 04, 2012 at 01:17:26PM -0500, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Mon, 03 Dec 2012 15:36:23 -0500 (EST)
>
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Date: Mon, 3 Dec 2012 12:27:43 -0800
> >
> >> Here's a pull request for all of Bill's __dev* removal patches for the
> >> networking drivers, based on net-next. I'll send out a separate one for
> >> the wireless drivers in case those want to go through John's tree
> >>
> >> If I should rework these in any way, please let me know.
> >
> > Pulled, thanks Greg.
>
> I had a reason to go look in detail at the changes in here.
>
> It seemse the function declarations were not properly reformatted
> after the __dev* tags were removed. You can't just search and replace
> this kind of stuff. The result looks terrible.
>
> Greg please check for things like this next time you send me changes
> written by someone else.
Ick, sorry about that. Want me to fix them all back up? It's the least
I could do.
greg k-h
next prev parent reply other threads:[~2012-12-04 20:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 20:27 [GIT PULL] Remove __dev* markings from the networking drivers Greg KH
2012-12-03 20:36 ` David Miller
2012-12-04 18:17 ` David Miller
2012-12-04 20:30 ` Greg KH [this message]
2012-12-04 21:02 ` David Miller
2012-12-06 2:48 ` Greg KH
2012-12-06 2:51 ` David Miller
2012-12-06 2:52 ` David Miller
2012-12-06 2:56 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2012-12-03 20:29 Greg KH
2012-12-03 20:29 ` Greg KH
2012-12-06 20:11 ` John W. Linville
2012-12-06 20:11 ` John W. Linville
2012-12-06 20:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121204203052.GB32674@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.