All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, wfp5p@virginia.edu
Subject: Re: [GIT PULL] Remove __dev* markings from the networking drivers
Date: Wed, 5 Dec 2012 18:56:44 -0800	[thread overview]
Message-ID: <20121206025644.GA27279@kroah.com> (raw)
In-Reply-To: <20121205.215246.789211879539058594.davem@davemloft.net>

On Wed, Dec 05, 2012 at 09:52:46PM -0500, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 05 Dec 2012 21:51:21 -0500 (EST)
> 
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Date: Wed, 5 Dec 2012 18:48:33 -0800
> > 
> >> On Tue, Dec 04, 2012 at 04:02:57PM -0500, David Miller wrote:
> >>> From: Greg KH <gregkh@linuxfoundation.org>
> >>> Date: Tue, 4 Dec 2012 12:30:52 -0800
> >>> 
> >>> > On Tue, Dec 04, 2012 at 01:17:26PM -0500, David Miller wrote:
> >>> >> It seemse the function declarations were not properly reformatted
> >>> >> after the __dev* tags were removed.  You can't just search and replace
> >>> >> this kind of stuff.  The result looks terrible.
> >>> >> 
> >>> >> Greg please check for things like this next time you send me changes
> >>> >> written by someone else.
> >>> > 
> >>> > Ick, sorry about that.  Want me to fix them all back up?  It's the least
> >>> > I could do.
> >>> 
> >>> If you could do that, I'd really appreciate it.
> >> 
> >> I don't see these patches in your net-next branch yet, so should I just
> >> make this against this branch and do a new pull request?  Or am I not
> >> looking at net-next properly?
> > 
> > The drivers/net changes definitely are in my net-next tree.  I only use
> > the 'master' branch.
> 
> The merge commit is 682d7978aee072f411fc747d32954a8371dd7b1b

Ugh, sorry about that, I forgot I had pointed my repo at my copy, not
yours, my fault, you are right.  sorry for the noise.

greg "time to knock off for the night, I'm doing stupid mistakes" k-h

  reply	other threads:[~2012-12-06  2:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-03 20:27 [GIT PULL] Remove __dev* markings from the networking drivers Greg KH
2012-12-03 20:36 ` David Miller
2012-12-04 18:17   ` David Miller
2012-12-04 20:30     ` Greg KH
2012-12-04 21:02       ` David Miller
2012-12-06  2:48         ` Greg KH
2012-12-06  2:51           ` David Miller
2012-12-06  2:52             ` David Miller
2012-12-06  2:56               ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-12-03 20:29 Greg KH
2012-12-03 20:29 ` Greg KH
2012-12-06 20:11 ` John W. Linville
2012-12-06 20:11   ` John W. Linville
2012-12-06 20:23   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121206025644.GA27279@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=wfp5p@virginia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.