* [PATCH] drm/i915: fixup l3 parity sysfs access check
@ 2012-12-05 8:52 Daniel Vetter
2012-12-05 16:41 ` Ben Widawsky
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2012-12-05 8:52 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter, Ben Widawsky
When l3 parity support for Haswell was enabled in
commit f27b92651d72e863c308ea5dca5615fc98e38ca6
Author: Ben Widawsky <benjamin.widawsky@intel.com>
Date: Tue Jul 24 20:47:32 2012 -0700
drm/i915: Expand DPF support to Haswell
no one noticed that the patch which introduced this macro
commit e1ef7cc299839e68dae3f1843f62e52acda04538
Author: Ben Widawsky <benjamin.widawsky@intel.com>
Date: Tue Jul 24 20:47:31 2012 -0700
drm/i915: Macro to determine DPF support
missed one spot. Fix this.
Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57441
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/i915_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
index 3bf51d5..9462081 100644
--- a/drivers/gpu/drm/i915/i915_sysfs.c
+++ b/drivers/gpu/drm/i915/i915_sysfs.c
@@ -97,7 +97,7 @@ static struct attribute_group rc6_attr_group = {
static int l3_access_valid(struct drm_device *dev, loff_t offset)
{
- if (!IS_IVYBRIDGE(dev))
+ if (!HAS_L3_GPU_CACHE(dev))
return -EPERM;
if (offset % 4 != 0)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: fixup l3 parity sysfs access check
2012-12-05 8:52 [PATCH] drm/i915: fixup l3 parity sysfs access check Daniel Vetter
@ 2012-12-05 16:41 ` Ben Widawsky
2012-12-05 18:10 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Ben Widawsky @ 2012-12-05 16:41 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Intel Graphics Development, Ben Widawsky
On Wed, 5 Dec 2012 09:52:14 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> When l3 parity support for Haswell was enabled in
>
> commit f27b92651d72e863c308ea5dca5615fc98e38ca6
> Author: Ben Widawsky <benjamin.widawsky@intel.com>
> Date: Tue Jul 24 20:47:32 2012 -0700
>
> drm/i915: Expand DPF support to Haswell
>
> no one noticed that the patch which introduced this macro
>
> commit e1ef7cc299839e68dae3f1843f62e52acda04538
> Author: Ben Widawsky <benjamin.widawsky@intel.com>
> Date: Tue Jul 24 20:47:31 2012 -0700
>
> drm/i915: Macro to determine DPF support
>
> missed one spot. Fix this.
>
> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57441
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Ben Widawsky <benjamin.widawsky@intel.com>
> ---
> drivers/gpu/drm/i915/i915_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_sysfs.c
> b/drivers/gpu/drm/i915/i915_sysfs.c index 3bf51d5..9462081 100644
> --- a/drivers/gpu/drm/i915/i915_sysfs.c
> +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> @@ -97,7 +97,7 @@ static struct attribute_group rc6_attr_group = {
>
> static int l3_access_valid(struct drm_device *dev, loff_t offset)
> {
> - if (!IS_IVYBRIDGE(dev))
> + if (!HAS_L3_GPU_CACHE(dev))
> return -EPERM;
>
> if (offset % 4 != 0)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: fixup l3 parity sysfs access check
2012-12-05 16:41 ` Ben Widawsky
@ 2012-12-05 18:10 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2012-12-05 18:10 UTC (permalink / raw)
To: Ben Widawsky; +Cc: Daniel Vetter, Intel Graphics Development, Ben Widawsky
On Wed, Dec 05, 2012 at 08:41:25AM -0800, Ben Widawsky wrote:
> On Wed, 5 Dec 2012 09:52:14 +0100
> Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
> > When l3 parity support for Haswell was enabled in
> >
> > commit f27b92651d72e863c308ea5dca5615fc98e38ca6
> > Author: Ben Widawsky <benjamin.widawsky@intel.com>
> > Date: Tue Jul 24 20:47:32 2012 -0700
> >
> > drm/i915: Expand DPF support to Haswell
> >
> > no one noticed that the patch which introduced this macro
> >
> > commit e1ef7cc299839e68dae3f1843f62e52acda04538
> > Author: Ben Widawsky <benjamin.widawsky@intel.com>
> > Date: Tue Jul 24 20:47:31 2012 -0700
> >
> > drm/i915: Macro to determine DPF support
> >
> > missed one spot. Fix this.
> >
> > Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57441
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Reviewed-by: Ben Widawsky <benjamin.widawsky@intel.com>
Picked up for -fixes, thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-05 18:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-05 8:52 [PATCH] drm/i915: fixup l3 parity sysfs access check Daniel Vetter
2012-12-05 16:41 ` Ben Widawsky
2012-12-05 18:10 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.