From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Michel Lespinasse <walken@google.com>,
Hugh Dickins <hughd@google.com>, J??rn Engel <joern@logfs.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v2] mm: Downgrade mmap_sem before locking or populating on mmap
Date: Mon, 17 Dec 2012 10:52:31 +0100 [thread overview]
Message-ID: <20121217095231.GA1134@gmail.com> (raw)
In-Reply-To: <CALCETrX=3oQMKMNF2L3K7ur35KpeiqUN12RMq3XvtRChh9OJkg@mail.gmail.com>
* Andy Lutomirski <luto@amacapital.net> wrote:
> > 2)
> >
> > More aggressively, we could just make it the _rule_ that the
> > mm lock gets downgraded to read in mmap_region_helper(), no
> > matter what.
> >
> > From a quick look I *think* all the usage sites (including
> > sys_aio_setup()) are fine with that unlocking - but I could
> > be wrong.
>
> They are.
Lets try that then - the ugliness of the current patch is
certainly a problem.
Thanks,
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Michel Lespinasse <walken@google.com>,
Hugh Dickins <hughd@google.com>, J??rn Engel <joern@logfs.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v2] mm: Downgrade mmap_sem before locking or populating on mmap
Date: Mon, 17 Dec 2012 10:52:31 +0100 [thread overview]
Message-ID: <20121217095231.GA1134@gmail.com> (raw)
In-Reply-To: <CALCETrX=3oQMKMNF2L3K7ur35KpeiqUN12RMq3XvtRChh9OJkg@mail.gmail.com>
* Andy Lutomirski <luto@amacapital.net> wrote:
> > 2)
> >
> > More aggressively, we could just make it the _rule_ that the
> > mm lock gets downgraded to read in mmap_region_helper(), no
> > matter what.
> >
> > From a quick look I *think* all the usage sites (including
> > sys_aio_setup()) are fine with that unlocking - but I could
> > be wrong.
>
> They are.
Lets try that then - the ugliness of the current patch is
certainly a problem.
Thanks,
Ingo
next prev parent reply other threads:[~2012-12-17 9:52 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 5:49 [PATCH] mm: Downgrade mmap_sem before locking or populating on mmap Andy Lutomirski
2012-12-14 5:49 ` Andy Lutomirski
2012-12-14 7:27 ` Al Viro
2012-12-14 7:27 ` Al Viro
2012-12-14 11:14 ` Andy Lutomirski
2012-12-14 11:14 ` Andy Lutomirski
2012-12-14 14:49 ` Al Viro
2012-12-14 14:49 ` Al Viro
2012-12-14 16:12 ` Andy Lutomirski
2012-12-14 16:12 ` Andy Lutomirski
2012-12-16 8:41 ` Ingo Molnar
2012-12-16 8:41 ` Ingo Molnar
2012-12-16 17:04 ` Al Viro
2012-12-16 17:04 ` Al Viro
2012-12-16 17:48 ` Al Viro
2012-12-16 17:48 ` Al Viro
2012-12-16 18:49 ` Johannes Weiner
2012-12-16 18:49 ` Johannes Weiner
2012-12-16 19:53 ` Al Viro
2012-12-16 19:53 ` Al Viro
2012-12-16 20:16 ` Al Viro
2012-12-16 20:16 ` Al Viro
2012-12-15 2:17 ` [PATCH v2] " Andy Lutomirski
2012-12-15 2:17 ` Andy Lutomirski
2012-12-16 9:00 ` Ingo Molnar
2012-12-16 9:00 ` Ingo Molnar
2012-12-16 17:52 ` Andy Lutomirski
2012-12-16 17:52 ` Andy Lutomirski
2012-12-17 9:52 ` Ingo Molnar [this message]
2012-12-17 9:52 ` Ingo Molnar
2012-12-18 0:54 ` [PATCH v3] " Andy Lutomirski
2012-12-18 0:54 ` Andy Lutomirski
2012-12-20 2:22 ` Simon Jeons
2012-12-20 2:22 ` Simon Jeons
2012-12-16 12:39 ` [PATCH v2] " Michel Lespinasse
2012-12-16 12:39 ` Michel Lespinasse
2012-12-16 18:05 ` Andy Lutomirski
2012-12-16 18:05 ` Andy Lutomirski
2012-12-17 3:29 ` Michel Lespinasse
2012-12-17 3:29 ` Michel Lespinasse
2012-12-17 22:01 ` Andy Lutomirski
2012-12-17 22:01 ` Andy Lutomirski
2012-12-16 19:58 ` Linus Torvalds
2012-12-16 19:58 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217095231.GA1134@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.