From: Grant Likely <grant.likely@secretlab.ca>
To: Murali Karicheri <m-karicheri2@ti.com>,
rob.herring@calxeda.com, rob@landley.net,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
davinci-linux-open-source@linux.davincidsp.com,
linux-keystone@list.ti.com
Cc: Murali Karicheri <m-karicheri2@ti.com>
Subject: Re: [PATCH - v2] spi: davinci: add OF support for the spi controller
Date: Wed, 19 Dec 2012 13:18:50 +0000 [thread overview]
Message-ID: <20121219131850.E421B3E0AD7@localhost> (raw)
In-Reply-To: <20121215002758.14D223E0BEC@localhost>
On Sat, 15 Dec 2012 00:27:58 +0000, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Tue, 11 Dec 2012 16:20:39 -0500, Murali Karicheri <m-karicheri2@ti.com> wrote:
> > This adds OF support to DaVinci SPI controller to configure platform
> > data through device bindings. Also replaces clk_enable() with
> > of clk_prepare_enable() as well as clk_disable() with
> > clk_disable_unprepare().
> >
> > Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> > Reviewed-by : Grant Likely <grant.likely@secretlab.ca>
>
> Applied, thanks.
>
> I did remove the OF_ALIAS_N property though. I know the COMPATIBLE one
> uses it, but it is actually kind of redundant since it can also be
> determined by counting the number of OF_ALIAS_* entries, and having the
> _N one in there means extra work needs to be done to filter it out.
>
> Also, I had to add a #ifndef _LINUX_OF_PRIVATE_H wrapper around the
> whole header file. This is needed for all header files to protect
> against multiple includes.
Ummm.... oops. I replied to the wrong email when applying another patch.
Sorry for the noise.
But I have applied your patch now. It will appear in linux-next after
the merge window closes.
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: rob.herring@calxeda.com, rob@landley.net,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
davinci-linux-open-source@linux.davincidsp.com,
linux-keystone@list.ti.com
Cc: Murali Karicheri <m-karicheri2@ti.com>
Subject: Re: [PATCH - v2] spi: davinci: add OF support for the spi controller
Date: Wed, 19 Dec 2012 13:18:50 +0000 [thread overview]
Message-ID: <20121219131850.E421B3E0AD7@localhost> (raw)
In-Reply-To: <20121215002758.14D223E0BEC@localhost>
On Sat, 15 Dec 2012 00:27:58 +0000, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Tue, 11 Dec 2012 16:20:39 -0500, Murali Karicheri <m-karicheri2@ti.com> wrote:
> > This adds OF support to DaVinci SPI controller to configure platform
> > data through device bindings. Also replaces clk_enable() with
> > of clk_prepare_enable() as well as clk_disable() with
> > clk_disable_unprepare().
> >
> > Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> > Reviewed-by : Grant Likely <grant.likely@secretlab.ca>
>
> Applied, thanks.
>
> I did remove the OF_ALIAS_N property though. I know the COMPATIBLE one
> uses it, but it is actually kind of redundant since it can also be
> determined by counting the number of OF_ALIAS_* entries, and having the
> _N one in there means extra work needs to be done to filter it out.
>
> Also, I had to add a #ifndef _LINUX_OF_PRIVATE_H wrapper around the
> whole header file. This is needed for all header files to protect
> against multiple includes.
Ummm.... oops. I replied to the wrong email when applying another patch.
Sorry for the noise.
But I have applied your patch now. It will appear in linux-next after
the merge window closes.
g.
next prev parent reply other threads:[~2012-12-19 13:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 21:20 [PATCH - v2] spi: davinci: add OF support for the spi controller Murali Karicheri
2012-12-11 21:20 ` Murali Karicheri
2012-12-11 21:20 ` Murali Karicheri
2012-12-15 0:27 ` Grant Likely
2012-12-15 0:27 ` Grant Likely
2012-12-19 13:18 ` Grant Likely [this message]
2012-12-19 13:18 ` Grant Likely
2012-12-19 14:29 ` Murali Karicheri
2012-12-19 14:29 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219131850.E421B3E0AD7@localhost \
--to=grant.likely@secretlab.ca \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-keystone@list.ti.com \
--cc=m-karicheri2@ti.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.