Re: [PATCH - v2] spi: davinci: add OF support for the spi controller

[Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>]

On 12/19/2012 08:18 AM, Grant Likely wrote:
> On Sat, 15 Dec 2012 00:27:58 +0000, Grant Likely<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>  wrote:
>> On Tue, 11 Dec 2012 16:20:39 -0500, Murali Karicheri<m-karicheri2-l0cyMroinI0@public.gmane.org>  wrote:
>>> This adds OF support to DaVinci SPI controller to configure platform
>>> data through device bindings. Also replaces clk_enable() with
>>> of clk_prepare_enable() as well as clk_disable() with
>>> clk_disable_unprepare().
>>>
>>> Signed-off-by: Murali Karicheri<m-karicheri2-l0cyMroinI0@public.gmane.org>
>>> Reviewed-by : Grant Likely<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>> Applied, thanks.
>>
>> I did remove the OF_ALIAS_N property though. I know the COMPATIBLE one
>> uses it, but it is actually kind of redundant since it can also be
>> determined by counting the number of OF_ALIAS_* entries, and having the
>> _N one in there means extra work needs to be done to filter it out.
>>
>> Also, I had to add a #ifndef _LINUX_OF_PRIVATE_H wrapper around the
>> whole header file. This is needed for all header files to protect
>> against multiple includes.
> Ummm.... oops. I replied to the wrong email when applying another patch.
> Sorry for the noise.
>
> But I have applied your patch now. It will appear in linux-next after
> the merge window closes.
>
> g.
>
>
Grant,

Thanks for taking care of this.

Murali

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d