From: Dan Carpenter <dan.carpenter@oracle.com>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Cyril Roelandt <tipecaml-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Kuninori Morimoto
<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/5] spi: fix return value check in hspi_probe().
Date: Thu, 03 Jan 2013 16:04:55 +0000 [thread overview]
Message-ID: <20130103160455.GO7247@mwanda> (raw)
In-Reply-To: <20121222095620.83E243E07FA@localhost>
On Sat, Dec 22, 2012 at 09:56:20AM +0000, Grant Likely wrote:
> On Wed, 19 Dec 2012 19:39:14 +0300, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Wed, Dec 19, 2012 at 03:11:54PM +0000, Grant Likely wrote:
> > > On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote:
> > > >
> > > > Hi
> > > >
> > > > > According to its documentation, clk_get() returns a "valid IS_ERR() condition
> > > > > containing errno", so we should call IS_ERR() rather than a NULL check.
> > > > >
> > > > > Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
> > > >
> > > > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > >
> > > Applied, thanks.
> >
> > In another thread, we were just talking about who clk_get() can
> > return a NULL if !CONFIG_HAVE_CLK. That might change to match the
> > documentation later... Not sure.
>
> So what is the solution here? Will the dummy clk_get() be changed, or is
> there more work needed on the drivers?
>
This driver can't function without a clk. It should select that at
build time instead of testing for it at probe. Just checking for
IS_ERR() will NOT cause a NULL dereference so the patch is ok in
that respect. I'm not sure if this can be build without
CONFIG_HAVE_CLK.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Cyril Roelandt <tipecaml-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Kuninori Morimoto
<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/5] spi: fix return value check in hspi_probe().
Date: Thu, 3 Jan 2013 19:04:55 +0300 [thread overview]
Message-ID: <20130103160455.GO7247@mwanda> (raw)
In-Reply-To: <20121222095620.83E243E07FA@localhost>
On Sat, Dec 22, 2012 at 09:56:20AM +0000, Grant Likely wrote:
> On Wed, 19 Dec 2012 19:39:14 +0300, Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> > On Wed, Dec 19, 2012 at 03:11:54PM +0000, Grant Likely wrote:
> > > On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> wrote:
> > > >
> > > > Hi
> > > >
> > > > > According to its documentation, clk_get() returns a "valid IS_ERR() condition
> > > > > containing errno", so we should call IS_ERR() rather than a NULL check.
> > > > >
> > > > > Signed-off-by: Cyril Roelandt <tipecaml-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > >
> > > > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> > >
> > > Applied, thanks.
> >
> > In another thread, we were just talking about who clk_get() can
> > return a NULL if !CONFIG_HAVE_CLK. That might change to match the
> > documentation later... Not sure.
>
> So what is the solution here? Will the dummy clk_get() be changed, or is
> there more work needed on the drivers?
>
This driver can't function without a clk. It should select that at
build time instead of testing for it at probe. Just checking for
IS_ERR() will NOT cause a NULL dereference so the patch is ok in
that respect. I'm not sure if this can be build without
CONFIG_HAVE_CLK.
regards,
dan carpenter
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Cyril Roelandt <tipecaml@gmail.com>,
spi-devel-general@lists.sourceforge.net,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] spi: fix return value check in hspi_probe().
Date: Thu, 3 Jan 2013 19:04:55 +0300 [thread overview]
Message-ID: <20130103160455.GO7247@mwanda> (raw)
In-Reply-To: <20121222095620.83E243E07FA@localhost>
On Sat, Dec 22, 2012 at 09:56:20AM +0000, Grant Likely wrote:
> On Wed, 19 Dec 2012 19:39:14 +0300, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Wed, Dec 19, 2012 at 03:11:54PM +0000, Grant Likely wrote:
> > > On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote:
> > > >
> > > > Hi
> > > >
> > > > > According to its documentation, clk_get() returns a "valid IS_ERR() condition
> > > > > containing errno", so we should call IS_ERR() rather than a NULL check.
> > > > >
> > > > > Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
> > > >
> > > > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > >
> > > Applied, thanks.
> >
> > In another thread, we were just talking about who clk_get() can
> > return a NULL if !CONFIG_HAVE_CLK. That might change to match the
> > documentation later... Not sure.
>
> So what is the solution here? Will the dummy clk_get() be changed, or is
> there more work needed on the drivers?
>
This driver can't function without a clk. It should select that at
build time instead of testing for it at probe. Just checking for
IS_ERR() will NOT cause a NULL dereference so the patch is ok in
that respect. I'm not sure if this can be build without
CONFIG_HAVE_CLK.
regards,
dan carpenter
next prev parent reply other threads:[~2013-01-03 16:04 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 0:24 [PATCH 0/5] Use IS_ERR() rather than a NULL check when necessary Cyril Roelandt
2012-12-12 0:24 ` Cyril Roelandt
2012-12-12 0:24 ` [PATCH 1/5] staging: omap-thermal: fix error check in omap_thermal_expose_sensor() and in omap_therm Cyril Roelandt
2012-12-12 0:24 ` [PATCH 1/5] staging: omap-thermal: fix error check in omap_thermal_expose_sensor() and in omap_thermal_register_cpu_cooling() Cyril Roelandt
2012-12-12 6:51 ` [PATCH 1/5] staging: omap-thermal: fix error check in omap_thermal_expose_sensor() and in omap_t Eduardo Valentin
2012-12-12 6:51 ` [PATCH 1/5] staging: omap-thermal: fix error check in omap_thermal_expose_sensor() and in omap_thermal_register_cpu_cooling() Eduardo Valentin
2012-12-12 0:24 ` [PATCH 2/5] media: davinci: fix return value check in vpbe_display_reqbufs() Cyril Roelandt
2012-12-12 0:24 ` Cyril Roelandt
2012-12-12 5:10 ` Prabhakar Lad
2012-12-12 5:22 ` Prabhakar Lad
2012-12-12 0:24 ` [PATCH 3/5] c2port: fix return value check in duramar2150_c2port_init() Cyril Roelandt
2012-12-12 0:24 ` Cyril Roelandt
2012-12-12 0:24 ` [PATCH 4/5] net: sfc: fix return value check in efx_ptp_probe_channel() Cyril Roelandt
2012-12-12 0:24 ` Cyril Roelandt
2012-12-12 5:15 ` David Miller
2012-12-12 5:15 ` David Miller
2012-12-21 3:09 ` Ben Hutchings
2012-12-21 3:09 ` Ben Hutchings
[not found] ` <1355271894-5284-1-git-send-email-tipecaml-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-12 0:24 ` [PATCH 5/5] spi: fix return value check in hspi_probe() Cyril Roelandt
2012-12-12 0:24 ` Cyril Roelandt
2012-12-12 0:24 ` Cyril Roelandt
[not found] ` <1355271894-5284-6-git-send-email-tipecaml-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-12 0:36 ` Kuninori Morimoto
2012-12-12 0:36 ` Kuninori Morimoto
2012-12-12 0:36 ` Kuninori Morimoto
[not found] ` <87txrsqf7f.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2012-12-19 15:11 ` Grant Likely
2012-12-19 15:11 ` Grant Likely
2012-12-19 15:11 ` Grant Likely
2012-12-19 16:39 ` Dan Carpenter
2012-12-19 16:39 ` Dan Carpenter
2012-12-19 16:39 ` Dan Carpenter
2012-12-22 9:56 ` Grant Likely
2012-12-22 9:56 ` Grant Likely
2012-12-22 9:56 ` Grant Likely
2013-01-03 16:04 ` Dan Carpenter [this message]
2013-01-03 16:04 ` Dan Carpenter
2013-01-03 16:04 ` Dan Carpenter
2013-01-11 15:02 ` Grant Likely
2013-01-11 15:02 ` Grant Likely
2013-01-11 15:02 ` Grant Likely
2013-01-12 0:01 ` Dan Carpenter
2013-01-12 0:01 ` Dan Carpenter
2013-01-12 0:01 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103160455.GO7247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=tipecaml-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.