From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
gregkh@linuxfoundation.org, rui.zhang@intel.com,
durgadoss.r@intel.com, rjw@sisk.pl, devel@driverdev.osuosl.org
Subject: Re: [PATCH 1/5] staging: omap-thermal: fix error check in omap_thermal_expose_sensor() and in omap_t
Date: Wed, 12 Dec 2012 06:51:55 +0000 [thread overview]
Message-ID: <50C8298B.50503@ti.com> (raw)
In-Reply-To: <1355271894-5284-2-git-send-email-tipecaml@gmail.com>
On 12-12-2012 02:24, Cyril Roelandt wrote:
>
> The omap_bandgap_get_sensor_data() function returns ERR_PTR(), so we need to use
> IS_ERR() rather than a NULL check.
>
> Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
> drivers/staging/omap-thermal/omap-thermal-common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/omap-thermal/omap-thermal-common.c b/drivers/staging/omap-thermal/omap-thermal-common.c
> index 61f1070..79a55aa 100644
> --- a/drivers/staging/omap-thermal/omap-thermal-common.c
> +++ b/drivers/staging/omap-thermal/omap-thermal-common.c
> @@ -260,7 +260,7 @@ int omap_thermal_expose_sensor(struct omap_bandgap *bg_ptr, int id,
>
> data = omap_bandgap_get_sensor_data(bg_ptr, id);
>
> - if (!data)
> + if (IS_ERR(data))
> data = omap_thermal_build_data(bg_ptr, id);
>
> if (!data)
> @@ -309,7 +309,7 @@ int omap_thermal_register_cpu_cooling(struct omap_bandgap *bg_ptr, int id)
> struct omap_thermal_data *data;
>
> data = omap_bandgap_get_sensor_data(bg_ptr, id);
> - if (!data)
> + if (IS_ERR(data))
> data = omap_thermal_build_data(bg_ptr, id);
>
> if (!data)
>
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <rui.zhang@intel.com>,
<durgadoss.r@intel.com>, <rjw@sisk.pl>,
<devel@driverdev.osuosl.org>
Subject: Re: [PATCH 1/5] staging: omap-thermal: fix error check in omap_thermal_expose_sensor() and in omap_thermal_register_cpu_cooling().
Date: Wed, 12 Dec 2012 08:51:55 +0200 [thread overview]
Message-ID: <50C8298B.50503@ti.com> (raw)
In-Reply-To: <1355271894-5284-2-git-send-email-tipecaml@gmail.com>
On 12-12-2012 02:24, Cyril Roelandt wrote:
>
> The omap_bandgap_get_sensor_data() function returns ERR_PTR(), so we need to use
> IS_ERR() rather than a NULL check.
>
> Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
> drivers/staging/omap-thermal/omap-thermal-common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/omap-thermal/omap-thermal-common.c b/drivers/staging/omap-thermal/omap-thermal-common.c
> index 61f1070..79a55aa 100644
> --- a/drivers/staging/omap-thermal/omap-thermal-common.c
> +++ b/drivers/staging/omap-thermal/omap-thermal-common.c
> @@ -260,7 +260,7 @@ int omap_thermal_expose_sensor(struct omap_bandgap *bg_ptr, int id,
>
> data = omap_bandgap_get_sensor_data(bg_ptr, id);
>
> - if (!data)
> + if (IS_ERR(data))
> data = omap_thermal_build_data(bg_ptr, id);
>
> if (!data)
> @@ -309,7 +309,7 @@ int omap_thermal_register_cpu_cooling(struct omap_bandgap *bg_ptr, int id)
> struct omap_thermal_data *data;
>
> data = omap_bandgap_get_sensor_data(bg_ptr, id);
> - if (!data)
> + if (IS_ERR(data))
> data = omap_thermal_build_data(bg_ptr, id);
>
> if (!data)
>
next prev parent reply other threads:[~2012-12-12 6:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 0:24 [PATCH 0/5] Use IS_ERR() rather than a NULL check when necessary Cyril Roelandt
2012-12-12 0:24 ` Cyril Roelandt
2012-12-12 0:24 ` [PATCH 1/5] staging: omap-thermal: fix error check in omap_thermal_expose_sensor() and in omap_therm Cyril Roelandt
2012-12-12 0:24 ` [PATCH 1/5] staging: omap-thermal: fix error check in omap_thermal_expose_sensor() and in omap_thermal_register_cpu_cooling() Cyril Roelandt
2012-12-12 6:51 ` Eduardo Valentin [this message]
2012-12-12 6:51 ` Eduardo Valentin
2012-12-12 0:24 ` [PATCH 2/5] media: davinci: fix return value check in vpbe_display_reqbufs() Cyril Roelandt
2012-12-12 0:24 ` Cyril Roelandt
2012-12-12 5:10 ` Prabhakar Lad
2012-12-12 5:22 ` Prabhakar Lad
2012-12-12 0:24 ` [PATCH 3/5] c2port: fix return value check in duramar2150_c2port_init() Cyril Roelandt
2012-12-12 0:24 ` Cyril Roelandt
2012-12-12 0:24 ` [PATCH 4/5] net: sfc: fix return value check in efx_ptp_probe_channel() Cyril Roelandt
2012-12-12 0:24 ` Cyril Roelandt
2012-12-12 5:15 ` David Miller
2012-12-12 5:15 ` David Miller
2012-12-21 3:09 ` Ben Hutchings
2012-12-21 3:09 ` Ben Hutchings
[not found] ` <1355271894-5284-1-git-send-email-tipecaml-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-12 0:24 ` [PATCH 5/5] spi: fix return value check in hspi_probe() Cyril Roelandt
2012-12-12 0:24 ` Cyril Roelandt
2012-12-12 0:24 ` Cyril Roelandt
[not found] ` <1355271894-5284-6-git-send-email-tipecaml-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-12 0:36 ` Kuninori Morimoto
2012-12-12 0:36 ` Kuninori Morimoto
2012-12-12 0:36 ` Kuninori Morimoto
[not found] ` <87txrsqf7f.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2012-12-19 15:11 ` Grant Likely
2012-12-19 15:11 ` Grant Likely
2012-12-19 15:11 ` Grant Likely
2012-12-19 16:39 ` Dan Carpenter
2012-12-19 16:39 ` Dan Carpenter
2012-12-19 16:39 ` Dan Carpenter
2012-12-22 9:56 ` Grant Likely
2012-12-22 9:56 ` Grant Likely
2012-12-22 9:56 ` Grant Likely
2013-01-03 16:04 ` Dan Carpenter
2013-01-03 16:04 ` Dan Carpenter
2013-01-03 16:04 ` Dan Carpenter
2013-01-11 15:02 ` Grant Likely
2013-01-11 15:02 ` Grant Likely
2013-01-11 15:02 ` Grant Likely
2013-01-12 0:01 ` Dan Carpenter
2013-01-12 0:01 ` Dan Carpenter
2013-01-12 0:01 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C8298B.50503@ti.com \
--to=eduardo.valentin@ti.com \
--cc=devel@driverdev.osuosl.org \
--cc=durgadoss.r@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.