[meta-fsl-arm][PATCH 1/2] barebox: Add defconfig only for imx53qsb

[meta-fsl-arm][PATCH 1/2] barebox: Add defconfig only for imx53qsb

[Andrei Gherzan]

Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
---
 recipes-bsp/barebox/barebox_2012.02.0.bb |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/recipes-bsp/barebox/barebox_2012.02.0.bb b/recipes-bsp/barebox/barebox_2012.02.0.bb
index 3fad26f..0ba260f 100644
--- a/recipes-bsp/barebox/barebox_2012.02.0.bb
+++ b/recipes-bsp/barebox/barebox_2012.02.0.bb
@@ -1,11 +1,12 @@
 require barebox.inc
 
-PR = "r1"
+PR = "r2"
 
 SRC_URI = "http://barebox.org/download/${PN}-${PV}.tar.bz2 \
-	file://defconfig \
 	"
 
+SRC_URI_append_imx53qsb = " file://defconfig"
+
 SRC_URI[md5sum] = "ce876bb3ba1f60b5ee08f13dc648f702"
 SRC_URI[sha256sum] = "5cd1fcbd6596d3fad1b25a79706a9a76508e8c0d2a85e79ef2d91754caa6667b"
 
-- 
1.7.9.5

[meta-fsl-arm][PATCH 2/2] xorg-driver-video: Install vivante_gal.h

[Andrei Gherzan]

Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
---
 .../xf86-video-imxfb-vivante_12.09.01.bb           |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_12.09.01.bb b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_12.09.01.bb
index 798e450..e35080f 100644
--- a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_12.09.01.bb
+++ b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_12.09.01.bb
@@ -3,7 +3,7 @@
 
 require recipes-graphics/xorg-driver/xorg-driver-video.inc
 
-PR = "${INC_PR}.1"
+PR = "${INC_PR}.2"
 
 DEPENDS += "virtual/libx11 virtual/libgal-x11 gpu-viv-bin-mx6q"
 
@@ -24,6 +24,7 @@ S = "${WORKDIR}/xserver-xorg-video-imx-viv-${PV}"
 do_install_append () {
 	install -d ${D}${includedir}
 	cp -axr ${S}/src/vivante_gal/vivante_priv.h ${D}${includedir}
+	cp -axr ${S}/src/vivante_gal/vivante_gal.h ${D}${includedir}
 	find ${D}${includedir} -type f -exec chmod 660 {} \;
 }
 
-- 
1.7.9.5

Re: [meta-fsl-arm][PATCH 2/2] xorg-driver-video: Install vivante_gal.h

[Otavio Salvador]

On Fri, Jan 4, 2013 at 10:49 AM, Andrei Gherzan
<andrei.gherzan@windriver.com> wrote:
> Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>

Applied to master.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [meta-fsl-arm][PATCH 1/2] barebox: Add defconfig only for imx53qsb

[Eric Bénard]

Hi Andrei,

Le Fri, 4 Jan 2013 14:49:06 +0200,
Andrei Gherzan <andrei.gherzan@windriver.com> a écrit :

> Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
> ---
>  recipes-bsp/barebox/barebox_2012.02.0.bb |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes-bsp/barebox/barebox_2012.02.0.bb b/recipes-bsp/barebox/barebox_2012.02.0.bb
> index 3fad26f..0ba260f 100644
> --- a/recipes-bsp/barebox/barebox_2012.02.0.bb
> +++ b/recipes-bsp/barebox/barebox_2012.02.0.bb
> @@ -1,11 +1,12 @@
>  require barebox.inc
>  
> -PR = "r1"
> +PR = "r2"
>  
>  SRC_URI = "http://barebox.org/download/${PN}-${PV}.tar.bz2 \
> -	file://defconfig \
>  	"
>  
> +SRC_URI_append_imx53qsb = " file://defconfig"
> +
>  SRC_URI[md5sum] = "ce876bb3ba1f60b5ee08f13dc648f702"
>  SRC_URI[sha256sum] = "5cd1fcbd6596d3fad1b25a79706a9a76508e8c0d2a85e79ef2d91754caa6667b"
>  
I would prefer that you add a COMPATIBLE_MACHINE = "imx53qsb" as the
defconfig is generic for all supported boards and not specific to a
board.

Thanks
Eric

Re: [meta-fsl-arm][PATCH 1/2] barebox: Add defconfig only for imx53qsb

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]

On Fri, Jan 4, 2013 at 3:48 PM, Eric Bénard <eric@eukrea.com> wrote:

> Hi Andrei,
>
> Le Fri, 4 Jan 2013 14:49:06 +0200,
> Andrei Gherzan <andrei.gherzan@windriver.com> a écrit :
>
> > Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
> > ---
> >  recipes-bsp/barebox/barebox_2012.02.0.bb |    5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/recipes-bsp/barebox/barebox_2012.02.0.bbb/recipes-bsp/barebox/
> barebox_2012.02.0.bb
> > index 3fad26f..0ba260f 100644
> > --- a/recipes-bsp/barebox/barebox_2012.02.0.bb
> > +++ b/recipes-bsp/barebox/barebox_2012.02.0.bb
> > @@ -1,11 +1,12 @@
> >  require barebox.inc
> >
> > -PR = "r1"
> > +PR = "r2"
> >
> >  SRC_URI = "http://barebox.org/download/${PN}-${PV}.tar.bz2 \
> > -     file://defconfig \
> >       "
> >
> > +SRC_URI_append_imx53qsb = " file://defconfig"
> > +
> >  SRC_URI[md5sum] = "ce876bb3ba1f60b5ee08f13dc648f702"
> >  SRC_URI[sha256sum] =
> "5cd1fcbd6596d3fad1b25a79706a9a76508e8c0d2a85e79ef2d91754caa6667b"
> >
> I would prefer that you add a COMPATIBLE_MACHINE = "imx53qsb" as the
> defconfig is generic for all supported boards and not specific to a
> board.
>

That was my first patch but i dropped it because defconfig is in imx53qsb
directory. So, the best way would be to move that out of machine directory
and add compatible machine, right?

ag

[-- Attachment #2: Type: text/html, Size: 2458 bytes --]

Re: [meta-fsl-arm][PATCH 1/2] barebox: Add defconfig only for imx53qsb

[Eric Bénard]

Le Fri, 4 Jan 2013 15:58:36 +0200,
Andrei Gherzan <andrei@gherzan.ro> a écrit :
> That was my first patch but i dropped it because defconfig is in imx53qsb
> directory. So, the best way would be to move that out of machine directory
> and add compatible machine, right?
> 
no, this defconfig is specific to imx53qsb so having it in an imx53qsb
directory is right.
The current barebox recipe only support imx53qsb so setting
COMPATIBLE_MACHINE = "imx53qsb" is right in the present case.
When I'll have a little bit of time I'll upgrade barebox support and
add other boards and their defconfig will go in a directory with each
board's name.

Eric

Re: [meta-fsl-arm][PATCH 1/2] barebox: Add defconfig only for imx53qsb

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

On Fri, Jan 4, 2013 at 5:47 PM, Eric Bénard <eric@eukrea.com> wrote:

> Le Fri, 4 Jan 2013 15:58:36 +0200,
> Andrei Gherzan <andrei@gherzan.ro> a écrit :
> > That was my first patch but i dropped it because defconfig is in imx53qsb
> > directory. So, the best way would be to move that out of machine
> directory
> > and add compatible machine, right?
> >
> no, this defconfig is specific to imx53qsb so having it in an imx53qsb
> directory is right.
>

You said above:
"defconfig is generic for all supported boards and not specific to a
board. "

A little confused...

ag

[-- Attachment #2: Type: text/html, Size: 1314 bytes --]

Re: [meta-fsl-arm][PATCH 1/2] barebox: Add defconfig only for imx53qsb

[Eric Bénard]

Le Fri, 4 Jan 2013 14:48:22 +0100,
Eric Bénard <eric@eukrea.com> a écrit :
> I would prefer that you add a COMPATIBLE_MACHINE = "imx53qsb" as the
> defconfig is generic for all supported boards and not specific to a
> board.
> 
sorry, I meant _providing a_ defconfig is generic for all supported
boards (so belongs to the main SRC_URI) and not specific to a board
(each defconfig is specific to one board which explains why it is in
a directory with the board's name).

I hope that's more clear now ;-)

Eric

Re: [meta-fsl-arm][PATCH 1/2] barebox: Add defconfig only for imx53qsb

[Otavio Salvador]

On Fri, Jan 4, 2013 at 2:20 PM, Eric Bénard <eric@eukrea.com> wrote:
> Le Fri, 4 Jan 2013 14:48:22 +0100,
> Eric Bénard <eric@eukrea.com> a écrit :
>> I would prefer that you add a COMPATIBLE_MACHINE = "imx53qsb" as the
>> defconfig is generic for all supported boards and not specific to a
>> board.
>>
> sorry, I meant _providing a_ defconfig is generic for all supported
> boards (so belongs to the main SRC_URI) and not specific to a board
> (each defconfig is specific to one board which explains why it is in
> a directory with the board's name).
>
> I hope that's more clear now ;-)

Andrei, I agree with Eric here, please fix and send a v2.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br