All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Eric Dumazet <erdnetdev@gmail.com>
Cc: Mel Gorman <mgorman@suse.de>,
	linux-mm@kvack.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Rik van Riel <riel@redhat.com>,
	Minchan Kim <minchan@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: ppoll() stuck on POLLIN while TCP peer is sending
Date: Wed, 9 Jan 2013 08:42:47 +0000	[thread overview]
Message-ID: <20130109084247.GA6545@dcvr.yhbt.net> (raw)
In-Reply-To: <20130109035511.GA6857@dcvr.yhbt.net>

Eric Wong <normalperson@yhbt.net> wrote:
> Eric Dumazet <erdnetdev@gmail.com> wrote:
> > On Tue, 2013-01-08 at 18:32 -0800, Eric Dumazet wrote:
> > > Hmm, it seems sk_filter() can return -ENOMEM because skb has the
> > > pfmemalloc() set.
> > 
> > > 
> > > One TCP socket keeps retransmitting an SKB via loopback, and TCP stack 
> > > drops the packet again and again.
> > 
> > sock_init_data() sets sk->sk_allocation to GFP_KERNEL
> > 
> > Shouldnt it use (GFP_KERNEL | __GFP_NOMEMALLOC) instead ?
> 
> Thanks, things are running good after ~35 minutes so far.
> Will report back if things break (hopefully I don't run out
> of laptop battery power :x).

Oops, I had to restart my test :x.  However, I was able to reproduce the
issue very quickly again with your patch.  I've double-checked I'm
booting into the correct kernel, but I do have more load on this
laptop host now, so maybe that made it happen more quickly...

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Eric Wong <normalperson@yhbt.net>
To: Eric Dumazet <erdnetdev@gmail.com>
Cc: Mel Gorman <mgorman@suse.de>,
	linux-mm@kvack.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Rik van Riel <riel@redhat.com>,
	Minchan Kim <minchan@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: ppoll() stuck on POLLIN while TCP peer is sending
Date: Wed, 9 Jan 2013 08:42:47 +0000	[thread overview]
Message-ID: <20130109084247.GA6545@dcvr.yhbt.net> (raw)
In-Reply-To: <20130109035511.GA6857@dcvr.yhbt.net>

Eric Wong <normalperson@yhbt.net> wrote:
> Eric Dumazet <erdnetdev@gmail.com> wrote:
> > On Tue, 2013-01-08 at 18:32 -0800, Eric Dumazet wrote:
> > > Hmm, it seems sk_filter() can return -ENOMEM because skb has the
> > > pfmemalloc() set.
> > 
> > > 
> > > One TCP socket keeps retransmitting an SKB via loopback, and TCP stack 
> > > drops the packet again and again.
> > 
> > sock_init_data() sets sk->sk_allocation to GFP_KERNEL
> > 
> > Shouldnt it use (GFP_KERNEL | __GFP_NOMEMALLOC) instead ?
> 
> Thanks, things are running good after ~35 minutes so far.
> Will report back if things break (hopefully I don't run out
> of laptop battery power :x).

Oops, I had to restart my test :x.  However, I was able to reproduce the
issue very quickly again with your patch.  I've double-checked I'm
booting into the correct kernel, but I do have more load on this
laptop host now, so maybe that made it happen more quickly...

  reply	other threads:[~2013-01-09  8:42 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-28  1:45 ppoll() stuck on POLLIN while TCP peer is sending Eric Wong
2012-12-28  7:06 ` Eric Wong
2012-12-29 11:34   ` Eric Wong
2012-12-31 13:21 ` [PATCH] poll: prevent missed events if _qproc is NULL Eric Wong
2012-12-31 23:24   ` Eric Wong
2013-01-01 16:58     ` Junchang(Jason) Wang
2013-01-01 18:42   ` Eric Dumazet
2013-01-01 21:00     ` Eric Wong
2013-01-01 21:17       ` Eric Wong
2013-01-01 22:53         ` Linus Torvalds
2013-01-01 23:21           ` Junchang(Jason) Wang
2013-01-01 23:56           ` [PATCH] epoll: prevent missed events on EPOLL_CTL_MOD Eric Wong
2013-01-02 17:45             ` Eric Dumazet
2013-01-02 18:40               ` Eric Wong
2013-01-02 19:03                 ` Eric Dumazet
2013-01-02 19:32                   ` Eric Wong
2013-01-02 22:08                     ` Eric Dumazet
2013-01-02 21:16             ` Eric Wong
2013-01-02 20:08 ` ppoll() stuck on POLLIN while TCP peer is sending Eric Wong
2013-01-02 20:08   ` Eric Wong
2013-01-02 20:47   ` Eric Wong
2013-01-02 20:47     ` Eric Wong
2013-01-03 13:41     ` Eric Dumazet
2013-01-03 13:41       ` Eric Dumazet
2013-01-03 18:32       ` Eric Wong
2013-01-03 18:32         ` Eric Wong
2013-01-03 23:45         ` Eric Wong
2013-01-03 23:45           ` Eric Wong
2013-01-04  0:26           ` Eric Wong
2013-01-04  0:26             ` Eric Wong
2013-01-04  3:52             ` Eric Wong
2013-01-04  3:52               ` Eric Wong
2013-01-04 16:01   ` Mel Gorman
2013-01-04 16:01     ` Mel Gorman
2013-01-04 17:15     ` Eric Dumazet
2013-01-04 17:15       ` Eric Dumazet
2013-01-04 17:59     ` Eric Wong
2013-01-04 17:59       ` Eric Wong
2013-01-05  1:07     ` Eric Wong
2013-01-05  1:07       ` Eric Wong
2013-01-06 12:07     ` Eric Wong
2013-01-06 12:07       ` Eric Wong
2013-01-07 12:25       ` Mel Gorman
2013-01-07 12:25         ` Mel Gorman
2013-01-07 22:38         ` Eric Dumazet
2013-01-07 22:38           ` Eric Dumazet
2013-01-08  0:21           ` Eric Wong
2013-01-08  0:21             ` Eric Wong
2013-01-07 22:38         ` Eric Wong
2013-01-07 22:38           ` Eric Wong
2013-01-08 20:14           ` Eric Wong
2013-01-08 20:14             ` Eric Wong
2013-01-08 22:43           ` Mel Gorman
2013-01-08 22:43             ` Mel Gorman
2013-01-08 23:23             ` Eric Wong
2013-01-08 23:23               ` Eric Wong
2013-01-09  2:14               ` Eric Dumazet
2013-01-09  2:14                 ` Eric Dumazet
2013-01-09  2:32                 ` Eric Dumazet
2013-01-09  2:32                   ` Eric Dumazet
2013-01-09  2:54                   ` Eric Dumazet
2013-01-09  2:54                     ` Eric Dumazet
2013-01-09  3:55                     ` Eric Wong
2013-01-09  3:55                       ` Eric Wong
2013-01-09  8:42                       ` Eric Wong [this message]
2013-01-09  8:42                         ` Eric Wong
2013-01-09  8:51                         ` Eric Wong
2013-01-09  8:51                           ` Eric Wong
2013-01-09 13:42                   ` Mel Gorman
2013-01-09 13:42                     ` Mel Gorman
2013-01-09 13:37               ` Mel Gorman
2013-01-09 13:37                 ` Mel Gorman
2013-01-09 13:50                 ` Mel Gorman
2013-01-09 13:50                   ` Mel Gorman
2013-01-10  9:25                 ` Eric Wong
2013-01-10  9:25                   ` Eric Wong
2013-01-10 19:42                   ` Mel Gorman
2013-01-10 19:42                     ` Mel Gorman
2013-01-10 20:03                     ` Eric Wong
2013-01-10 20:03                       ` Eric Wong
2013-01-10 20:58                     ` Eric Dumazet
2013-01-10 20:58                       ` Eric Dumazet
2013-01-11  0:51                     ` Eric Wong
2013-01-11  0:51                       ` Eric Wong
2013-01-11  9:30                       ` Mel Gorman
2013-01-11  9:30                         ` Mel Gorman
2013-01-09 21:29             ` Eric Wong
2013-01-09 21:29               ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130109084247.GA6545@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=akpm@linux-foundation.org \
    --cc=erdnetdev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=riel@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.