From: Andrew Morton <akpm@linux-foundation.org>
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: jiang.liu@huawei.com, wujianguo@huawei.com, hpa@zytor.com,
wency@cn.fujitsu.com, laijs@cn.fujitsu.com,
linfeng@cn.fujitsu.com, yinghai@kernel.org,
isimatu.yasuaki@jp.fujitsu.com, rob@landley.net,
kosaki.motohiro@jp.fujitsu.com, minchan.kim@gmail.com,
mgorman@suse.de, rientjes@google.com, guz.fnst@cn.fujitsu.com,
rusty@rustcorp.com.au, lliubbo@gmail.com,
jaegeuk.hanse@gmail.com, tony.luck@intel.com,
glommer@parallels.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v5 2/5] page_alloc: add movable_memmap kernel parameter
Date: Mon, 14 Jan 2013 14:35:12 -0800 [thread overview]
Message-ID: <20130114143512.b961211e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1358154925-21537-3-git-send-email-tangchen@cn.fujitsu.com>
On Mon, 14 Jan 2013 17:15:22 +0800
Tang Chen <tangchen@cn.fujitsu.com> wrote:
> This patch adds functions to parse movablecore_map boot option. Since the
> option could be specified more then once, all the maps will be stored in
> the global variable movablecore_map.map array.
>
> And also, we keep the array in monotonic increasing order by start_pfn.
> And merge all overlapped ranges.
>
> ...
>
> +#define MOVABLECORE_MAP_MAX MAX_NUMNODES
> +struct movablecore_entry {
> + unsigned long start_pfn; /* start pfn of memory segment */
> + unsigned long end_pfn; /* end pfn of memory segment */
It is important to tell readers whether an "end" is inclusive or
exclusive. ie: does it point at the last byte, or one beyond it?
By reading the code I see it is exclusive, so...
--- a/include/linux/mm.h~page_alloc-add-movable_memmap-kernel-parameter-fix
+++ a/include/linux/mm.h
@@ -1362,7 +1362,7 @@ extern void sparse_memory_present_with_a
#define MOVABLECORE_MAP_MAX MAX_NUMNODES
struct movablecore_entry {
unsigned long start_pfn; /* start pfn of memory segment */
- unsigned long end_pfn; /* end pfn of memory segment */
+ unsigned long end_pfn; /* end pfn of memory segment (exclusive) */
};
struct movablecore_map {
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: jiang.liu@huawei.com, wujianguo@huawei.com, hpa@zytor.com,
wency@cn.fujitsu.com, laijs@cn.fujitsu.com,
linfeng@cn.fujitsu.com, yinghai@kernel.org,
isimatu.yasuaki@jp.fujitsu.com, rob@landley.net,
kosaki.motohiro@jp.fujitsu.com, minchan.kim@gmail.com,
mgorman@suse.de, rientjes@google.com, guz.fnst@cn.fujitsu.com,
rusty@rustcorp.com.au, lliubbo@gmail.com,
jaegeuk.hanse@gmail.com, tony.luck@intel.com,
glommer@parallels.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v5 2/5] page_alloc: add movable_memmap kernel parameter
Date: Mon, 14 Jan 2013 14:35:12 -0800 [thread overview]
Message-ID: <20130114143512.b961211e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1358154925-21537-3-git-send-email-tangchen@cn.fujitsu.com>
On Mon, 14 Jan 2013 17:15:22 +0800
Tang Chen <tangchen@cn.fujitsu.com> wrote:
> This patch adds functions to parse movablecore_map boot option. Since the
> option could be specified more then once, all the maps will be stored in
> the global variable movablecore_map.map array.
>
> And also, we keep the array in monotonic increasing order by start_pfn.
> And merge all overlapped ranges.
>
> ...
>
> +#define MOVABLECORE_MAP_MAX MAX_NUMNODES
> +struct movablecore_entry {
> + unsigned long start_pfn; /* start pfn of memory segment */
> + unsigned long end_pfn; /* end pfn of memory segment */
It is important to tell readers whether an "end" is inclusive or
exclusive. ie: does it point at the last byte, or one beyond it?
By reading the code I see it is exclusive, so...
--- a/include/linux/mm.h~page_alloc-add-movable_memmap-kernel-parameter-fix
+++ a/include/linux/mm.h
@@ -1362,7 +1362,7 @@ extern void sparse_memory_present_with_a
#define MOVABLECORE_MAP_MAX MAX_NUMNODES
struct movablecore_entry {
unsigned long start_pfn; /* start pfn of memory segment */
- unsigned long end_pfn; /* end pfn of memory segment */
+ unsigned long end_pfn; /* end pfn of memory segment (exclusive) */
};
struct movablecore_map {
next prev parent reply other threads:[~2013-01-14 22:35 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 9:15 [PATCH v5 0/5] Add movablecore_map boot option Tang Chen
2013-01-14 9:15 ` Tang Chen
2013-01-14 9:15 ` [PATCH v5 1/5] x86: get pg_data_t's memory from other node Tang Chen
2013-01-14 9:15 ` Tang Chen
2013-01-14 9:15 ` [PATCH v5 2/5] page_alloc: add movable_memmap kernel parameter Tang Chen
2013-01-14 9:15 ` Tang Chen
2013-01-14 22:35 ` Andrew Morton [this message]
2013-01-14 22:35 ` Andrew Morton
2013-01-14 9:15 ` [PATCH v5 3/5] page_alloc: Introduce zone_movable_limit[] to keep movable limit for nodes Tang Chen
2013-01-14 9:15 ` Tang Chen
2013-01-14 9:15 ` [PATCH v5 4/5] page_alloc: Make movablecore_map has higher priority Tang Chen
2013-01-14 9:15 ` Tang Chen
2013-01-14 9:15 ` [PATCH v5 5/5] page_alloc: Bootmem limit with movablecore_map Tang Chen
2013-01-14 9:15 ` Tang Chen
2013-01-14 17:31 ` [PATCH v5 0/5] Add movablecore_map boot option H. Peter Anvin
2013-01-14 17:31 ` H. Peter Anvin
2013-01-14 22:34 ` Andrew Morton
2013-01-14 22:34 ` Andrew Morton
2013-01-14 22:41 ` Luck, Tony
2013-01-14 22:41 ` Luck, Tony
2013-01-14 22:46 ` Andrew Morton
2013-01-16 6:25 ` Yasuaki Ishimatsu
2013-01-16 6:25 ` Yasuaki Ishimatsu
2013-01-16 21:29 ` Andrew Morton
2013-01-16 21:29 ` Andrew Morton
2013-01-16 22:01 ` KOSAKI Motohiro
2013-01-16 22:01 ` KOSAKI Motohiro
2013-01-16 23:00 ` H. Peter Anvin
2013-01-16 23:00 ` H. Peter Anvin
2013-01-17 20:27 ` KOSAKI Motohiro
2013-01-17 20:27 ` KOSAKI Motohiro
2013-01-16 22:52 ` H. Peter Anvin
2013-01-16 22:52 ` H. Peter Anvin
2013-01-17 1:49 ` Tang Chen
2013-01-17 1:49 ` Tang Chen
2013-01-17 20:20 ` KOSAKI Motohiro
2013-01-17 20:20 ` KOSAKI Motohiro
2013-01-17 5:08 ` Yasuaki Ishimatsu
2013-01-17 5:08 ` Yasuaki Ishimatsu
2013-01-17 6:03 ` H. Peter Anvin
2013-01-17 6:03 ` H. Peter Anvin
2013-01-17 16:30 ` Luck, Tony
2013-01-17 16:30 ` Luck, Tony
2013-01-17 20:28 ` KOSAKI Motohiro
2013-01-17 20:28 ` KOSAKI Motohiro
2013-01-18 6:05 ` Yasuaki Ishimatsu
2013-01-18 6:05 ` Yasuaki Ishimatsu
2013-01-18 6:25 ` H. Peter Anvin
2013-01-18 6:25 ` H. Peter Anvin
2013-01-18 7:38 ` Yasuaki Ishimatsu
2013-01-18 7:38 ` Yasuaki Ishimatsu
2013-01-18 8:08 ` Tang Chen
2013-01-18 8:08 ` Tang Chen
2013-01-18 9:23 ` li guang
2013-01-18 9:23 ` li guang
2013-01-18 18:29 ` Luck, Tony
2013-01-18 18:29 ` Luck, Tony
2013-01-19 1:06 ` Jiang Liu
2013-01-19 7:52 ` Chen Gong
2013-01-21 7:36 ` Yasuaki Ishimatsu
2013-01-15 1:23 ` Yasuaki Ishimatsu
2013-01-15 1:23 ` Yasuaki Ishimatsu
2013-01-15 3:44 ` H. Peter Anvin
2013-01-15 3:44 ` H. Peter Anvin
2013-01-15 4:04 ` Luck, Tony
2013-01-15 4:04 ` Luck, Tony
2013-01-15 0:05 ` Toshi Kani
2013-01-15 0:05 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114143512.b961211e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=glommer@parallels.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jaegeuk.hanse@gmail.com \
--cc=jiang.liu@huawei.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linfeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
--cc=rientjes@google.com \
--cc=rob@landley.net \
--cc=rusty@rustcorp.com.au \
--cc=tangchen@cn.fujitsu.com \
--cc=tony.luck@intel.com \
--cc=wency@cn.fujitsu.com \
--cc=wujianguo@huawei.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.