From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4 v3] serial: vt8500: UART uses gated clock rather than 24Mhz reference
Date: Thu, 17 Jan 2013 17:25:50 -0800 [thread overview]
Message-ID: <20130118012550.GA28958@kroah.com> (raw)
In-Reply-To: <1358363143-7154-4-git-send-email-linux@prisktech.co.nz>
On Thu, Jan 17, 2013 at 08:05:42AM +1300, Tony Prisk wrote:
> UART modules on Wondermedia SoCs are connected via a gated clock
> source, rather than directly to the 24Mhz reference clock. While
> uboot enables UART0 for debugging, other UART ports are unavailable
> until the clock is enabled.
>
> This patch checks that a valid clock is actually passed from devicetree,
> enables the clock in probe. This change removes the fallback when a
> clock was not specified as it doesn't apply any longer (and would only
> work if the UART clock was already enabled).
>
> DTSI files are updated for VT8500, WM8505 and WM8650.
>
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> ---
> arch/arm/boot/dts/vt8500.dtsi | 40 +++++++++++++++++++++---
> arch/arm/boot/dts/wm8505.dtsi | 60 ++++++++++++++++++++++++++++++++----
> arch/arm/boot/dts/wm8650.dtsi | 20 ++++++++++--
> drivers/tty/serial/vt8500_serial.c | 34 +++++++++++---------
> 4 files changed, 127 insertions(+), 27 deletions(-)
PLEASE always use checkpatch.pl on your patches before sending them, so
people don't have to write emails saying "why didn't you fix the
checkpatch.pl errors in your patch" much like this one.
Sorry, not applied.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Tony Prisk <linux@prisktech.co.nz>
Cc: vt8500-wm8505-linux-kernel@googlegroups.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk
Subject: Re: [PATCH 3/4 v3] serial: vt8500: UART uses gated clock rather than 24Mhz reference
Date: Thu, 17 Jan 2013 17:25:50 -0800 [thread overview]
Message-ID: <20130118012550.GA28958@kroah.com> (raw)
In-Reply-To: <1358363143-7154-4-git-send-email-linux@prisktech.co.nz>
On Thu, Jan 17, 2013 at 08:05:42AM +1300, Tony Prisk wrote:
> UART modules on Wondermedia SoCs are connected via a gated clock
> source, rather than directly to the 24Mhz reference clock. While
> uboot enables UART0 for debugging, other UART ports are unavailable
> until the clock is enabled.
>
> This patch checks that a valid clock is actually passed from devicetree,
> enables the clock in probe. This change removes the fallback when a
> clock was not specified as it doesn't apply any longer (and would only
> work if the UART clock was already enabled).
>
> DTSI files are updated for VT8500, WM8505 and WM8650.
>
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> ---
> arch/arm/boot/dts/vt8500.dtsi | 40 +++++++++++++++++++++---
> arch/arm/boot/dts/wm8505.dtsi | 60 ++++++++++++++++++++++++++++++++----
> arch/arm/boot/dts/wm8650.dtsi | 20 ++++++++++--
> drivers/tty/serial/vt8500_serial.c | 34 +++++++++++---------
> 4 files changed, 127 insertions(+), 27 deletions(-)
PLEASE always use checkpatch.pl on your patches before sending them, so
people don't have to write emails saying "why didn't you fix the
checkpatch.pl errors in your patch" much like this one.
Sorry, not applied.
greg k-h
next prev parent reply other threads:[~2013-01-18 1:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 19:05 [GIT PULL v3] Fixes/cleanup for vt8500 serial Tony Prisk
2013-01-16 19:05 ` Tony Prisk
2013-01-16 19:05 ` [PATCH 1/4 v3] serial: vt8500: Fix range-checking on vt8500_uart_ports Tony Prisk
2013-01-16 19:05 ` Tony Prisk
2013-01-16 19:05 ` [PATCH 2/4 v3] serial: vt8500: ioremap'd resource is never freed Tony Prisk
2013-01-16 19:05 ` Tony Prisk
2013-01-16 19:05 ` [PATCH 3/4 v3] serial: vt8500: UART uses gated clock rather than 24Mhz reference Tony Prisk
2013-01-16 19:05 ` Tony Prisk
2013-01-18 1:25 ` Greg KH [this message]
2013-01-18 1:25 ` Greg KH
2013-01-16 19:05 ` [PATCH 4/4 v3] serial: tty: Cleanup code using devm_ function Tony Prisk
2013-01-16 19:05 ` Tony Prisk
2013-01-18 1:26 ` [PATCH 4/4 v3] serial: vt8500: " Greg KH
2013-01-18 1:26 ` Greg KH
2013-01-18 1:27 ` [GIT PULL v3] Fixes/cleanup for vt8500 serial Greg KH
2013-01-18 1:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118012550.GA28958@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.