From: Andrew Morton <akpm@linux-foundation.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrea Arcangeli <aarcange@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
Simon Jeons <simon.jeons@gmail.com>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
Hugh Dickins <hughd@google.com>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/6] mm: numa: Handle side-effects in count_vm_numa_events() for !CONFIG_NUMA_BALANCING
Date: Tue, 22 Jan 2013 14:40:24 -0800 [thread overview]
Message-ID: <20130122144024.8ded0f53.akpm@linux-foundation.org> (raw)
In-Reply-To: <1358874762-19717-4-git-send-email-mgorman@suse.de>
On Tue, 22 Jan 2013 17:12:39 +0000
Mel Gorman <mgorman@suse.de> wrote:
> The current definitions for count_vm_numa_events() is wrong for
> !CONFIG_NUMA_BALANCING as the following would miss the side-effect.
>
> count_vm_numa_events(NUMA_FOO, bar++);
Stupid macros.
> There are no such users of count_vm_numa_events() but it is a potential
> pitfall. This patch fixes it and converts count_vm_numa_event() so that
> the definitions look similar.
Confused. The patch doesn't alter count_vm_numa_event(). No matter.
> --- a/include/linux/vmstat.h
> +++ b/include/linux/vmstat.h
> @@ -85,7 +85,7 @@ static inline void vm_events_fold_cpu(int cpu)
> #define count_vm_numa_events(x, y) count_vm_events(x, y)
> #else
> #define count_vm_numa_event(x) do {} while (0)
> -#define count_vm_numa_events(x, y) do {} while (0)
> +#define count_vm_numa_events(x, y) do { (void)(y); } while (0)
> #endif /* CONFIG_NUMA_BALANCING */
>
> #define __count_zone_vm_events(item, zone, delta) \
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrea Arcangeli <aarcange@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
Simon Jeons <simon.jeons@gmail.com>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
Hugh Dickins <hughd@google.com>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/6] mm: numa: Handle side-effects in count_vm_numa_events() for !CONFIG_NUMA_BALANCING
Date: Tue, 22 Jan 2013 14:40:24 -0800 [thread overview]
Message-ID: <20130122144024.8ded0f53.akpm@linux-foundation.org> (raw)
In-Reply-To: <1358874762-19717-4-git-send-email-mgorman@suse.de>
On Tue, 22 Jan 2013 17:12:39 +0000
Mel Gorman <mgorman@suse.de> wrote:
> The current definitions for count_vm_numa_events() is wrong for
> !CONFIG_NUMA_BALANCING as the following would miss the side-effect.
>
> count_vm_numa_events(NUMA_FOO, bar++);
Stupid macros.
> There are no such users of count_vm_numa_events() but it is a potential
> pitfall. This patch fixes it and converts count_vm_numa_event() so that
> the definitions look similar.
Confused. The patch doesn't alter count_vm_numa_event(). No matter.
> --- a/include/linux/vmstat.h
> +++ b/include/linux/vmstat.h
> @@ -85,7 +85,7 @@ static inline void vm_events_fold_cpu(int cpu)
> #define count_vm_numa_events(x, y) count_vm_events(x, y)
> #else
> #define count_vm_numa_event(x) do {} while (0)
> -#define count_vm_numa_events(x, y) do {} while (0)
> +#define count_vm_numa_events(x, y) do { (void)(y); } while (0)
> #endif /* CONFIG_NUMA_BALANCING */
>
> #define __count_zone_vm_events(item, zone, delta) \
next prev parent reply other threads:[~2013-01-22 22:40 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 17:12 [PATCH 0/6] Follow up work on NUMA Balancing Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-22 17:12 ` [PATCH 1/6] mm: numa: Fix minor typo in numa_next_scan Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-22 17:12 ` [PATCH 2/6] mm: numa: Take THP into account when migrating pages for NUMA balancing Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-22 17:12 ` [PATCH 3/6] mm: numa: Handle side-effects in count_vm_numa_events() for !CONFIG_NUMA_BALANCING Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-22 22:40 ` Andrew Morton [this message]
2013-01-22 22:40 ` Andrew Morton
2013-01-23 9:27 ` Mel Gorman
2013-01-23 9:27 ` Mel Gorman
2013-01-22 17:12 ` [PATCH 4/6] mm: Move page flags layout to separate header Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-22 17:12 ` [PATCH 5/6] mm: Fold page->_last_nid into page->flags where possible Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-22 22:46 ` Andrew Morton
2013-01-22 22:46 ` Andrew Morton
2013-01-23 13:17 ` Mel Gorman
2013-01-23 13:17 ` Mel Gorman
2013-01-23 21:45 ` KOSAKI Motohiro
2013-01-23 21:45 ` KOSAKI Motohiro
2013-01-23 13:18 ` [PATCH] mm: init: Report on last-nid information stored in page->flags Mel Gorman
2013-01-23 13:18 ` Mel Gorman
2013-01-23 14:25 ` [PATCH 5/6] mm: Fold page->_last_nid into page->flags where possible Mel Gorman
2013-01-23 14:25 ` Mel Gorman
2013-01-23 21:56 ` Andrew Morton
2013-01-23 21:56 ` Andrew Morton
2013-01-24 10:55 ` [PATCH] mm: Rename page struct field helpers Mel Gorman
2013-01-24 10:55 ` Mel Gorman
2013-01-29 4:39 ` Hugh Dickins
2013-01-29 4:39 ` Hugh Dickins
2013-01-30 11:58 ` Mel Gorman
2013-01-30 11:58 ` Mel Gorman
2013-01-30 20:32 ` Hugh Dickins
2013-01-30 20:32 ` Hugh Dickins
2013-01-23 15:23 ` [PATCH] mm: uninline page_xchg_last_nid() Mel Gorman
2013-01-23 15:23 ` Mel Gorman
2013-01-22 17:12 ` [PATCH 6/6] mm: numa: Cleanup flow of transhuge page migration Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-27 21:20 ` Hugh Dickins
2013-01-27 21:20 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122144024.8ded0f53.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=aarcange@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=simon.jeons@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.