From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrea Arcangeli <aarcange@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
Simon Jeons <simon.jeons@gmail.com>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
Hugh Dickins <hughd@google.com>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] mm: Fold page->_last_nid into page->flags where possible
Date: Wed, 23 Jan 2013 14:25:07 +0000 [thread overview]
Message-ID: <20130123142507.GI13304@suse.de> (raw)
In-Reply-To: <20130122144659.d512e05c.akpm@linux-foundation.org>
On Tue, Jan 22, 2013 at 02:46:59PM -0800, Andrew Morton wrote:
>
> reset_page_last_nid() is poorly named. page_reset_last_nid() would be
> better, and consistent.
>
Look at this closer, are you sure you want? Why is page_reset_last_nid()
better or more consistent?
The getter functions for page-related fields start with page (page_count,
page_mapcount etc.) but the setters begin with set (set_page_section,
set_page_zone, set_page_links etc.). For mapcount, we also have
reset_page_mapcount() so to me reset_page_last_nid() is already
consistent.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrea Arcangeli <aarcange@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
Simon Jeons <simon.jeons@gmail.com>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
Hugh Dickins <hughd@google.com>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] mm: Fold page->_last_nid into page->flags where possible
Date: Wed, 23 Jan 2013 14:25:07 +0000 [thread overview]
Message-ID: <20130123142507.GI13304@suse.de> (raw)
In-Reply-To: <20130122144659.d512e05c.akpm@linux-foundation.org>
On Tue, Jan 22, 2013 at 02:46:59PM -0800, Andrew Morton wrote:
>
> reset_page_last_nid() is poorly named. page_reset_last_nid() would be
> better, and consistent.
>
Look at this closer, are you sure you want? Why is page_reset_last_nid()
better or more consistent?
The getter functions for page-related fields start with page (page_count,
page_mapcount etc.) but the setters begin with set (set_page_section,
set_page_zone, set_page_links etc.). For mapcount, we also have
reset_page_mapcount() so to me reset_page_last_nid() is already
consistent.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2013-01-23 14:25 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 17:12 [PATCH 0/6] Follow up work on NUMA Balancing Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-22 17:12 ` [PATCH 1/6] mm: numa: Fix minor typo in numa_next_scan Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-22 17:12 ` [PATCH 2/6] mm: numa: Take THP into account when migrating pages for NUMA balancing Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-22 17:12 ` [PATCH 3/6] mm: numa: Handle side-effects in count_vm_numa_events() for !CONFIG_NUMA_BALANCING Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-22 22:40 ` Andrew Morton
2013-01-22 22:40 ` Andrew Morton
2013-01-23 9:27 ` Mel Gorman
2013-01-23 9:27 ` Mel Gorman
2013-01-22 17:12 ` [PATCH 4/6] mm: Move page flags layout to separate header Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-22 17:12 ` [PATCH 5/6] mm: Fold page->_last_nid into page->flags where possible Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-22 22:46 ` Andrew Morton
2013-01-22 22:46 ` Andrew Morton
2013-01-23 13:17 ` Mel Gorman
2013-01-23 13:17 ` Mel Gorman
2013-01-23 21:45 ` KOSAKI Motohiro
2013-01-23 21:45 ` KOSAKI Motohiro
2013-01-23 13:18 ` [PATCH] mm: init: Report on last-nid information stored in page->flags Mel Gorman
2013-01-23 13:18 ` Mel Gorman
2013-01-23 14:25 ` Mel Gorman [this message]
2013-01-23 14:25 ` [PATCH 5/6] mm: Fold page->_last_nid into page->flags where possible Mel Gorman
2013-01-23 21:56 ` Andrew Morton
2013-01-23 21:56 ` Andrew Morton
2013-01-24 10:55 ` [PATCH] mm: Rename page struct field helpers Mel Gorman
2013-01-24 10:55 ` Mel Gorman
2013-01-29 4:39 ` Hugh Dickins
2013-01-29 4:39 ` Hugh Dickins
2013-01-30 11:58 ` Mel Gorman
2013-01-30 11:58 ` Mel Gorman
2013-01-30 20:32 ` Hugh Dickins
2013-01-30 20:32 ` Hugh Dickins
2013-01-23 15:23 ` [PATCH] mm: uninline page_xchg_last_nid() Mel Gorman
2013-01-23 15:23 ` Mel Gorman
2013-01-22 17:12 ` [PATCH 6/6] mm: numa: Cleanup flow of transhuge page migration Mel Gorman
2013-01-22 17:12 ` Mel Gorman
2013-01-27 21:20 ` Hugh Dickins
2013-01-27 21:20 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123142507.GI13304@suse.de \
--to=mgorman@suse.de \
--cc=a.p.zijlstra@chello.nl \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mingo@kernel.org \
--cc=simon.jeons@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.