All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hughd@google.com>
Cc: Petr Holasek <pholasek@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Izik Eidus <izik.eidus@ravellosystems.com>,
	Rik van Riel <riel@redhat.com>,
	David Rientjes <rientjes@google.com>,
	Anton Arapov <anton@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/11] ksm: allow trees per NUMA node
Date: Mon, 28 Jan 2013 15:08:54 -0800	[thread overview]
Message-ID: <20130128150854.6813b1ca.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1301251753380.29196@eggly.anvils>

On Fri, 25 Jan 2013 17:54:53 -0800 (PST)
Hugh Dickins <hughd@google.com> wrote:

> +/* Zeroed when merging across nodes is not allowed */
> +static unsigned int ksm_merge_across_nodes = 1;

I spose this should be __read_mostly.  If __read_mostly is not really a
synonym for __make_write_often_storage_slower.  I continue to harbor
fear, uncertainty and doubt about this...


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hughd@google.com>
Cc: Petr Holasek <pholasek@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Izik Eidus <izik.eidus@ravellosystems.com>,
	Rik van Riel <riel@redhat.com>,
	David Rientjes <rientjes@google.com>,
	Anton Arapov <anton@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/11] ksm: allow trees per NUMA node
Date: Mon, 28 Jan 2013 15:08:54 -0800	[thread overview]
Message-ID: <20130128150854.6813b1ca.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1301251753380.29196@eggly.anvils>

On Fri, 25 Jan 2013 17:54:53 -0800 (PST)
Hugh Dickins <hughd@google.com> wrote:

> +/* Zeroed when merging across nodes is not allowed */
> +static unsigned int ksm_merge_across_nodes = 1;

I spose this should be __read_mostly.  If __read_mostly is not really a
synonym for __make_write_often_storage_slower.  I continue to harbor
fear, uncertainty and doubt about this...



  parent reply	other threads:[~2013-01-28 23:08 UTC|newest]

Thread overview: 138+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-26  1:53 [PATCH 0/11] ksm: NUMA trees and page migration Hugh Dickins
2013-01-26  1:53 ` Hugh Dickins
2013-01-26  1:54 ` [PATCH 1/11] ksm: allow trees per NUMA node Hugh Dickins
2013-01-26  1:54   ` Hugh Dickins
2013-01-27  1:14   ` Simon Jeons
2013-01-27  1:14     ` Simon Jeons
2013-01-27  2:54     ` Hugh Dickins
2013-01-27  2:54       ` Hugh Dickins
2013-01-27  3:16       ` Simon Jeons
2013-01-27  3:16         ` Simon Jeons
2013-01-27 21:55         ` Hugh Dickins
2013-01-27 21:55           ` Hugh Dickins
2013-01-28 23:03   ` Andrew Morton
2013-01-28 23:03     ` Andrew Morton
2013-01-29  1:17     ` Hugh Dickins
2013-01-29  1:17       ` Hugh Dickins
2013-01-28 23:08   ` Andrew Morton [this message]
2013-01-28 23:08     ` Andrew Morton
2013-01-29  1:38     ` Hugh Dickins
2013-01-29  1:38       ` Hugh Dickins
2013-02-05 16:41   ` Mel Gorman
2013-02-05 16:41     ` Mel Gorman
2013-02-07 23:57     ` Hugh Dickins
2013-02-07 23:57       ` Hugh Dickins
2013-01-26  1:56 ` [PATCH 2/11] ksm: add sysfs ABI Documentation Hugh Dickins
2013-01-26  1:56   ` Hugh Dickins
2013-01-26  1:58 ` [PATCH 3/11] ksm: trivial tidyups Hugh Dickins
2013-01-26  1:58   ` Hugh Dickins
2013-01-28 23:11   ` Andrew Morton
2013-01-28 23:11     ` Andrew Morton
2013-01-29  1:44     ` Hugh Dickins
2013-01-29  1:44       ` Hugh Dickins
2013-01-26  1:59 ` [PATCH 4/11] ksm: reorganize ksm_check_stable_tree Hugh Dickins
2013-01-26  1:59   ` Hugh Dickins
2013-02-05 16:48   ` Mel Gorman
2013-02-05 16:48     ` Mel Gorman
2013-02-08  0:07     ` Hugh Dickins
2013-02-08  0:07       ` Hugh Dickins
2013-02-14 11:30       ` Mel Gorman
2013-02-14 11:30         ` Mel Gorman
2013-01-26  2:00 ` [PATCH 5/11] ksm: get_ksm_page locked Hugh Dickins
2013-01-26  2:00   ` Hugh Dickins
2013-01-27  2:36   ` Simon Jeons
2013-01-27  2:36     ` Simon Jeons
2013-01-27 22:08     ` Hugh Dickins
2013-01-27 22:08       ` Hugh Dickins
2013-01-28  0:36       ` Simon Jeons
2013-01-28  0:36         ` Simon Jeons
2013-01-28  3:35         ` Hugh Dickins
2013-01-28  3:35           ` Hugh Dickins
2013-01-27  2:48   ` Simon Jeons
2013-01-27  2:48     ` Simon Jeons
2013-01-27 22:10     ` Hugh Dickins
2013-01-27 22:10       ` Hugh Dickins
2013-02-05 17:18   ` Mel Gorman
2013-02-05 17:18     ` Mel Gorman
2013-02-08  0:33     ` Hugh Dickins
2013-02-08  0:33       ` Hugh Dickins
2013-02-14 11:34       ` Mel Gorman
2013-02-14 11:34         ` Mel Gorman
2013-01-26  2:01 ` [PATCH 6/11] ksm: remove old stable nodes more thoroughly Hugh Dickins
2013-01-26  2:01   ` Hugh Dickins
2013-01-27  4:55   ` Simon Jeons
2013-01-27  4:55     ` Simon Jeons
2013-01-27 23:05     ` Hugh Dickins
2013-01-27 23:05       ` Hugh Dickins
2013-01-28  1:42       ` Simon Jeons
2013-01-28  1:42         ` Simon Jeons
2013-01-28  4:14         ` Hugh Dickins
2013-01-28  4:14           ` Hugh Dickins
2013-01-28  2:12   ` Simon Jeons
2013-01-28  2:12     ` Simon Jeons
2013-01-28  4:19     ` Hugh Dickins
2013-01-28  4:19       ` Hugh Dickins
2013-01-28  6:36   ` Simon Jeons
2013-01-28  6:36     ` Simon Jeons
2013-01-28 23:44   ` Andrew Morton
2013-01-28 23:44     ` Andrew Morton
2013-01-29  2:03     ` Hugh Dickins
2013-01-29  2:03       ` Hugh Dickins
2013-02-05 17:55   ` Mel Gorman
2013-02-05 17:55     ` Mel Gorman
2013-02-08 19:33     ` Hugh Dickins
2013-02-08 19:33       ` Hugh Dickins
2013-02-14 11:58       ` Mel Gorman
2013-02-14 11:58         ` Mel Gorman
2013-02-14 22:19         ` Hugh Dickins
2013-02-14 22:19           ` Hugh Dickins
2013-01-26  2:03 ` [PATCH 7/11] ksm: make KSM page migration possible Hugh Dickins
2013-01-26  2:03   ` Hugh Dickins
2013-01-27  5:47   ` Simon Jeons
2013-01-27  5:47     ` Simon Jeons
2013-01-27 23:12     ` Hugh Dickins
2013-01-27 23:12       ` Hugh Dickins
2013-01-28  0:41       ` Simon Jeons
2013-01-28  0:41         ` Simon Jeons
2013-01-28  3:44         ` Hugh Dickins
2013-01-28  3:44           ` Hugh Dickins
2013-02-05 19:11   ` Mel Gorman
2013-02-05 19:11     ` Mel Gorman
2013-02-08 20:52     ` Hugh Dickins
2013-02-08 20:52       ` Hugh Dickins
2013-01-26  2:05 ` [PATCH 8/11] ksm: make !merge_across_nodes migration safe Hugh Dickins
2013-01-26  2:05   ` Hugh Dickins
2013-01-27  8:49   ` Simon Jeons
2013-01-27  8:49     ` Simon Jeons
2013-01-27 23:25     ` Hugh Dickins
2013-01-27 23:25       ` Hugh Dickins
2013-01-28  3:44   ` Simon Jeons
2013-01-28  3:44     ` Simon Jeons
2013-01-26  2:06 ` [PATCH 9/11] ksm: enable KSM page migration Hugh Dickins
2013-01-26  2:06   ` Hugh Dickins
2013-01-26  2:07 ` [PATCH 10/11] mm: remove offlining arg to migrate_pages Hugh Dickins
2013-01-26  2:07   ` Hugh Dickins
2013-01-26  2:10 ` [PATCH 11/11] ksm: stop hotremove lockdep warning Hugh Dickins
2013-01-26  2:10   ` Hugh Dickins
2013-01-27  6:23   ` Simon Jeons
2013-01-27  6:23     ` Simon Jeons
2013-01-27 23:35     ` Hugh Dickins
2013-01-27 23:35       ` Hugh Dickins
2013-02-08 18:45   ` Gerald Schaefer
2013-02-08 18:45     ` Gerald Schaefer
2013-02-11 22:13     ` Hugh Dickins
2013-02-11 22:13       ` Hugh Dickins
2013-01-28 23:54 ` [PATCH 0/11] ksm: NUMA trees and page migration Andrew Morton
2013-01-28 23:54   ` Andrew Morton
2013-01-29  0:49   ` Izik Eidus
2013-01-29  0:49     ` Izik Eidus
2013-01-29  2:26     ` Izik Eidus
2013-01-29  2:26       ` Izik Eidus
2013-01-29 16:51       ` Andrea Arcangeli
2013-01-29 16:51         ` Andrea Arcangeli
2013-01-31  0:05         ` Ric Mason
2013-01-31  0:05           ` Ric Mason
2013-01-29  1:07   ` Hugh Dickins
2013-01-29  1:07     ` Hugh Dickins
2013-01-29 10:45     ` Gleb Natapov
2013-01-29 10:45       ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130128150854.6813b1ca.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=aarcange@redhat.com \
    --cc=anton@redhat.com \
    --cc=hughd@google.com \
    --cc=izik.eidus@ravellosystems.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pholasek@redhat.com \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.