All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	stable@vger.kernel.org, xfs@oss.sgi.com,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 2/4] xfs: Fix possible use-after-free with AIO
Date: Tue, 29 Jan 2013 18:56:56 -0600	[thread overview]
Message-ID: <20130130005656.GM27055@sgi.com> (raw)
In-Reply-To: <1359502081-20240-3-git-send-email-jack@suse.cz>

Hi Jan,

On Wed, Jan 30, 2013 at 12:27:59AM +0100, Jan Kara wrote:
> Running AIO is pinning inode in memory using file reference. Once AIO
> is completed using aio_complete(), file reference is put and inode can
> be freed from memory. So we have to be sure that calling aio_complete()
> is the last thing we do with the inode.
> 
> CC: xfs@oss.sgi.com
> CC: Ben Myers <bpm@sgi.com>
> CC: stable@vger.kernel.org
> Reviewed-by: Ben Myers <bpm@sgi.com>
> Acked-by: Jeff Moyer <jmoyer@redhat.com>
> Signed-off-by: Jan Kara <jack@suse.cz>

We picked this up in the xfs tree.  Sorry to keep you hanging.

Regards,
	Ben

WARNING: multiple messages have this Message-ID (diff)
From: Ben Myers <bpm@sgi.com>
To: Jan Kara <jack@suse.cz>
Cc: stable@vger.kernel.org, xfs@oss.sgi.com,
	Al Viro <viro@ZenIV.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 2/4] xfs: Fix possible use-after-free with AIO
Date: Tue, 29 Jan 2013 18:56:56 -0600	[thread overview]
Message-ID: <20130130005656.GM27055@sgi.com> (raw)
In-Reply-To: <1359502081-20240-3-git-send-email-jack@suse.cz>

Hi Jan,

On Wed, Jan 30, 2013 at 12:27:59AM +0100, Jan Kara wrote:
> Running AIO is pinning inode in memory using file reference. Once AIO
> is completed using aio_complete(), file reference is put and inode can
> be freed from memory. So we have to be sure that calling aio_complete()
> is the last thing we do with the inode.
> 
> CC: xfs@oss.sgi.com
> CC: Ben Myers <bpm@sgi.com>
> CC: stable@vger.kernel.org
> Reviewed-by: Ben Myers <bpm@sgi.com>
> Acked-by: Jeff Moyer <jmoyer@redhat.com>
> Signed-off-by: Jan Kara <jack@suse.cz>

We picked this up in the xfs tree.  Sorry to keep you hanging.

Regards,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Ben Myers <bpm@sgi.com>
To: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	stable@vger.kernel.org, xfs@oss.sgi.com,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 2/4] xfs: Fix possible use-after-free with AIO
Date: Wed, 30 Jan 2013 00:57:03 -0000	[thread overview]
Message-ID: <20130130005656.GM27055@sgi.com> (raw)
In-Reply-To: <1359502081-20240-3-git-send-email-jack@suse.cz>

Hi Jan,

On Wed, Jan 30, 2013 at 12:27:59AM +0100, Jan Kara wrote:
> Running AIO is pinning inode in memory using file reference. Once AIO
> is completed using aio_complete(), file reference is put and inode can
> be freed from memory. So we have to be sure that calling aio_complete()
> is the last thing we do with the inode.
> 
> CC: xfs at oss.sgi.com
> CC: Ben Myers <bpm@sgi.com>
> CC: stable at vger.kernel.org
> Reviewed-by: Ben Myers <bpm@sgi.com>
> Acked-by: Jeff Moyer <jmoyer@redhat.com>
> Signed-off-by: Jan Kara <jack@suse.cz>

We picked this up in the xfs tree.  Sorry to keep you hanging.

Regards,
	Ben

  reply	other threads:[~2013-01-30  0:57 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-29 23:27 [PATCH 0/4 v2] Fix possible use after free with AIO Jan Kara
2013-01-29 23:27 ` [Ocfs2-devel] " Jan Kara
2013-01-29 23:27 ` [PATCH 1/4] ext4: Fix possible use-after-free " Jan Kara
2013-01-29 23:27   ` [Ocfs2-devel] " Jan Kara
2013-01-29 23:27   ` Jan Kara
2013-01-30  3:51   ` Theodore Ts'o
2013-01-30  3:51     ` [Ocfs2-devel] " Theodore Ts'o
2013-01-30  3:51     ` Theodore Ts'o
2013-01-29 23:27 ` [PATCH 2/4] xfs: " Jan Kara
2013-01-29 23:27   ` [Ocfs2-devel] " Jan Kara
2013-01-29 23:27   ` Jan Kara
2013-01-30  0:56   ` Ben Myers [this message]
2013-01-30  0:57     ` [Ocfs2-devel] " Ben Myers
2013-01-30  0:56     ` Ben Myers
2013-01-29 23:28 ` [PATCH 3/4] ocfs2: " Jan Kara
2013-01-29 23:28   ` [Ocfs2-devel] " Jan Kara
2013-01-29 23:28   ` Jan Kara
2013-01-29 23:28 ` [PATCH 4/4] fs: " Jan Kara
2013-01-29 23:28   ` [Ocfs2-devel] " Jan Kara
2013-01-29 23:28   ` Jan Kara
2013-01-30 14:45 ` [PATCH 0/4 v2] Fix possible use after free " Al Viro
2013-01-30 14:45   ` [Ocfs2-devel] " Al Viro
2013-01-30 14:45   ` Al Viro
2013-01-31  2:10   ` Li Zefan
2013-01-31  2:10     ` [Ocfs2-devel] " Li Zefan
2013-01-31  2:10     ` Li Zefan
2013-01-31 19:31   ` Joel Becker
2013-01-31 19:31     ` [Ocfs2-devel] " Joel Becker
2013-01-31 19:31     ` Joel Becker
  -- strict thread matches above, loose matches on Subject: below --
2013-01-23 12:56 [PATCH 0/4] " Jan Kara
2013-01-23 12:56 ` [PATCH 2/4] xfs: Fix possible use-after-free " Jan Kara
2013-01-23 22:00   ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130130005656.GM27055@sgi.com \
    --to=bpm@sgi.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=stable@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.