From: Fabio Baltieri <fabio.baltieri-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Nicolas Pitre
<nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cpufreq-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v7 3/4] cpufreq: conservative: call dbs_check_cpu only when necessary
Date: Wed, 30 Jan 2013 17:53:21 +0100 [thread overview]
Message-ID: <20130130165321.GD30559@balto.lan> (raw)
In-Reply-To: <CAKohpompi7mzd+XmrUzJ4T=apzpmUcryHaBfQWUoO5G3+4y=_Q@mail.gmail.com>
On Wed, Jan 30, 2013 at 09:23:22PM +0530, Viresh Kumar wrote:
> On 30 January 2013 18:30, Fabio Baltieri <fabio.baltieri-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> > Modify conservative timer to not resample CPU utilization if recently
> > sampled from another SW coordinated core.
> >
> > Signed-off-by: Fabio Baltieri <fabio.baltieri-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> We are again doing the same mistake which i fixed with:
>
> commit 4471a34f9a1f2da220272e823bdb8e8fa83a7661
> Author: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Date: Fri Oct 26 00:47:42 2012 +0200
>
> cpufreq: governors: remove redundant code
Can't argue with this, but the two had some subdle differences (namely
th two dbs_info structures) and I opted to not mess up forcing some
non-obvious common code.
Feel free to suggest a strategy.
Thanks,
Fabio
--
Fabio Baltieri
WARNING: multiple messages have this Message-ID (diff)
From: Fabio Baltieri <fabio.baltieri@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
swarren@wwwdotorg.org, linaro-dev@lists.linaro.org,
Nicolas Pitre <nicolas.pitre@linaro.org>,
mathieu.poirier@linaro.org, Joseph Lo <josephl@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 3/4] cpufreq: conservative: call dbs_check_cpu only when necessary
Date: Wed, 30 Jan 2013 17:53:21 +0100 [thread overview]
Message-ID: <20130130165321.GD30559@balto.lan> (raw)
In-Reply-To: <CAKohpompi7mzd+XmrUzJ4T=apzpmUcryHaBfQWUoO5G3+4y=_Q@mail.gmail.com>
On Wed, Jan 30, 2013 at 09:23:22PM +0530, Viresh Kumar wrote:
> On 30 January 2013 18:30, Fabio Baltieri <fabio.baltieri@linaro.org> wrote:
> > Modify conservative timer to not resample CPU utilization if recently
> > sampled from another SW coordinated core.
> >
> > Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
>
> We are again doing the same mistake which i fixed with:
>
> commit 4471a34f9a1f2da220272e823bdb8e8fa83a7661
> Author: Viresh Kumar <viresh.kumar@linaro.org>
> Date: Fri Oct 26 00:47:42 2012 +0200
>
> cpufreq: governors: remove redundant code
Can't argue with this, but the two had some subdle differences (namely
th two dbs_info structures) and I opted to not mess up forcing some
non-obvious common code.
Feel free to suggest a strategy.
Thanks,
Fabio
--
Fabio Baltieri
next prev parent reply other threads:[~2013-01-30 16:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 12:59 [PATCH v7 0/5] cpufreq: handle SW coordinated CPUs Fabio Baltieri
2013-01-30 13:00 ` [PATCH v7 1/4] " Fabio Baltieri
2013-01-30 15:02 ` Viresh Kumar
2013-01-30 16:23 ` Fabio Baltieri
2013-01-30 16:51 ` Viresh Kumar
2013-01-30 16:57 ` Fabio Baltieri
2013-01-30 21:44 ` Rafael J. Wysocki
2013-01-30 13:00 ` [PATCH v7 2/4] cpufreq: ondemand: call dbs_check_cpu only when necessary Fabio Baltieri
2013-01-30 15:51 ` Viresh Kumar
2013-01-30 16:46 ` Fabio Baltieri
[not found] ` <20130130164614.GC30559-lYxsXyORJ9v/PtFMR13I2A@public.gmane.org>
2013-01-30 17:11 ` Viresh Kumar
2013-01-30 17:11 ` Viresh Kumar
2013-01-31 8:39 ` Fabio Baltieri
[not found] ` <20130131083825.GA30667-lYxsXyORJ9v/PtFMR13I2A@public.gmane.org>
2013-01-31 8:42 ` Viresh Kumar
2013-01-31 8:42 ` Viresh Kumar
2013-01-31 9:06 ` Fabio Baltieri
2013-01-31 9:11 ` Viresh Kumar
2013-01-30 13:00 ` [PATCH v7 3/4] cpufreq: conservative: " Fabio Baltieri
2013-01-30 15:53 ` Viresh Kumar
2013-01-30 16:53 ` Fabio Baltieri [this message]
2013-01-30 16:53 ` Fabio Baltieri
[not found] ` <20130130165321.GD30559-lYxsXyORJ9v/PtFMR13I2A@public.gmane.org>
2013-01-30 17:12 ` Viresh Kumar
2013-01-30 17:12 ` Viresh Kumar
[not found] ` <1359550803-18577-1-git-send-email-fabio.baltieri-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-01-30 13:00 ` [PATCH v7 4/4] cpufreq: ondemand: use all CPUs in update_sampling_rate Fabio Baltieri
2013-01-30 13:00 ` Fabio Baltieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130165321.GD30559@balto.lan \
--to=fabio.baltieri-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=cpufreq-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.