From: Fabio Baltieri <fabio.baltieri@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
swarren@wwwdotorg.org, linaro-dev@lists.linaro.org,
Nicolas Pitre <nicolas.pitre@linaro.org>,
mathieu.poirier@linaro.org, Joseph Lo <josephl@nvidia.com>,
linux-kernel@vger.kernel.org,
Rickard Andersson <rickard.andersson@stericsson.com>
Subject: Re: [PATCH v7 1/4] cpufreq: handle SW coordinated CPUs
Date: Wed, 30 Jan 2013 17:57:39 +0100 [thread overview]
Message-ID: <20130130165739.GA21329@balto.lan> (raw)
In-Reply-To: <CAKohpoms9AK+j+Au53cwbLn=ds0AsJn+ApUMgMxe2dVhC7McVw@mail.gmail.com>
On Wed, Jan 30, 2013 at 10:21:03PM +0530, Viresh Kumar wrote:
> > I'm not sure about the name through, I like mentioning sw coordination in it
> > because that's the comment in the declaration:
> >
> > cpumask_var_t cpus; /* CPUs requiring sw coordination */
> > cpumask_var_t related_cpus; /* CPUs with any coordination */
> >
> > And those two are already confusing as a starting point.
>
> I will fix these comments with a patch of mine.
Great!
>
> > Anyway, this sounds fine to me. If you think this is useful I can send
> > a patch, or feel free to include it in your patches if you plan to do
> > further cleanup work on this code.
> >
> > /me tries to also keep that ->cpu field in mind.
>
> You can make it part of your patchsets v8.
I'm not sending a v8 as Rafael already asked for incremental, but I'll
send a patch with that soon.
Thanks,
Fabio
--
Fabio Baltieri
next prev parent reply other threads:[~2013-01-30 16:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 12:59 [PATCH v7 0/5] cpufreq: handle SW coordinated CPUs Fabio Baltieri
2013-01-30 13:00 ` [PATCH v7 1/4] " Fabio Baltieri
2013-01-30 15:02 ` Viresh Kumar
2013-01-30 16:23 ` Fabio Baltieri
2013-01-30 16:51 ` Viresh Kumar
2013-01-30 16:57 ` Fabio Baltieri [this message]
2013-01-30 21:44 ` Rafael J. Wysocki
2013-01-30 13:00 ` [PATCH v7 2/4] cpufreq: ondemand: call dbs_check_cpu only when necessary Fabio Baltieri
2013-01-30 15:51 ` Viresh Kumar
2013-01-30 16:46 ` Fabio Baltieri
[not found] ` <20130130164614.GC30559-lYxsXyORJ9v/PtFMR13I2A@public.gmane.org>
2013-01-30 17:11 ` Viresh Kumar
2013-01-30 17:11 ` Viresh Kumar
2013-01-31 8:39 ` Fabio Baltieri
[not found] ` <20130131083825.GA30667-lYxsXyORJ9v/PtFMR13I2A@public.gmane.org>
2013-01-31 8:42 ` Viresh Kumar
2013-01-31 8:42 ` Viresh Kumar
2013-01-31 9:06 ` Fabio Baltieri
2013-01-31 9:11 ` Viresh Kumar
2013-01-30 13:00 ` [PATCH v7 3/4] cpufreq: conservative: " Fabio Baltieri
2013-01-30 15:53 ` Viresh Kumar
2013-01-30 16:53 ` Fabio Baltieri
2013-01-30 16:53 ` Fabio Baltieri
[not found] ` <20130130165321.GD30559-lYxsXyORJ9v/PtFMR13I2A@public.gmane.org>
2013-01-30 17:12 ` Viresh Kumar
2013-01-30 17:12 ` Viresh Kumar
[not found] ` <1359550803-18577-1-git-send-email-fabio.baltieri-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-01-30 13:00 ` [PATCH v7 4/4] cpufreq: ondemand: use all CPUs in update_sampling_rate Fabio Baltieri
2013-01-30 13:00 ` Fabio Baltieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130165739.GA21329@balto.lan \
--to=fabio.baltieri@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=josephl@nvidia.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nicolas.pitre@linaro.org \
--cc=rickard.andersson@stericsson.com \
--cc=rjw@sisk.pl \
--cc=swarren@wwwdotorg.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.