All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: Xfs fails in xfstests 013
Date: Fri, 1 Feb 2013 11:29:27 +1100	[thread overview]
Message-ID: <20130201002927.GJ32297@disturbed.disaster> (raw)
In-Reply-To: <alpine.LFD.2.00.1301310910080.14328@dhcp-1-104.brq.redhat.com>

On Thu, Jan 31, 2013 at 09:19:23AM +0100, Lukáš Czerner wrote:
> Hi.
> 
> I've just run xfstest 013 on xfs and it fails with this backtrace
> 
> 
> Jan 31 03:09:07 rhel6_vm1 kernel: ffff88020b6d1000: 78 78 78 78 78 78 78 78 78 78 2f 78 78 78 78 78  xxxxxxxxxx/xxxxx
> Jan 31 03:09:07 rhel6_vm1 kernel: XFS (sda): Internal error xfs_bmbt_verify at line 747 of file fs/xfs/xfs_bmap_btree.c.  Caller 0xffffffffa025486e

Same problem Cai Qian just reported - a remote symlink with a bmbt
verifier attached to it.

> I can reproduce it every time with xfstest 013 on 3.8.0-rc5.

And the configuration you are testing?

I'd suggest that you add an:

	ASSERT(bp->b_ops == NULL);

into xfs_symlink() after the xfs_trans_get_buf() call in the remote
symlink crate loop, because the problem occurring implies that the
code is getting a new buffer with a stale ops structure on it
(though I can't see how that is possible right now).

You should probably put the same assert into
xfs_inactive_symlink_rmt() between the get buf and the
xfs_trans_binval() call, and into xfs_readlink_bmap() after the
contents of a symlink are read from disk.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-02-01  0:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-31  8:19 Xfs fails in xfstests 013 Lukáš Czerner
2013-01-31 19:08 ` Ben Myers
2013-02-01  0:29 ` Dave Chinner [this message]
2013-02-01 10:58   ` Lukáš Czerner
2013-02-01 14:33     ` Lukáš Czerner
2013-02-03 23:00       ` Dave Chinner
2013-02-10 22:16         ` Dave Chinner
2013-02-11 12:08           ` Lukáš Czerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130201002927.GJ32297@disturbed.disaster \
    --to=david@fromorbit.com \
    --cc=lczerner@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.