From: "Lukáš Czerner" <lczerner@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: "Lukáš Czerner" <lczerner@redhat.com>, xfs@oss.sgi.com
Subject: Re: Xfs fails in xfstests 013
Date: Mon, 11 Feb 2013 13:08:12 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1302111307001.2315@(none)> (raw)
In-Reply-To: <20130210221600.GC8257@dastard>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1323 bytes --]
On Mon, 11 Feb 2013, Dave Chinner wrote:
> Date: Mon, 11 Feb 2013 09:16:00 +1100
> From: Dave Chinner <david@fromorbit.com>
> To: Lukáš Czerner <lczerner@redhat.com>
> Cc: xfs@oss.sgi.com
> Subject: Re: Xfs fails in xfstests 013
>
> On Mon, Feb 04, 2013 at 10:00:13AM +1100, Dave Chinner wrote:
> > On Fri, Feb 01, 2013 at 03:33:06PM +0100, Lukáš Czerner wrote:
> > > On Fri, 1 Feb 2013, Lukáš Czerner wrote:
> > > and I have not hit the assert. However I think that I know what's
> > > going on. The verifier is obviously not attached when the symlink is
> > > created, however it is attached when security attributes are created
> > > for the symlink by xfs_init_security().
> >
> > Which means the bug is in xfs_bmap_add_attrfork_local() in calling
> > xfs_bmap_local_to_extents(). i.e it assumes that the local data is
> > either directory data or extent data, and is attaching extent tree
> > verifiers to the buffer that contains a remote symlink. Thinking
> > time now needed, as this affects the symlink CRC changes as well.
> >
> > Thanks for the debug help, Lukas.
>
> Lukas, can you check whether the patch below fixes the problem you
> saw?
Hi Dave,
from my testing it seems that ti fixes the problem. Can not
reproduce it anymore with the patch applied.
Thanks!
-Lukas
>
> Cheers,
>
> Dave.
>
[-- Attachment #2: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-02-11 12:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 8:19 Xfs fails in xfstests 013 Lukáš Czerner
2013-01-31 19:08 ` Ben Myers
2013-02-01 0:29 ` Dave Chinner
2013-02-01 10:58 ` Lukáš Czerner
2013-02-01 14:33 ` Lukáš Czerner
2013-02-03 23:00 ` Dave Chinner
2013-02-10 22:16 ` Dave Chinner
2013-02-11 12:08 ` Lukáš Czerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='alpine.LFD.2.00.1302111307001.2315@(none)' \
--to=lczerner@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.