From: Dave Chinner <david@fromorbit.com>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: Xfs fails in xfstests 013
Date: Mon, 4 Feb 2013 10:00:13 +1100 [thread overview]
Message-ID: <20130203230013.GI2667@dastard> (raw)
In-Reply-To: <alpine.LFD.2.00.1302011219300.6969@dhcp-1-104.brq.redhat.com>
On Fri, Feb 01, 2013 at 03:33:06PM +0100, Lukáš Czerner wrote:
> On Fri, 1 Feb 2013, Lukáš Czerner wrote:
> and I have not hit the assert. However I think that I know what's
> going on. The verifier is obviously not attached when the symlink is
> created, however it is attached when security attributes are created
> for the symlink by xfs_init_security().
Which means the bug is in xfs_bmap_add_attrfork_local() in calling
xfs_bmap_local_to_extents(). i.e it assumes that the local data is
either directory data or extent data, and is attaching extent tree
verifiers to the buffer that contains a remote symlink. Thinking
time now needed, as this affects the symlink CRC changes as well.
Thanks for the debug help, Lukas.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-02-03 23:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 8:19 Xfs fails in xfstests 013 Lukáš Czerner
2013-01-31 19:08 ` Ben Myers
2013-02-01 0:29 ` Dave Chinner
2013-02-01 10:58 ` Lukáš Czerner
2013-02-01 14:33 ` Lukáš Czerner
2013-02-03 23:00 ` Dave Chinner [this message]
2013-02-10 22:16 ` Dave Chinner
2013-02-11 12:08 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130203230013.GI2667@dastard \
--to=david@fromorbit.com \
--cc=lczerner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.