From: Simon Horman <horms@verge.net.au>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>, Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH/RFC v2 06/11] mmc: tmio-mmc: define device-tree bindings
Date: Fri, 1 Feb 2013 13:23:51 +0900 [thread overview]
Message-ID: <20130201042350.GA6898@verge.net.au> (raw)
In-Reply-To: <1358955158-1510-7-git-send-email-g.liakhovetski@gmx.de>
On Wed, Jan 23, 2013 at 04:32:33PM +0100, Guennadi Liakhovetski wrote:
> Define device-tree bindings for the tmio-mmc driver to be able to specify
> parameters, currently provided in platform data.
>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> Please, comment on this one, since it is defining an ABI
>
> Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 19 +++++++++++++++++++
> 1 files changed, 19 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mmc/tmio_mmc.txt
>
> diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> new file mode 100644
> index 0000000..dd8decd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> @@ -0,0 +1,19 @@
> +* Toshiba Mobile IO SD/MMC controller
> +
> +The tmio-mmc driver doesn't probe its devices actively, instead its binding to
> +devices is managed by either MFD drivers or by the sh_mobile_sdhi platform
> +driver. Those drivers supply the tmio-mmc driver with platform data, that either
> +describe hardware capabilities, known to them, or are obtained by them from
> +their own platform data or from their DT information. In the latter case all
> +compulsory and any optional properties, common to all SD/MMC drivers, as
> +described in mmc.txt, should or can be used. Additionally the following optional
> +bindings can be used. They set either respective TMIO_MMC_* flags or MMC_CAP_*
> +capabilities.
> +
> +Optional properties:
> +- toshiba,mmc-wrprotect-disable : set TMIO_MMC_WRPROTECT_DISABLE flag
> +- toshiba,mmc-blksz-2bytes : set TMIO_MMC_BLKSZ_2BYTES
> +- toshiba,mmc-cap-sdio-irq : SDIO IRQ signalling should be used, if
> + supported by the hardware, i.e. set MMC_CAP_SDIO_IRQ if
> + TMIO_MMC_SDIO_IRQ is also set
> +- toshiba,mmc-has-idle-wait : set TMIO_MMC_HAS_IDLE_WAIT
FWIW, TMIO_MMC_HAS_IDLE_WAIT appears to be required for SDHI0 to
function on the Marzen board. As I have been doing some work on
bring up the Marzen board using DT I am very happy to see these new
bindings.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>, Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH/RFC v2 06/11] mmc: tmio-mmc: define device-tree bindings
Date: Fri, 01 Feb 2013 04:23:51 +0000 [thread overview]
Message-ID: <20130201042350.GA6898@verge.net.au> (raw)
In-Reply-To: <1358955158-1510-7-git-send-email-g.liakhovetski@gmx.de>
On Wed, Jan 23, 2013 at 04:32:33PM +0100, Guennadi Liakhovetski wrote:
> Define device-tree bindings for the tmio-mmc driver to be able to specify
> parameters, currently provided in platform data.
>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> Please, comment on this one, since it is defining an ABI
>
> Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 19 +++++++++++++++++++
> 1 files changed, 19 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mmc/tmio_mmc.txt
>
> diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> new file mode 100644
> index 0000000..dd8decd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> @@ -0,0 +1,19 @@
> +* Toshiba Mobile IO SD/MMC controller
> +
> +The tmio-mmc driver doesn't probe its devices actively, instead its binding to
> +devices is managed by either MFD drivers or by the sh_mobile_sdhi platform
> +driver. Those drivers supply the tmio-mmc driver with platform data, that either
> +describe hardware capabilities, known to them, or are obtained by them from
> +their own platform data or from their DT information. In the latter case all
> +compulsory and any optional properties, common to all SD/MMC drivers, as
> +described in mmc.txt, should or can be used. Additionally the following optional
> +bindings can be used. They set either respective TMIO_MMC_* flags or MMC_CAP_*
> +capabilities.
> +
> +Optional properties:
> +- toshiba,mmc-wrprotect-disable : set TMIO_MMC_WRPROTECT_DISABLE flag
> +- toshiba,mmc-blksz-2bytes : set TMIO_MMC_BLKSZ_2BYTES
> +- toshiba,mmc-cap-sdio-irq : SDIO IRQ signalling should be used, if
> + supported by the hardware, i.e. set MMC_CAP_SDIO_IRQ if
> + TMIO_MMC_SDIO_IRQ is also set
> +- toshiba,mmc-has-idle-wait : set TMIO_MMC_HAS_IDLE_WAIT
FWIW, TMIO_MMC_HAS_IDLE_WAIT appears to be required for SDHI0 to
function on the Marzen board. As I have been doing some work on
bring up the Marzen board using DT I am very happy to see these new
bindings.
next prev parent reply other threads:[~2013-02-01 4:23 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 15:32 [PATCH v2 00/11] mmc: core and driver DT and related development Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 01/11] mmc: sdhi, tmio: only check flags in tmio-mmc driver proper Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-28 22:23 ` Chris Ball
2013-01-28 22:23 ` Chris Ball
2013-01-30 15:47 ` Arnd Bergmann
2013-01-30 16:02 ` Guennadi Liakhovetski
2013-01-30 16:02 ` Guennadi Liakhovetski
2013-01-30 16:13 ` Guennadi Liakhovetski
2013-01-30 16:13 ` Guennadi Liakhovetski
2013-01-30 16:29 ` Arnd Bergmann
2013-01-30 16:29 ` Arnd Bergmann
2013-01-30 17:03 ` Guennadi Liakhovetski
2013-01-30 17:03 ` Guennadi Liakhovetski
2013-01-31 0:09 ` Arnd Bergmann
2013-01-31 0:20 ` Chris Ball
2013-01-31 0:20 ` Chris Ball
2013-01-31 6:47 ` Guennadi Liakhovetski
2013-01-31 6:47 ` Guennadi Liakhovetski
2013-01-31 9:00 ` Arnd Bergmann
2013-01-23 15:32 ` [PATCH v2 03/11] mmc: provide a standard MMC device-tree binding parser centrally Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 04/11] mmc: (cosmetic) remove "extern" from function declarations Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 05/11] mmc: sh-mmcif: use mmc_of_parse() to parse standard MMC DT bindings Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-28 22:25 ` Chris Ball
2013-01-28 22:25 ` Chris Ball
2013-01-23 15:32 ` [PATCH/RFC v2 06/11] mmc: tmio-mmc: define device-tree bindings Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-24 15:34 ` Guennadi Liakhovetski
2013-01-24 15:34 ` Guennadi Liakhovetski
2013-01-24 15:39 ` Chris Ball
2013-01-24 15:39 ` Chris Ball
2013-01-24 15:58 ` Guennadi Liakhovetski
2013-01-24 15:58 ` Guennadi Liakhovetski
2013-01-24 16:03 ` Chris Ball
2013-01-24 16:03 ` Chris Ball
2013-01-30 14:07 ` Guennadi Liakhovetski
2013-01-30 14:07 ` Guennadi Liakhovetski
2013-01-30 14:09 ` Chris Ball
2013-01-30 14:09 ` Chris Ball
2013-02-01 4:23 ` Simon Horman [this message]
2013-02-01 4:23 ` Simon Horman
2013-01-23 15:32 ` [PATCH v2 07/11] mmc: tmio-mmc: parse " Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 08/11] mmc: sh_mobile_sdhi: remove unused .pdata field Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 09/11] mmc: sh_mobile_sdhi: use managed resource allocations Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 10/11] mmc: tmio: remove unused and deprecated symbols Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 11/11] mmc: tmio: add support for the VccQ regulator Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201042350.GA6898@verge.net.au \
--to=horms@verge.net.au \
--cc=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.