From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH v2 05/11] mmc: sh-mmcif: use mmc_of_parse() to parse standard MMC DT bindings
Date: Mon, 28 Jan 2013 17:25:15 -0500 [thread overview]
Message-ID: <87zjzt54j8.fsf@laptop.org> (raw)
In-Reply-To: <1358955158-1510-6-git-send-email-g.liakhovetski@gmx.de> (Guennadi Liakhovetski's message of "Wed, 23 Jan 2013 16:32:32 +0100")
Hi Guennadi,
On Wed, Jan 23 2013, Guennadi Liakhovetski wrote:
> Use mmc_of_parse() to get interface capability flags and used GPIOs from
> device-tree bindings.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> drivers/mmc/host/sh_mmcif.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index 741aeb9..4de94a1 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -1329,6 +1329,7 @@ static int sh_mmcif_probe(struct platform_device *pdev)
> ret = -ENOMEM;
> goto ealloch;
> }
> + mmc_of_parse(mmc);
> host = mmc_priv(mmc);
> host->mmc = mmc;
> host->addr = reg;
> @@ -1341,7 +1342,7 @@ static int sh_mmcif_probe(struct platform_device *pdev)
> mmc->ops = &sh_mmcif_ops;
> sh_mmcif_init_ocr(host);
>
> - mmc->caps = MMC_CAP_MMC_HIGHSPEED;
> + mmc->caps |= MMC_CAP_MMC_HIGHSPEED;
> if (pd && pd->caps)
> mmc->caps |= pd->caps;
> mmc->max_segs = 32;
This patch doesn't apply because you don't seem to have this patch:
Author: Teppei Kamijou <teppei.kamijou.yb@renesas.com>
Date: Wed Dec 12 15:38:10 2012 +0100
Subject: mmc: sh_mmcif: Avoid unnecessary mmc_delay() at mmc_card_sleepawake()
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH v2 05/11] mmc: sh-mmcif: use mmc_of_parse() to parse standard MMC DT bindings
Date: Mon, 28 Jan 2013 22:25:15 +0000 [thread overview]
Message-ID: <87zjzt54j8.fsf@laptop.org> (raw)
In-Reply-To: <1358955158-1510-6-git-send-email-g.liakhovetski@gmx.de> (Guennadi Liakhovetski's message of "Wed, 23 Jan 2013 16:32:32 +0100")
Hi Guennadi,
On Wed, Jan 23 2013, Guennadi Liakhovetski wrote:
> Use mmc_of_parse() to get interface capability flags and used GPIOs from
> device-tree bindings.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> drivers/mmc/host/sh_mmcif.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index 741aeb9..4de94a1 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -1329,6 +1329,7 @@ static int sh_mmcif_probe(struct platform_device *pdev)
> ret = -ENOMEM;
> goto ealloch;
> }
> + mmc_of_parse(mmc);
> host = mmc_priv(mmc);
> host->mmc = mmc;
> host->addr = reg;
> @@ -1341,7 +1342,7 @@ static int sh_mmcif_probe(struct platform_device *pdev)
> mmc->ops = &sh_mmcif_ops;
> sh_mmcif_init_ocr(host);
>
> - mmc->caps = MMC_CAP_MMC_HIGHSPEED;
> + mmc->caps |= MMC_CAP_MMC_HIGHSPEED;
> if (pd && pd->caps)
> mmc->caps |= pd->caps;
> mmc->max_segs = 32;
This patch doesn't apply because you don't seem to have this patch:
Author: Teppei Kamijou <teppei.kamijou.yb@renesas.com>
Date: Wed Dec 12 15:38:10 2012 +0100
Subject: mmc: sh_mmcif: Avoid unnecessary mmc_delay() at mmc_card_sleepawake()
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2013-01-28 22:25 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 15:32 [PATCH v2 00/11] mmc: core and driver DT and related development Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 01/11] mmc: sdhi, tmio: only check flags in tmio-mmc driver proper Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-28 22:23 ` Chris Ball
2013-01-28 22:23 ` Chris Ball
2013-01-30 15:47 ` Arnd Bergmann
2013-01-30 16:02 ` Guennadi Liakhovetski
2013-01-30 16:02 ` Guennadi Liakhovetski
2013-01-30 16:13 ` Guennadi Liakhovetski
2013-01-30 16:13 ` Guennadi Liakhovetski
2013-01-30 16:29 ` Arnd Bergmann
2013-01-30 16:29 ` Arnd Bergmann
2013-01-30 17:03 ` Guennadi Liakhovetski
2013-01-30 17:03 ` Guennadi Liakhovetski
2013-01-31 0:09 ` Arnd Bergmann
2013-01-31 0:20 ` Chris Ball
2013-01-31 0:20 ` Chris Ball
2013-01-31 6:47 ` Guennadi Liakhovetski
2013-01-31 6:47 ` Guennadi Liakhovetski
2013-01-31 9:00 ` Arnd Bergmann
2013-01-23 15:32 ` [PATCH v2 03/11] mmc: provide a standard MMC device-tree binding parser centrally Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 04/11] mmc: (cosmetic) remove "extern" from function declarations Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 05/11] mmc: sh-mmcif: use mmc_of_parse() to parse standard MMC DT bindings Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-28 22:25 ` Chris Ball [this message]
2013-01-28 22:25 ` Chris Ball
2013-01-23 15:32 ` [PATCH/RFC v2 06/11] mmc: tmio-mmc: define device-tree bindings Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-24 15:34 ` Guennadi Liakhovetski
2013-01-24 15:34 ` Guennadi Liakhovetski
2013-01-24 15:39 ` Chris Ball
2013-01-24 15:39 ` Chris Ball
2013-01-24 15:58 ` Guennadi Liakhovetski
2013-01-24 15:58 ` Guennadi Liakhovetski
2013-01-24 16:03 ` Chris Ball
2013-01-24 16:03 ` Chris Ball
2013-01-30 14:07 ` Guennadi Liakhovetski
2013-01-30 14:07 ` Guennadi Liakhovetski
2013-01-30 14:09 ` Chris Ball
2013-01-30 14:09 ` Chris Ball
2013-02-01 4:23 ` Simon Horman
2013-02-01 4:23 ` Simon Horman
2013-01-23 15:32 ` [PATCH v2 07/11] mmc: tmio-mmc: parse " Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 08/11] mmc: sh_mobile_sdhi: remove unused .pdata field Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 09/11] mmc: sh_mobile_sdhi: use managed resource allocations Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 10/11] mmc: tmio: remove unused and deprecated symbols Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
2013-01-23 15:32 ` [PATCH v2 11/11] mmc: tmio: add support for the VccQ regulator Guennadi Liakhovetski
2013-01-23 15:32 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjzt54j8.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.