From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
arm@kernel.org, Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: Latest additional build warnings
Date: Tue, 5 Feb 2013 09:51:26 -0800 [thread overview]
Message-ID: <20130205175126.GH25185@atomide.com> (raw)
In-Reply-To: <20130205142218.GB17833@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [130205 06:25]:
> arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class
> arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall'
> arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration
> arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used
Thanks looks like I missed that one somehow. Here's a fix for
it.
Arnd & Olof, care to apply this directly into the arm-soc multiplatform
branch?
Regards,
Tony
From: Tony Lindgren <tony@atomide.com>
Date: Tue, 5 Feb 2013 09:48:08 -0800
Subject: [PATCH] ARM: OMAP2+: Fix warning for hwspinlock omap_postcore_initcall
Commit 816a65ef4 (ARM: OMAP2+: Limit omap initcalls to omap only on
multiplatform kernels) fixed up things for multiplatform booting
but failed to include soc.h causing a new warning:
arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class
arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall'
arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration
arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used
Reported-by: Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/mach-omap2/hwspinlock.c b/arch/arm/mach-omap2/hwspinlock.c
index ce1b5b6..bcb357e 100644
--- a/arch/arm/mach-omap2/hwspinlock.c
+++ b/arch/arm/mach-omap2/hwspinlock.c
@@ -21,6 +21,7 @@
#include <linux/err.h>
#include <linux/hwspinlock.h>
+#include "soc.h"
#include "omap_hwmod.h"
#include "omap_device.h"
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: Latest additional build warnings
Date: Tue, 5 Feb 2013 09:51:26 -0800 [thread overview]
Message-ID: <20130205175126.GH25185@atomide.com> (raw)
In-Reply-To: <20130205142218.GB17833@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [130205 06:25]:
> arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class
> arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall'
> arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration
> arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used
Thanks looks like I missed that one somehow. Here's a fix for
it.
Arnd & Olof, care to apply this directly into the arm-soc multiplatform
branch?
Regards,
Tony
From: Tony Lindgren <tony@atomide.com>
Date: Tue, 5 Feb 2013 09:48:08 -0800
Subject: [PATCH] ARM: OMAP2+: Fix warning for hwspinlock omap_postcore_initcall
Commit 816a65ef4 (ARM: OMAP2+: Limit omap initcalls to omap only on
multiplatform kernels) fixed up things for multiplatform booting
but failed to include soc.h causing a new warning:
arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class
arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall'
arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration
arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used
Reported-by: Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/mach-omap2/hwspinlock.c b/arch/arm/mach-omap2/hwspinlock.c
index ce1b5b6..bcb357e 100644
--- a/arch/arm/mach-omap2/hwspinlock.c
+++ b/arch/arm/mach-omap2/hwspinlock.c
@@ -21,6 +21,7 @@
#include <linux/err.h>
#include <linux/hwspinlock.h>
+#include "soc.h"
#include "omap_hwmod.h"
#include "omap_device.h"
next prev parent reply other threads:[~2013-02-05 17:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 14:22 Latest additional build warnings Russell King - ARM Linux
2013-02-05 14:22 ` Russell King - ARM Linux
2013-02-05 17:51 ` Tony Lindgren [this message]
2013-02-05 17:51 ` Tony Lindgren
2013-02-05 22:11 ` Olof Johansson
2013-02-05 22:11 ` Olof Johansson
2013-02-09 11:49 ` Russell King - ARM Linux
2013-02-09 11:49 ` Russell King - ARM Linux
2013-02-10 3:00 ` Tony Lindgren
2013-02-10 3:00 ` Tony Lindgren
2013-02-10 3:01 ` Olof Johansson
2013-02-10 3:01 ` Olof Johansson
2013-02-10 3:22 ` Tony Lindgren
2013-02-10 3:22 ` Tony Lindgren
2013-02-10 3:47 ` Tony Lindgren
2013-02-10 3:47 ` Tony Lindgren
2013-02-10 4:22 ` Olof Johansson
2013-02-10 4:22 ` Olof Johansson
2013-02-11 19:05 ` Tony Lindgren
2013-02-11 19:05 ` Tony Lindgren
2013-02-11 19:06 ` Olof Johansson
2013-02-11 19:06 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205175126.GH25185@atomide.com \
--to=tony@atomide.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.