From: Tony Lindgren <tony@atomide.com>
To: Olof Johansson <olof@lixom.net>
Cc: linux-omap@vger.kernel.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
arm@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: Latest additional build warnings
Date: Sat, 9 Feb 2013 19:22:34 -0800 [thread overview]
Message-ID: <20130210032234.GE4801@atomide.com> (raw)
In-Reply-To: <CAOesGMgvEVsB7OWs43EWjgsR8af2_RZS9Dod3PURu6Tvdi4QJw@mail.gmail.com>
* Olof Johansson <olof@lixom.net> [130209 19:08]:
> On Sat, Feb 9, 2013 at 7:00 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [130209 03:53]:
> >> On Tue, Feb 05, 2013 at 02:22:18PM +0000, Russell King - ARM Linux wrote:
> >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class
> >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall'
> >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration
> >> > arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used
> >>
> >> I'm still seeing the above in the build of Friday's merge. I'm also
> >> seeing additional warnings in the randconfig similar to the above for
> >> arch/arm/mach-omap2/omap-iommu.c.
> >
> > Thanks for letting me know about the omap-iommu.c one. Looks like
> > there's also one patch for drm.c.
> >
> > Olof, if you did not yet apply the hwspinlock.c warning fix, I'll
> > just do a branch with all three of them for you.
>
> I haven't (must have missed it), so please just send a branch.
OK will do. Probably you started fixing up the bad Reported-by
line in my patch and then got disrupted :)
Found one more after some grepping, after the following patch they
should be all fixed up. Pull request coming shortly.
Tony
From: Tony Lindgren <tony@atomide.com>
Date: Sat, 9 Feb 2013 19:20:57 -0800
Subject: [PATCH] ARCH: OMAP2+: Make sure files with omap initcalls include soc.h
Looks like there are few more places that I missed that can cause
compiler warnings. After grepping for omap initcall, all files
needing soc.h should now have it.
Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Tony Lindgren <tony@atomide.com>
--- a/arch/arm/mach-omap2/omap-iommu.c
+++ b/arch/arm/mach-omap2/omap-iommu.c
@@ -16,6 +16,7 @@
#include <linux/slab.h>
#include <linux/platform_data/iommu-omap.h>
+#include "soc.h"
#include "omap_hwmod.h"
#include "omap_device.h"
--- a/arch/arm/mach-omap2/smartreflex-class3.c
+++ b/arch/arm/mach-omap2/smartreflex-class3.c
@@ -12,6 +12,7 @@
*/
#include <linux/power/smartreflex.h>
+#include "soc.h"
#include "voltage.h"
static int sr_class3_enable(struct omap_sr *sr)
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: Latest additional build warnings
Date: Sat, 9 Feb 2013 19:22:34 -0800 [thread overview]
Message-ID: <20130210032234.GE4801@atomide.com> (raw)
In-Reply-To: <CAOesGMgvEVsB7OWs43EWjgsR8af2_RZS9Dod3PURu6Tvdi4QJw@mail.gmail.com>
* Olof Johansson <olof@lixom.net> [130209 19:08]:
> On Sat, Feb 9, 2013 at 7:00 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [130209 03:53]:
> >> On Tue, Feb 05, 2013 at 02:22:18PM +0000, Russell King - ARM Linux wrote:
> >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class
> >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall'
> >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration
> >> > arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used
> >>
> >> I'm still seeing the above in the build of Friday's merge. I'm also
> >> seeing additional warnings in the randconfig similar to the above for
> >> arch/arm/mach-omap2/omap-iommu.c.
> >
> > Thanks for letting me know about the omap-iommu.c one. Looks like
> > there's also one patch for drm.c.
> >
> > Olof, if you did not yet apply the hwspinlock.c warning fix, I'll
> > just do a branch with all three of them for you.
>
> I haven't (must have missed it), so please just send a branch.
OK will do. Probably you started fixing up the bad Reported-by
line in my patch and then got disrupted :)
Found one more after some grepping, after the following patch they
should be all fixed up. Pull request coming shortly.
Tony
From: Tony Lindgren <tony@atomide.com>
Date: Sat, 9 Feb 2013 19:20:57 -0800
Subject: [PATCH] ARCH: OMAP2+: Make sure files with omap initcalls include soc.h
Looks like there are few more places that I missed that can cause
compiler warnings. After grepping for omap initcall, all files
needing soc.h should now have it.
Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Tony Lindgren <tony@atomide.com>
--- a/arch/arm/mach-omap2/omap-iommu.c
+++ b/arch/arm/mach-omap2/omap-iommu.c
@@ -16,6 +16,7 @@
#include <linux/slab.h>
#include <linux/platform_data/iommu-omap.h>
+#include "soc.h"
#include "omap_hwmod.h"
#include "omap_device.h"
--- a/arch/arm/mach-omap2/smartreflex-class3.c
+++ b/arch/arm/mach-omap2/smartreflex-class3.c
@@ -12,6 +12,7 @@
*/
#include <linux/power/smartreflex.h>
+#include "soc.h"
#include "voltage.h"
static int sr_class3_enable(struct omap_sr *sr)
next prev parent reply other threads:[~2013-02-10 3:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 14:22 Latest additional build warnings Russell King - ARM Linux
2013-02-05 14:22 ` Russell King - ARM Linux
2013-02-05 17:51 ` Tony Lindgren
2013-02-05 17:51 ` Tony Lindgren
2013-02-05 22:11 ` Olof Johansson
2013-02-05 22:11 ` Olof Johansson
2013-02-09 11:49 ` Russell King - ARM Linux
2013-02-09 11:49 ` Russell King - ARM Linux
2013-02-10 3:00 ` Tony Lindgren
2013-02-10 3:00 ` Tony Lindgren
2013-02-10 3:01 ` Olof Johansson
2013-02-10 3:01 ` Olof Johansson
2013-02-10 3:22 ` Tony Lindgren [this message]
2013-02-10 3:22 ` Tony Lindgren
2013-02-10 3:47 ` Tony Lindgren
2013-02-10 3:47 ` Tony Lindgren
2013-02-10 4:22 ` Olof Johansson
2013-02-10 4:22 ` Olof Johansson
2013-02-11 19:05 ` Tony Lindgren
2013-02-11 19:05 ` Tony Lindgren
2013-02-11 19:06 ` Olof Johansson
2013-02-11 19:06 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130210032234.GE4801@atomide.com \
--to=tony@atomide.com \
--cc=arm@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.