From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@linaro.org>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2+: SmartReflex: soc.h is needed for omap initcalls
Date: Tue, 12 Feb 2013 17:12:33 -0800 [thread overview]
Message-ID: <20130213011233.GC11362@atomide.com> (raw)
In-Reply-To: <1360707836-2545-1-git-send-email-khilman@linaro.org>
* Kevin Hilman <khilman@linaro.org> [130212 14:27]:
> commit aa4f99638b (ARM: OMAP2+: Use omap initcalls) converted
> the initcalls here, but did not #include "soc.h" where the omap
> inicalls are defined.
>
> To fix, #include <soc.h>
Thanks, this should be already fixed in arm-soc/for-next. I might
have forgotten to merge these into omap-for-v3.9/tmp-merge though.
Regards,
Tony
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
> Tony, the patch that broke this was introduced in your
> omap-for-v3.9/multiplatform-enable-signed branch, and this problem was
> found only when compiling with PM (specifically, SmartReflex) enabled.
>
> arch/arm/mach-omap2/smartreflex-class3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/smartreflex-class3.c b/arch/arm/mach-omap2/smartreflex-class3.c
> index 80f3acb..b2dcbd3 100644
> --- a/arch/arm/mach-omap2/smartreflex-class3.c
> +++ b/arch/arm/mach-omap2/smartreflex-class3.c
> @@ -13,6 +13,7 @@
>
> #include <linux/power/smartreflex.h>
> #include "voltage.h"
> +#include "soc.h"
>
> static int sr_class3_enable(struct omap_sr *sr)
> {
> --
> 1.8.1.2
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: SmartReflex: soc.h is needed for omap initcalls
Date: Tue, 12 Feb 2013 17:12:33 -0800 [thread overview]
Message-ID: <20130213011233.GC11362@atomide.com> (raw)
In-Reply-To: <1360707836-2545-1-git-send-email-khilman@linaro.org>
* Kevin Hilman <khilman@linaro.org> [130212 14:27]:
> commit aa4f99638b (ARM: OMAP2+: Use omap initcalls) converted
> the initcalls here, but did not #include "soc.h" where the omap
> inicalls are defined.
>
> To fix, #include <soc.h>
Thanks, this should be already fixed in arm-soc/for-next. I might
have forgotten to merge these into omap-for-v3.9/tmp-merge though.
Regards,
Tony
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
> Tony, the patch that broke this was introduced in your
> omap-for-v3.9/multiplatform-enable-signed branch, and this problem was
> found only when compiling with PM (specifically, SmartReflex) enabled.
>
> arch/arm/mach-omap2/smartreflex-class3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/smartreflex-class3.c b/arch/arm/mach-omap2/smartreflex-class3.c
> index 80f3acb..b2dcbd3 100644
> --- a/arch/arm/mach-omap2/smartreflex-class3.c
> +++ b/arch/arm/mach-omap2/smartreflex-class3.c
> @@ -13,6 +13,7 @@
>
> #include <linux/power/smartreflex.h>
> #include "voltage.h"
> +#include "soc.h"
>
> static int sr_class3_enable(struct omap_sr *sr)
> {
> --
> 1.8.1.2
>
next prev parent reply other threads:[~2013-02-13 1:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 22:23 [PATCH] ARM: OMAP2+: SmartReflex: soc.h is needed for omap initcalls Kevin Hilman
2013-02-12 22:23 ` Kevin Hilman
2013-02-13 1:12 ` Tony Lindgren [this message]
2013-02-13 1:12 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213011233.GC11362@atomide.com \
--to=tony@atomide.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.