* [PATCH] ARM: OMAP2+: SmartReflex: soc.h is needed for omap initcalls
@ 2013-02-12 22:23 ` Kevin Hilman
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2013-02-12 22:23 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap, linux-arm-kernel
commit aa4f99638b (ARM: OMAP2+: Use omap initcalls) converted
the initcalls here, but did not #include "soc.h" where the omap
inicalls are defined.
To fix, #include <soc.h>
Signed-off-by: Kevin Hilman <khilman@linaro.org>
---
Tony, the patch that broke this was introduced in your
omap-for-v3.9/multiplatform-enable-signed branch, and this problem was
found only when compiling with PM (specifically, SmartReflex) enabled.
arch/arm/mach-omap2/smartreflex-class3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/smartreflex-class3.c b/arch/arm/mach-omap2/smartreflex-class3.c
index 80f3acb..b2dcbd3 100644
--- a/arch/arm/mach-omap2/smartreflex-class3.c
+++ b/arch/arm/mach-omap2/smartreflex-class3.c
@@ -13,6 +13,7 @@
#include <linux/power/smartreflex.h>
#include "voltage.h"
+#include "soc.h"
static int sr_class3_enable(struct omap_sr *sr)
{
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: OMAP2+: SmartReflex: soc.h is needed for omap initcalls
@ 2013-02-12 22:23 ` Kevin Hilman
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2013-02-12 22:23 UTC (permalink / raw)
To: linux-arm-kernel
commit aa4f99638b (ARM: OMAP2+: Use omap initcalls) converted
the initcalls here, but did not #include "soc.h" where the omap
inicalls are defined.
To fix, #include <soc.h>
Signed-off-by: Kevin Hilman <khilman@linaro.org>
---
Tony, the patch that broke this was introduced in your
omap-for-v3.9/multiplatform-enable-signed branch, and this problem was
found only when compiling with PM (specifically, SmartReflex) enabled.
arch/arm/mach-omap2/smartreflex-class3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/smartreflex-class3.c b/arch/arm/mach-omap2/smartreflex-class3.c
index 80f3acb..b2dcbd3 100644
--- a/arch/arm/mach-omap2/smartreflex-class3.c
+++ b/arch/arm/mach-omap2/smartreflex-class3.c
@@ -13,6 +13,7 @@
#include <linux/power/smartreflex.h>
#include "voltage.h"
+#include "soc.h"
static int sr_class3_enable(struct omap_sr *sr)
{
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: OMAP2+: SmartReflex: soc.h is needed for omap initcalls
2013-02-12 22:23 ` Kevin Hilman
@ 2013-02-13 1:12 ` Tony Lindgren
-1 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2013-02-13 1:12 UTC (permalink / raw)
To: Kevin Hilman; +Cc: linux-omap, linux-arm-kernel
* Kevin Hilman <khilman@linaro.org> [130212 14:27]:
> commit aa4f99638b (ARM: OMAP2+: Use omap initcalls) converted
> the initcalls here, but did not #include "soc.h" where the omap
> inicalls are defined.
>
> To fix, #include <soc.h>
Thanks, this should be already fixed in arm-soc/for-next. I might
have forgotten to merge these into omap-for-v3.9/tmp-merge though.
Regards,
Tony
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
> Tony, the patch that broke this was introduced in your
> omap-for-v3.9/multiplatform-enable-signed branch, and this problem was
> found only when compiling with PM (specifically, SmartReflex) enabled.
>
> arch/arm/mach-omap2/smartreflex-class3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/smartreflex-class3.c b/arch/arm/mach-omap2/smartreflex-class3.c
> index 80f3acb..b2dcbd3 100644
> --- a/arch/arm/mach-omap2/smartreflex-class3.c
> +++ b/arch/arm/mach-omap2/smartreflex-class3.c
> @@ -13,6 +13,7 @@
>
> #include <linux/power/smartreflex.h>
> #include "voltage.h"
> +#include "soc.h"
>
> static int sr_class3_enable(struct omap_sr *sr)
> {
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: OMAP2+: SmartReflex: soc.h is needed for omap initcalls
@ 2013-02-13 1:12 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2013-02-13 1:12 UTC (permalink / raw)
To: linux-arm-kernel
* Kevin Hilman <khilman@linaro.org> [130212 14:27]:
> commit aa4f99638b (ARM: OMAP2+: Use omap initcalls) converted
> the initcalls here, but did not #include "soc.h" where the omap
> inicalls are defined.
>
> To fix, #include <soc.h>
Thanks, this should be already fixed in arm-soc/for-next. I might
have forgotten to merge these into omap-for-v3.9/tmp-merge though.
Regards,
Tony
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
> Tony, the patch that broke this was introduced in your
> omap-for-v3.9/multiplatform-enable-signed branch, and this problem was
> found only when compiling with PM (specifically, SmartReflex) enabled.
>
> arch/arm/mach-omap2/smartreflex-class3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/smartreflex-class3.c b/arch/arm/mach-omap2/smartreflex-class3.c
> index 80f3acb..b2dcbd3 100644
> --- a/arch/arm/mach-omap2/smartreflex-class3.c
> +++ b/arch/arm/mach-omap2/smartreflex-class3.c
> @@ -13,6 +13,7 @@
>
> #include <linux/power/smartreflex.h>
> #include "voltage.h"
> +#include "soc.h"
>
> static int sr_class3_enable(struct omap_sr *sr)
> {
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-13 1:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-12 22:23 [PATCH] ARM: OMAP2+: SmartReflex: soc.h is needed for omap initcalls Kevin Hilman
2013-02-12 22:23 ` Kevin Hilman
2013-02-13 1:12 ` Tony Lindgren
2013-02-13 1:12 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.