All of lore.kernel.org
 help / color / mirror / Atom feed
* [bug]patch "acpi, memory-hotplug: parse SRAT before memblock is ready" breaks numa detection
@ 2013-02-19  3:07 Shaohua Li
  2013-02-19  3:29 ` Tang Chen
  0 siblings, 1 reply; 2+ messages in thread
From: Shaohua Li @ 2013-02-19  3:07 UTC (permalink / raw)
  To: linux-kernel; +Cc: tangchen, akpm

This patch in linux-next breaks numa detection. numa_init() will zero
numa_meminfo. If acpi_numa_init() does not call early_parse_srat(), we will
have no memory numa info.

Thanks,
Shaohua

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [bug]patch "acpi, memory-hotplug: parse SRAT before memblock is ready" breaks numa detection
  2013-02-19  3:07 [bug]patch "acpi, memory-hotplug: parse SRAT before memblock is ready" breaks numa detection Shaohua Li
@ 2013-02-19  3:29 ` Tang Chen
  0 siblings, 0 replies; 2+ messages in thread
From: Tang Chen @ 2013-02-19  3:29 UTC (permalink / raw)
  To: Shaohua Li; +Cc: linux-kernel, akpm

On 02/19/2013 11:07 AM, Shaohua Li wrote:
> This patch in linux-next breaks numa detection. numa_init() will zero
> numa_meminfo. If acpi_numa_init() does not call early_parse_srat(), we will
> have no memory numa info.
>

Hum, yes, I missed this one. :)

Briefly seeing the code, I think moving the following code to 
early_parse_srat()
will fix it, right? :)

	memset(&numa_meminfo, 0, sizeof(numa_meminfo));

I'll send a patch to fix it.

Thanks. :)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-02-19  3:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-19  3:07 [bug]patch "acpi, memory-hotplug: parse SRAT before memblock is ready" breaks numa detection Shaohua Li
2013-02-19  3:29 ` Tang Chen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.