From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Handle untiled planes when computing their offsets
Date: Thu, 21 Feb 2013 22:17:37 +0200 [thread overview]
Message-ID: <20130221201737.GJ4469@intel.com> (raw)
In-Reply-To: <1361477071-9914-1-git-send-email-chris@chris-wilson.co.uk>
On Thu, Feb 21, 2013 at 08:04:31PM +0000, Chris Wilson wrote:
> We trim the fb to fit the CRTC by computing the offset of that CRTC to
> its nearest tile_row origin. This allows us to use framebuffers that are
> larger than the CRTC limits without additional work.
>
> However, we failed to compute the offset for a linear framebuffer
> correctly as we treated its x-advance in whole tiles (instead of the
> linear increment expected), leaving the CRTC misaligned with its
> contents.
>
> Fixes regression from commit c2c75131244507c93f812862fdbd4f3a37139401
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Thu Jul 5 12:17:30 2012 +0200
>
> drm/i915: adjust framebuffer base address on gen4+
>
> v2: Adjust relative x-coordinate after linear alignment (vsyrjala)
> v3: Repaint with pokadots (vsyrjala)
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=61152
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: stable@vger.kernel.org
Looking good.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-02-21 20:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 14:45 [PATCH] drm/i915: Handle untiled planes when computing their offsets Chris Wilson
2013-02-21 16:55 ` [Intel-gfx] " Ville Syrjälä
2013-02-21 19:05 ` Chris Wilson
2013-02-21 19:54 ` [Intel-gfx] " Ville Syrjälä
2013-02-21 20:03 ` Chris Wilson
2013-02-21 20:04 ` Chris Wilson
2013-02-21 20:17 ` Ville Syrjälä [this message]
2013-02-21 20:52 ` [Intel-gfx] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130221201737.GJ4469@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.