From: Paul Mundt <lethal@linux-sh.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] clocksource: sh_cmt: Add Device Tree probing
Date: Mon, 04 Mar 2013 04:09:37 +0000 [thread overview]
Message-ID: <20130304040935.GC26475@linux-sh.org> (raw)
In-Reply-To: <1362159932-18533-2-git-send-email-hechtb+renesas@gmail.com>
On Fri, Mar 01, 2013 at 11:45:30AM -0600, Bastian Hecht wrote:
> We add the capabilty to probe SH CMT timer devices using Device Tree
> setup.
>
> We can deduce former platform data by the device IDs and channel
> IDs of our timer instances, so we choose this more intuitive info as our
> DT properties.
>
I wonder if it makes more sense to attempt to create a more generalized
binding, as what you have here is pretty much uniform for all of
CMT/TMU/MTU2. Perhaps having a general sh-timer binding would be cleaner,
while letting each timer plug the compatible string it cares about.
WARNING: multiple messages have this Message-ID (diff)
From: lethal@linux-sh.org (Paul Mundt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] clocksource: sh_cmt: Add Device Tree probing
Date: Mon, 4 Mar 2013 13:09:37 +0900 [thread overview]
Message-ID: <20130304040935.GC26475@linux-sh.org> (raw)
In-Reply-To: <1362159932-18533-2-git-send-email-hechtb+renesas@gmail.com>
On Fri, Mar 01, 2013 at 11:45:30AM -0600, Bastian Hecht wrote:
> We add the capabilty to probe SH CMT timer devices using Device Tree
> setup.
>
> We can deduce former platform data by the device IDs and channel
> IDs of our timer instances, so we choose this more intuitive info as our
> DT properties.
>
I wonder if it makes more sense to attempt to create a more generalized
binding, as what you have here is pretty much uniform for all of
CMT/TMU/MTU2. Perhaps having a general sh-timer binding would be cleaner,
while letting each timer plug the compatible string it cares about.
next prev parent reply other threads:[~2013-03-04 4:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 16:53 [PATCH 0/3] Add OF support to CMT driver - bindings discussion Bastian Hecht
2013-03-01 17:45 ` Bastian Hecht
2013-03-01 16:45 ` [PATCH 1/3] clocksource: sh_cmt: Add Device Tree probing Bastian Hecht
2013-03-01 17:45 ` Bastian Hecht
2013-03-04 4:09 ` Paul Mundt [this message]
2013-03-04 4:09 ` Paul Mundt
2013-03-04 15:51 ` Bastian Hecht
2013-03-04 15:51 ` Bastian Hecht
2013-03-04 10:03 ` Mark Rutland
2013-03-04 10:03 ` Mark Rutland
2013-03-04 16:29 ` Bastian Hecht
2013-03-04 16:29 ` Bastian Hecht
2013-03-05 9:43 ` Mark Rutland
2013-03-05 9:43 ` Mark Rutland
2013-03-06 1:06 ` Paul Mundt
2013-03-06 1:06 ` Paul Mundt
2013-03-06 13:44 ` Bastian Hecht
2013-03-06 13:44 ` Bastian Hecht
2013-03-01 16:45 ` [PATCH 3/3] ARM: mach-shmobile: sh73a0: Setup the timer device CMT10 using DT Bastian Hecht
2013-03-01 17:45 ` Bastian Hecht
2013-03-01 18:16 ` Sergei Shtylyov
2013-03-01 19:17 ` Sergei Shtylyov
2013-03-04 15:46 ` Bastian Hecht
2013-03-04 15:46 ` Bastian Hecht
2013-03-01 16:52 ` [PATCH 2/3] ARM: mach-shmobile: sh73a0: Add CMT DT name to clock list Bastian Hecht
2013-03-01 17:45 ` Bastian Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130304040935.GC26475@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.