From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: mach-shmobile: sh73a0: Setup the timer device CMT10 using DT
Date: Fri, 01 Mar 2013 18:16:37 +0000 [thread overview]
Message-ID: <5130FEB9.5000508@cogentembedded.com> (raw)
In-Reply-To: <1362159932-18533-4-git-send-email-hechtb+renesas@gmail.com>
Hello.
On 03/01/2013 08:45 PM, Bastian Hecht wrote:
> We can now use the Device Tree for bringing up our timer device CMT10.
> We move it out of the DT devices list into the early_devices list by
> the non-reference board code. And we add the device to the
> kzm9g-reference .dts file.
>
> Not-yet-signed-off-by: Bastian Hecht<hechtb+renesas@gmail.com>
> ---
> I wonder if this should go to arch/arm/boot/dts/sh73a0.dtsi.
>
> The moving to the early_devices is a bit hackish - I will cook up a better
> patch when I know into which .dts(i) file things go.
>
> arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 11 +++++++++++
> arch/arm/mach-shmobile/setup-sh73a0.c | 2 +-
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> index 7fad4b9..fef12f0 100644
> --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> @@ -69,6 +69,17 @@
> toshiba,mmc-wrprotect-disable;
> toshiba,mmc-has-idle-wait;
> };
> +
> + cmt@0xe6138010 {
>
"0x" shouldn't be there, remove it please.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: mach-shmobile: sh73a0: Setup the timer device CMT10 using DT
Date: Fri, 01 Mar 2013 22:17:13 +0300 [thread overview]
Message-ID: <5130FEB9.5000508@cogentembedded.com> (raw)
In-Reply-To: <1362159932-18533-4-git-send-email-hechtb+renesas@gmail.com>
Hello.
On 03/01/2013 08:45 PM, Bastian Hecht wrote:
> We can now use the Device Tree for bringing up our timer device CMT10.
> We move it out of the DT devices list into the early_devices list by
> the non-reference board code. And we add the device to the
> kzm9g-reference .dts file.
>
> Not-yet-signed-off-by: Bastian Hecht<hechtb+renesas@gmail.com>
> ---
> I wonder if this should go to arch/arm/boot/dts/sh73a0.dtsi.
>
> The moving to the early_devices is a bit hackish - I will cook up a better
> patch when I know into which .dts(i) file things go.
>
> arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 11 +++++++++++
> arch/arm/mach-shmobile/setup-sh73a0.c | 2 +-
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> index 7fad4b9..fef12f0 100644
> --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> @@ -69,6 +69,17 @@
> toshiba,mmc-wrprotect-disable;
> toshiba,mmc-has-idle-wait;
> };
> +
> + cmt at 0xe6138010 {
>
"0x" shouldn't be there, remove it please.
WBR, Sergei
next prev parent reply other threads:[~2013-03-01 18:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 16:53 [PATCH 0/3] Add OF support to CMT driver - bindings discussion Bastian Hecht
2013-03-01 17:45 ` Bastian Hecht
2013-03-01 16:45 ` [PATCH 1/3] clocksource: sh_cmt: Add Device Tree probing Bastian Hecht
2013-03-01 17:45 ` Bastian Hecht
2013-03-04 4:09 ` Paul Mundt
2013-03-04 4:09 ` Paul Mundt
2013-03-04 15:51 ` Bastian Hecht
2013-03-04 15:51 ` Bastian Hecht
2013-03-04 10:03 ` Mark Rutland
2013-03-04 10:03 ` Mark Rutland
2013-03-04 16:29 ` Bastian Hecht
2013-03-04 16:29 ` Bastian Hecht
2013-03-05 9:43 ` Mark Rutland
2013-03-05 9:43 ` Mark Rutland
2013-03-06 1:06 ` Paul Mundt
2013-03-06 1:06 ` Paul Mundt
2013-03-06 13:44 ` Bastian Hecht
2013-03-06 13:44 ` Bastian Hecht
2013-03-01 16:45 ` [PATCH 3/3] ARM: mach-shmobile: sh73a0: Setup the timer device CMT10 using DT Bastian Hecht
2013-03-01 17:45 ` Bastian Hecht
2013-03-01 18:16 ` Sergei Shtylyov [this message]
2013-03-01 19:17 ` Sergei Shtylyov
2013-03-04 15:46 ` Bastian Hecht
2013-03-04 15:46 ` Bastian Hecht
2013-03-01 16:52 ` [PATCH 2/3] ARM: mach-shmobile: sh73a0: Add CMT DT name to clock list Bastian Hecht
2013-03-01 17:45 ` Bastian Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5130FEB9.5000508@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.