From: Michael Ellerman <michael@ellerman.id.au>
To: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Cc: tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Enable multiple MSI feature in pSeries
Date: Tue, 5 Mar 2013 11:28:57 +1100 [thread overview]
Message-ID: <20130305002857.GA7656@concordia> (raw)
In-Reply-To: <513411AD.5010408@linux.vnet.ibm.com>
On Mon, Mar 04, 2013 at 11:14:53AM +0800, Mike Qiu wrote:
> 于 2013/3/1 11:54, Michael Ellerman 写道:
> >On Fri, Mar 01, 2013 at 11:08:45AM +0800, Mike wrote:
> >>Hi all
> >>
> >>Any comments? or any questions about my patchset?
> >You were going to get some performance numbers that show a definite
> >benefit for using more than one MSI.
> Yes, but my patch just enable the kernel to support this feature, whether
> to use it depens on the device driver.
Sure, but we don't add code just for fun, so unless there's a good
reason to add the feature - like better performance - we won't bother.
> And this feature has been merged to the kernel for X86 for a long time.
> See commit: 5ca72c4f7c412c2002363218901eba5516c476b1
> 51906e779f2b13b38f8153774c4c7163d412ffd9
That commit was merged in 3.9-rc1, ie. a few days ago, so no it has not been
in x86 for a long time.
That code removes the need for your first patch, which is a good start.
Please send a new version using irq_set_msi_desc_off().
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <michael@ellerman.id.au>
To: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Enable multiple MSI feature in pSeries
Date: Tue, 5 Mar 2013 11:28:57 +1100 [thread overview]
Message-ID: <20130305002857.GA7656@concordia> (raw)
In-Reply-To: <513411AD.5010408@linux.vnet.ibm.com>
On Mon, Mar 04, 2013 at 11:14:53AM +0800, Mike Qiu wrote:
> 于 2013/3/1 11:54, Michael Ellerman 写道:
> >On Fri, Mar 01, 2013 at 11:08:45AM +0800, Mike wrote:
> >>Hi all
> >>
> >>Any comments? or any questions about my patchset?
> >You were going to get some performance numbers that show a definite
> >benefit for using more than one MSI.
> Yes, but my patch just enable the kernel to support this feature, whether
> to use it depens on the device driver.
Sure, but we don't add code just for fun, so unless there's a good
reason to add the feature - like better performance - we won't bother.
> And this feature has been merged to the kernel for X86 for a long time.
> See commit: 5ca72c4f7c412c2002363218901eba5516c476b1
> 51906e779f2b13b38f8153774c4c7163d412ffd9
That commit was merged in 3.9-rc1, ie. a few days ago, so no it has not been
in x86 for a long time.
That code removes the need for your first patch, which is a good start.
Please send a new version using irq_set_msi_desc_off().
cheers
next prev parent reply other threads:[~2013-03-05 0:28 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 7:38 [PATCH 0/3] Enable multiple MSI feature in pSeries Mike Qiu
2013-01-15 7:38 ` Mike Qiu
2013-01-15 7:38 ` [PATCH 1/3] irq: Set multiple MSI descriptor data for multiple IRQs Mike Qiu
2013-01-15 7:38 ` Mike Qiu
2013-06-05 23:03 ` Grant Likely
2013-06-05 23:03 ` Grant Likely
2013-01-15 7:38 ` [PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuous IRQs support Mike Qiu
2013-01-15 7:38 ` Mike Qiu
2013-03-05 2:23 ` Michael Ellerman
2013-03-05 2:23 ` Michael Ellerman
2013-03-05 7:19 ` Mike Qiu
2013-03-05 7:19 ` Mike Qiu
2013-03-06 3:54 ` Michael Ellerman
2013-03-06 3:54 ` Michael Ellerman
2013-03-06 5:34 ` Mike Qiu
2013-03-06 5:42 ` Michael Ellerman
2013-03-06 5:42 ` Michael Ellerman
2013-03-06 7:02 ` Mike Qiu
2013-03-06 7:02 ` Mike Qiu
2013-03-05 2:41 ` Paul Mundt
2013-03-05 2:41 ` Paul Mundt
2013-03-05 7:44 ` Mike Qiu
2013-03-05 7:44 ` Mike Qiu
2013-01-15 7:38 ` [PATCH 3/3] powerpc/pci: Enable pSeries multiple MSI feature Mike Qiu
2013-01-15 7:38 ` Mike Qiu
2013-01-31 2:10 ` [PATCH 0/3] Enable multiple MSI feature in pSeries Mike
2013-01-31 2:10 ` Mike
2013-02-04 3:23 ` Michael Ellerman
2013-02-04 3:23 ` Michael Ellerman
2013-02-04 3:49 ` Mike Qiu
2013-02-04 5:56 ` Michael Ellerman
2013-02-04 5:56 ` Michael Ellerman
2013-02-04 6:43 ` Mike Qiu
2013-02-04 6:43 ` Mike Qiu
2013-03-01 3:07 ` Mike
2013-03-01 3:07 ` Mike
2013-03-01 3:08 ` Mike
2013-03-01 3:08 ` Mike
2013-03-01 3:54 ` Michael Ellerman
2013-03-01 3:54 ` Michael Ellerman
2013-03-04 3:14 ` Mike Qiu
2013-03-04 3:14 ` Mike Qiu
2013-03-05 0:28 ` Michael Ellerman [this message]
2013-03-05 0:28 ` Michael Ellerman
2013-05-21 14:45 ` Alexander Gordeev
2013-05-21 14:45 ` Alexander Gordeev
2013-05-22 0:15 ` Benjamin Herrenschmidt
2013-05-22 0:15 ` Benjamin Herrenschmidt
2013-05-22 6:16 ` Mike Qiu
2013-05-22 6:16 ` Mike Qiu
2013-05-22 5:57 ` Mike Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305002857.GA7656@concordia \
--to=michael@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiudayu@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.