From: Mike Qiu <qiudayu@linux.vnet.ibm.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuous IRQs support
Date: Tue, 05 Mar 2013 15:44:08 +0800 [thread overview]
Message-ID: <5135A248.4010205@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130305024110.GB14275@linux-sh.org>
于 2013/3/5 10:41, Paul Mundt 写道:
> On Tue, Jan 15, 2013 at 03:38:55PM +0800, Mike Qiu wrote:
>> Adding a function irq_create_mapping_many() which can associate
>> multiple MSIs to a continous irq mapping.
>>
>> This is needed to enable multiple MSI support for pSeries.
>>
>> +int irq_create_mapping_many(struct irq_domain *domain,
>> + irq_hw_number_t hwirq_base, int count)
>> +{
> Other than the other review comments already made, I think you can
> simplify this considerably by simply doing what irq_create_strict_mappings() does,
> and relaxing the irq_base requirements.
>
> In any event, as you are creating a new interface, I don't think you want
> to carry around half of the legacy crap that irq_create_mapping() has to
> deal with. We made the decision to avoid this with irq_create_strict_mappings()
> intentionally, too.
>
Oh, yes, you are right, I will send out V2 of my patch to make it more
comfortable , and hope you can review my patch again
Thanks
Mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Qiu <qiudayu@linux.vnet.ibm.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
benh@kernel.crashing.org, tglx@linutronix.de
Subject: Re: [PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuous IRQs support
Date: Tue, 05 Mar 2013 15:44:08 +0800 [thread overview]
Message-ID: <5135A248.4010205@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130305024110.GB14275@linux-sh.org>
于 2013/3/5 10:41, Paul Mundt 写道:
> On Tue, Jan 15, 2013 at 03:38:55PM +0800, Mike Qiu wrote:
>> Adding a function irq_create_mapping_many() which can associate
>> multiple MSIs to a continous irq mapping.
>>
>> This is needed to enable multiple MSI support for pSeries.
>>
>> +int irq_create_mapping_many(struct irq_domain *domain,
>> + irq_hw_number_t hwirq_base, int count)
>> +{
> Other than the other review comments already made, I think you can
> simplify this considerably by simply doing what irq_create_strict_mappings() does,
> and relaxing the irq_base requirements.
>
> In any event, as you are creating a new interface, I don't think you want
> to carry around half of the legacy crap that irq_create_mapping() has to
> deal with. We made the decision to avoid this with irq_create_strict_mappings()
> intentionally, too.
>
Oh, yes, you are right, I will send out V2 of my patch to make it more
comfortable , and hope you can review my patch again
Thanks
Mike
next prev parent reply other threads:[~2013-03-05 7:44 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 7:38 [PATCH 0/3] Enable multiple MSI feature in pSeries Mike Qiu
2013-01-15 7:38 ` Mike Qiu
2013-01-15 7:38 ` [PATCH 1/3] irq: Set multiple MSI descriptor data for multiple IRQs Mike Qiu
2013-01-15 7:38 ` Mike Qiu
2013-06-05 23:03 ` Grant Likely
2013-06-05 23:03 ` Grant Likely
2013-01-15 7:38 ` [PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuous IRQs support Mike Qiu
2013-01-15 7:38 ` Mike Qiu
2013-03-05 2:23 ` Michael Ellerman
2013-03-05 2:23 ` Michael Ellerman
2013-03-05 7:19 ` Mike Qiu
2013-03-05 7:19 ` Mike Qiu
2013-03-06 3:54 ` Michael Ellerman
2013-03-06 3:54 ` Michael Ellerman
2013-03-06 5:34 ` Mike Qiu
2013-03-06 5:42 ` Michael Ellerman
2013-03-06 5:42 ` Michael Ellerman
2013-03-06 7:02 ` Mike Qiu
2013-03-06 7:02 ` Mike Qiu
2013-03-05 2:41 ` Paul Mundt
2013-03-05 2:41 ` Paul Mundt
2013-03-05 7:44 ` Mike Qiu [this message]
2013-03-05 7:44 ` Mike Qiu
2013-01-15 7:38 ` [PATCH 3/3] powerpc/pci: Enable pSeries multiple MSI feature Mike Qiu
2013-01-15 7:38 ` Mike Qiu
2013-01-31 2:10 ` [PATCH 0/3] Enable multiple MSI feature in pSeries Mike
2013-01-31 2:10 ` Mike
2013-02-04 3:23 ` Michael Ellerman
2013-02-04 3:23 ` Michael Ellerman
2013-02-04 3:49 ` Mike Qiu
2013-02-04 5:56 ` Michael Ellerman
2013-02-04 5:56 ` Michael Ellerman
2013-02-04 6:43 ` Mike Qiu
2013-02-04 6:43 ` Mike Qiu
2013-03-01 3:07 ` Mike
2013-03-01 3:07 ` Mike
2013-03-01 3:08 ` Mike
2013-03-01 3:08 ` Mike
2013-03-01 3:54 ` Michael Ellerman
2013-03-01 3:54 ` Michael Ellerman
2013-03-04 3:14 ` Mike Qiu
2013-03-04 3:14 ` Mike Qiu
2013-03-05 0:28 ` Michael Ellerman
2013-03-05 0:28 ` Michael Ellerman
2013-05-21 14:45 ` Alexander Gordeev
2013-05-21 14:45 ` Alexander Gordeev
2013-05-22 0:15 ` Benjamin Herrenschmidt
2013-05-22 0:15 ` Benjamin Herrenschmidt
2013-05-22 6:16 ` Mike Qiu
2013-05-22 6:16 ` Mike Qiu
2013-05-22 5:57 ` Mike Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5135A248.4010205@linux.vnet.ibm.com \
--to=qiudayu@linux.vnet.ibm.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.