All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: "Manjunathappa, Prakash" <prakash.pm-l0cyMroinI0@public.gmane.org>
Cc: "davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org"
	<davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org>,
	"linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org"
	<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	"linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	"Nori, Sekhar" <nsekhar-l0cyMroinI0@public.gmane.org>,
	"rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org"
	<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	"Karicheri,
	Muralidharan" <m-karicheri2-l0cyMroinI0@public.gmane.org>,
	"rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org"
	<rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>,
	"spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"hs-ynQEQJNshbs@public.gmane.org"
	<hs-ynQEQJNshbs@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v2 1/4] spi/davinci: add DT binding documentation
Date: Tue, 5 Mar 2013 19:32:41 +0000	[thread overview]
Message-ID: <201303051932.41327.arnd@arndb.de> (raw)
In-Reply-To: <A73F36158E33644199EB82C5EC81C7BC3EA4854E-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>

On Tuesday 05 March 2013, Manjunathappa, Prakash wrote:
> On Mon, Mar 04, 2013 at 21:59:16, Arnd Bergmann wrote:
> > On Monday 04 March 2013 18:29:12 Manjunathappa, Prakash wrote:
> > > +- reg: Offset and length of SPI controller register space
> > > +- num-cs: Number of chip selects
> > > +- ti,davinci-spi-intr-line: interrupt line used to connect the SPI
> > > +	IP to the interrupt controller withn the SoC. Possible values
> > > +	are 0 and 1. Manual says one of the two possible interrupt
> > > +	lines can be tied to the interrupt controller. Set this
> > > +	based on a specifc SoC configuration.
> > > +- interrupts: interrupt number offset at the irq parent
> > 
> > I would not call this an "offset". It is an interrupt descriptor
> > which may be something other than a simple number.
> > 
> 
> I am planning to drop from this documentation as it is common property.

I think it makese sense to document the fact that there should be exactly
one interrupt listed in the interrupts property, especially since the
hardware has two outputs.

	Arnd

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] spi/davinci: add DT binding documentation
Date: Tue, 5 Mar 2013 19:32:41 +0000	[thread overview]
Message-ID: <201303051932.41327.arnd@arndb.de> (raw)
In-Reply-To: <A73F36158E33644199EB82C5EC81C7BC3EA4854E@DBDE01.ent.ti.com>

On Tuesday 05 March 2013, Manjunathappa, Prakash wrote:
> On Mon, Mar 04, 2013 at 21:59:16, Arnd Bergmann wrote:
> > On Monday 04 March 2013 18:29:12 Manjunathappa, Prakash wrote:
> > > +- reg: Offset and length of SPI controller register space
> > > +- num-cs: Number of chip selects
> > > +- ti,davinci-spi-intr-line: interrupt line used to connect the SPI
> > > +	IP to the interrupt controller withn the SoC. Possible values
> > > +	are 0 and 1. Manual says one of the two possible interrupt
> > > +	lines can be tied to the interrupt controller. Set this
> > > +	based on a specifc SoC configuration.
> > > +- interrupts: interrupt number offset at the irq parent
> > 
> > I would not call this an "offset". It is an interrupt descriptor
> > which may be something other than a simple number.
> > 
> 
> I am planning to drop from this documentation as it is common property.

I think it makese sense to document the fact that there should be exactly
one interrupt listed in the interrupts property, especially since the
hardware has two outputs.

	Arnd

  parent reply	other threads:[~2013-03-05 19:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 12:59 [PATCH v2 0/4] Enable SPI flash support on da850-evm DT kernel Manjunathappa, Prakash
2013-03-04 12:59 ` Manjunathappa, Prakash
2013-03-04 12:59 ` Manjunathappa, Prakash
2013-03-04 12:59 ` [PATCH v2 2/4] ARM: davinci: da850: add SPI1 DT node Manjunathappa, Prakash
2013-03-04 12:59   ` Manjunathappa, Prakash
2013-03-04 12:59   ` Manjunathappa, Prakash
2013-03-04 12:59 ` [PATCH v2 3/4] ARM: davinci: da850: override SPI DT node device name Manjunathappa, Prakash
2013-03-04 12:59   ` Manjunathappa, Prakash
2013-03-04 12:59   ` Manjunathappa, Prakash
     [not found] ` <1362401955-9616-1-git-send-email-prakash.pm-l0cyMroinI0@public.gmane.org>
2013-03-04 12:59   ` [PATCH v2 1/4] spi/davinci: add DT binding documentation Manjunathappa, Prakash
2013-03-04 12:59     ` Manjunathappa, Prakash
2013-03-04 12:59     ` Manjunathappa, Prakash
2013-03-04 16:29     ` Arnd Bergmann
2013-03-04 16:29       ` Arnd Bergmann
2013-03-05 12:56       ` Manjunathappa, Prakash
2013-03-05 12:56         ` Manjunathappa, Prakash
2013-03-05 13:28         ` Sekhar Nori
2013-03-05 13:28           ` Sekhar Nori
2013-03-05 13:45           ` Manjunathappa, Prakash
2013-03-05 13:45             ` Manjunathappa, Prakash
     [not found]         ` <A73F36158E33644199EB82C5EC81C7BC3EA4854E-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2013-03-05 19:32           ` Arnd Bergmann [this message]
2013-03-05 19:32             ` Arnd Bergmann
     [not found]             ` <201303051932.41327.arnd-r2nGTMty4D4@public.gmane.org>
2013-03-11  8:53               ` Manjunathappa, Prakash
2013-03-11  8:53                 ` Manjunathappa, Prakash
2013-03-04 12:59   ` [PATCH v2 4/4] ARM: davinci: da850-evm: add SPI flash support Manjunathappa, Prakash
2013-03-04 12:59     ` Manjunathappa, Prakash
2013-03-04 12:59     ` Manjunathappa, Prakash
     [not found]     ` <1362401955-9616-5-git-send-email-prakash.pm-l0cyMroinI0@public.gmane.org>
2013-03-04 13:47       ` Manjunathappa, Prakash
2013-03-04 13:47         ` Manjunathappa, Prakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201303051932.41327.arnd@arndb.de \
    --to=arnd-r2ngtmty4d4@public.gmane.org \
    --cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=hs-ynQEQJNshbs@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=m-karicheri2-l0cyMroinI0@public.gmane.org \
    --cc=nsekhar-l0cyMroinI0@public.gmane.org \
    --cc=prakash.pm-l0cyMroinI0@public.gmane.org \
    --cc=rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.