From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mirsal Ennaime <mirsal@mirsal.fr>
Cc: "Greg Kroah-Hartman" <greg@kroah.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Brian Swetland" <swetland@google.com>,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, "Joe Perches" <joe@perches.com>
Subject: Re: [PATCH v3 0/4] Cosmetic changes to the android binder proc release code
Date: Tue, 12 Mar 2013 10:56:41 +0000 [thread overview]
Message-ID: <20130312105641.GE9138@mwanda> (raw)
In-Reply-To: <1363084922-19698-1-git-send-email-mirsal@mirsal.fr>
On Tue, Mar 12, 2013 at 11:41:58AM +0100, Mirsal Ennaime wrote:
> Changes from v2
>
> * kept arguments aligned with parentesis (Following
> Arve Hjønnevåg's review)
> * added a fourth patch which removes function names from string litterals
> in favor __func__ (Following Dan Carpenter's review)
Actually that was Joe.
Looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mirsal Ennaime <mirsal@mirsal.fr>
Cc: "Greg Kroah-Hartman" <greg@kroah.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Brian Swetland" <swetland@google.com>,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, "Joe Perches" <joe@perches.com>
Subject: Re: [PATCH v3 0/4] Cosmetic changes to the android binder proc release code
Date: Tue, 12 Mar 2013 13:56:41 +0300 [thread overview]
Message-ID: <20130312105641.GE9138@mwanda> (raw)
In-Reply-To: <1363084922-19698-1-git-send-email-mirsal@mirsal.fr>
On Tue, Mar 12, 2013 at 11:41:58AM +0100, Mirsal Ennaime wrote:
> Changes from v2
>
> * kept arguments aligned with parentesis (Following
> Arve Hjønnevåg's review)
> * added a fourth patch which removes function names from string litterals
> in favor __func__ (Following Dan Carpenter's review)
Actually that was Joe.
Looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2013-03-12 10:56 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 19:31 [PATCH 0/4] Cosmetic changes to the android binder proc release code Mirsal Ennaime
2013-03-11 19:31 ` Mirsal Ennaime
2013-03-11 19:31 ` [PATCH 1/4] drivers: android: binder: Move the node release code to a separate function Mirsal Ennaime
2013-03-11 19:31 ` Mirsal Ennaime
2013-03-11 21:46 ` Dan Carpenter
2013-03-11 21:46 ` Dan Carpenter
2013-03-11 19:31 ` [PATCH 2/4] drivers: android: binder: Fix code style Mirsal Ennaime
2013-03-11 19:31 ` Mirsal Ennaime
2013-03-11 21:54 ` Dan Carpenter
2013-03-11 21:54 ` Dan Carpenter
2013-03-11 22:27 ` mirsal
2013-03-11 22:27 ` mirsal
2013-03-11 19:31 ` [PATCH 3/4] drivers: android: binder: Remove excessive indentation Mirsal Ennaime
2013-03-11 19:31 ` Mirsal Ennaime
2013-03-11 20:25 ` Joe Perches
2013-03-11 20:25 ` Joe Perches
2013-03-11 20:51 ` mirsal
2013-03-11 20:51 ` mirsal
2013-03-11 19:31 ` [PATCH 4/4] drivers: android: binder: Fix compiler warning Mirsal Ennaime
2013-03-11 19:31 ` Mirsal Ennaime
2013-03-11 21:44 ` Dan Carpenter
2013-03-11 21:44 ` Dan Carpenter
2013-03-11 23:26 ` [PATCH v2 0/3] Cosmetic changes to the android binder proc release code Mirsal Ennaime
2013-03-11 23:26 ` Mirsal Ennaime
2013-03-11 23:26 ` [PATCH v2 1/3] drivers: android: binder: Move the node release code to a separate function Mirsal Ennaime
2013-03-11 23:26 ` Mirsal Ennaime
2013-03-11 23:26 ` [PATCH v2 2/3] drivers: android: binder: Fix code style Mirsal Ennaime
2013-03-11 23:26 ` Mirsal Ennaime
2013-03-11 23:57 ` Arve Hjønnevåg
2013-03-11 23:57 ` Arve Hjønnevåg
2013-03-12 8:52 ` mirsal
2013-03-12 8:52 ` mirsal
2013-03-11 23:26 ` [PATCH v2 3/3] drivers: android: binder: Remove excessive indentation Mirsal Ennaime
2013-03-11 23:26 ` Mirsal Ennaime
2013-03-12 0:04 ` Joe Perches
2013-03-12 0:04 ` Joe Perches
2013-03-12 0:21 ` Arve Hjønnevåg
2013-03-12 0:21 ` Arve Hjønnevåg
2013-03-12 0:29 ` Joe Perches
2013-03-12 0:29 ` Joe Perches
2013-03-12 9:52 ` mirsal
2013-03-12 9:52 ` mirsal
2013-03-12 10:41 ` [PATCH v3 0/4] Cosmetic changes to the android binder proc release code Mirsal Ennaime
2013-03-12 10:41 ` Mirsal Ennaime
2013-03-12 10:41 ` [PATCH v3 1/4] drivers: android: binder: Move the node release code to a separate function Mirsal Ennaime
2013-03-12 10:41 ` Mirsal Ennaime
2013-03-12 10:42 ` [PATCH v3 2/4] drivers: android: binder: Fix code style in binder_deferred_release Mirsal Ennaime
2013-03-12 10:42 ` Mirsal Ennaime
2013-03-12 10:42 ` [PATCH v3 3/4] drivers: android: binder: Remove excessive indentation Mirsal Ennaime
2013-03-12 10:42 ` Mirsal Ennaime
2013-03-12 10:42 ` [PATCH v3 4/4] drivers: android: binder: Use __func__ in debug messages Mirsal Ennaime
2013-03-12 10:42 ` Mirsal Ennaime
2013-03-12 10:56 ` Dan Carpenter [this message]
2013-03-12 10:56 ` [PATCH v3 0/4] Cosmetic changes to the android binder proc release code Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312105641.GE9138@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirsal@mirsal.fr \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.