[LTP] [PATCH 2/2] ltp: Add support for Imagination Technologies Meta

[LTP] [PATCH 2/2] ltp: Add support for Imagination Technologies Meta

[Markos Chandras]

From: Markos Chandras <markos.chandras@imgtec.com>

This patch adds support for Imagination's Meta architecture.
The Meta Linux kernel port will be included in the Linux Kernel
v3.9. The Meta stack grows upwards so we need to add the appropriate
__metag__ macro to the ltp_clone function.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 lib/cloner.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/cloner.c b/lib/cloner.c
index 3835184..fa18731 100644
--- a/lib/cloner.c
+++ b/lib/cloner.c
@@ -54,7 +54,7 @@ ltp_clone(unsigned long clone_flags, int (*fn) (void *arg), void *arg,
 {
 	int ret;
 
-#if defined(__hppa__)
+#if defined(__hppa__) || (__metag__)
 	ret = clone(fn, stack, clone_flags, arg);
 #elif defined(__ia64__)
 	ret = clone2(fn, stack, stack_size, clone_flags, arg, NULL, NULL, NULL);
-- 
1.7.1



------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] ltp: Add support for Imagination Technologies Meta

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 945 bytes --]

On Wednesday 13 March 2013 10:04:54 Markos Chandras wrote:
> This patch adds support for Imagination's Meta architecture.
> The Meta Linux kernel port will be included in the Linux Kernel
> v3.9. The Meta stack grows upwards so we need to add the appropriate
> __metag__ macro to the ltp_clone function.

i thought only the parisc people were crazy enough to do that ;)

> --- a/lib/cloner.c
> +++ b/lib/cloner.c
> @@ -54,7 +54,7 @@ ltp_clone(unsigned long clone_flags, int (*fn) (void
> *arg), void *arg, {
>  	int ret;
> 
> -#if defined(__hppa__)
> +#if defined(__hppa__) || (__metag__)

you're missing "defined"

>  	ret = clone(fn, stack, clone_flags, arg);
>  #elif defined(__ia64__)
>  	ret = clone2(fn, stack, stack_size, clone_flags, arg, NULL, NULL, NULL);

i wonder if we could make this into a runtime test.  like declare a buffer on 
the stack, then call alloca(), and compare the resulting pointers.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 238 bytes --]

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] ltp: Add support for Imagination Technologies Meta

[Markos Chandras]

On 13 March 2013 17:22, Mike Frysinger <vapier@gentoo.org> wrote:
>>
>> -#if defined(__hppa__)
>> +#if defined(__hppa__) || (__metag__)
>
> you're missing "defined"
>

Looking a couple of lines above this I see the following:

#if defined (__s390__) || (__s390x__)

so I assumed this is the desired style for multiple "#if defined" constructs.

But if you want me to rewrite the patch so include the missing
"defined" let me know.

>>       ret = clone(fn, stack, clone_flags, arg);
>>  #elif defined(__ia64__)
>>       ret = clone2(fn, stack, stack_size, clone_flags, arg, NULL, NULL, NULL);
>
> i wonder if we could make this into a runtime test.  like declare a buffer on
> the stack, then call alloca(), and compare the resulting pointers.
> -mike

If you ask me, I prefer the way it is now.

-- 
Regards,
Markos Chandras

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] ltp: Add support for Imagination Technologies Meta

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 1169 bytes --]

On Wednesday 13 March 2013 13:28:08 Markos Chandras wrote:
> On 13 March 2013 17:22, Mike Frysinger wrote:
> >> -#if defined(__hppa__)
> >> +#if defined(__hppa__) || (__metag__)
> > 
> > you're missing "defined"
> 
> Looking a couple of lines above this I see the following:
> 
> #if defined (__s390__) || (__s390x__)
> 
> so I assumed this is the desired style for multiple "#if defined"
> constructs.

nope, that's a bug too

> >>       ret = clone(fn, stack, clone_flags, arg);
> >>  
> >>  #elif defined(__ia64__)
> >>  
> >>       ret = clone2(fn, stack, stack_size, clone_flags, arg, NULL, NULL,
> >>       NULL);
> > 
> > i wonder if we could make this into a runtime test.  like declare a
> > buffer on the stack, then call alloca(), and compare the resulting
> > pointers.
> 
> If you ask me, I prefer the way it is now.

the advantage is that the next random person to grow their stock in the 
opposite direction won't have to update this hard coded list.  and if it was 
written this way earlier, you wouldn't be here right now either ;).

not saying you must do this ... fix the defined checks and we can merge that
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 238 bytes --]

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] ltp: Add support for Imagination Technologies Meta

[Markos Chandras]

On 14 March 2013 16:52, Mike Frysinger <vapier@gentoo.org> wrote:
> On Wednesday 13 March 2013 13:28:08 Markos Chandras wrote:
>> On 13 March 2013 17:22, Mike Frysinger wrote:
>> >> -#if defined(__hppa__)
>> >> +#if defined(__hppa__) || (__metag__)
>> >
>> > you're missing "defined"
>>
>> Looking a couple of lines above this I see the following:
>>
>> #if defined (__s390__) || (__s390x__)
>>
>> so I assumed this is the desired style for multiple "#if defined"
>> constructs.
>
> nope, that's a bug too

Ok I will fix that too in v2

>
>> >>       ret = clone(fn, stack, clone_flags, arg);
>> >>
>> >>  #elif defined(__ia64__)
>> >>
>> >>       ret = clone2(fn, stack, stack_size, clone_flags, arg, NULL, NULL,
>> >>       NULL);
>> >
>> > i wonder if we could make this into a runtime test.  like declare a
>> > buffer on the stack, then call alloca(), and compare the resulting
>> > pointers.
>>
>> If you ask me, I prefer the way it is now.
>
> the advantage is that the next random person to grow their stock in the
> opposite direction won't have to update this hard coded list.  and if it was
> written this way earlier, you wouldn't be here right now either ;).
>
> not saying you must do this ... fix the defined checks and we can merge that
> -mike

Ok but we rarely need to touch this list (how often do you see
explicit #if/defs for new arches in LTP, especially with the stack
growing upwards?). But sure, making this check during runtime would
also be nice.

Patch v2 sent.

-- 
Regards,
Markos Chandras

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list