* i915 fails to build on 32bit Systems
@ 2013-03-13 18:33 Egbert Eich
2013-03-13 18:42 ` Ben Widawsky
0 siblings, 1 reply; 2+ messages in thread
From: Egbert Eich @ 2013-03-13 18:33 UTC (permalink / raw)
To: intel-gfx
i915.ko does not build due to the following function in i915_debugfs.c:
i915_min_freq_set(void *data, u64 val)
{
...
dev_priv->rps.min_delay = val / GT_FREQUENCY_MULTIPLIER;
...
}
Doing a 64bit integer division on 32bit requires a
compiler run time library to be linked in, otherwise
the symbol __udivdi3 will be missing.
This was introduced with
commit 2389cc5006861a8e024a23cb73605f2ab6a5afe8
Author: Kees Cook <keescook@chromium.org>
Date: Sun Mar 10 14:10:06 2013 -0700
drm/i915: use simple attribute in debugfs routines
before this val was a simple int.
Cheers,
Egbert.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: i915 fails to build on 32bit Systems
2013-03-13 18:33 i915 fails to build on 32bit Systems Egbert Eich
@ 2013-03-13 18:42 ` Ben Widawsky
0 siblings, 0 replies; 2+ messages in thread
From: Ben Widawsky @ 2013-03-13 18:42 UTC (permalink / raw)
To: Egbert Eich; +Cc: intel-gfx
On Wed, Mar 13, 2013 at 07:33:42PM +0100, Egbert Eich wrote:
> i915.ko does not build due to the following function in i915_debugfs.c:
>
> i915_min_freq_set(void *data, u64 val)
> {
> ...
> dev_priv->rps.min_delay = val / GT_FREQUENCY_MULTIPLIER;
> ...
> }
>
> Doing a 64bit integer division on 32bit requires a
> compiler run time library to be linked in, otherwise
> the symbol __udivdi3 will be missing.
>
> This was introduced with
>
> commit 2389cc5006861a8e024a23cb73605f2ab6a5afe8
> Author: Kees Cook <keescook@chromium.org>
> Date: Sun Mar 10 14:10:06 2013 -0700
>
> drm/i915: use simple attribute in debugfs routines
>
> before this val was a simple int.
>
> Cheers,
> Egbert.
We (Daniel) knows about this already... My question is, isn't this
already doable in sysfs. Can't we just kill the debugfs version now?
--
Ben Widawsky, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-13 18:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-13 18:33 i915 fails to build on 32bit Systems Egbert Eich
2013-03-13 18:42 ` Ben Widawsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.