From: "Michael Büsch" <m@bues.ch>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Michael Buesch <mb@bu3sch.de>,
zajec5@gmail.com, isedev@gmail.com,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: [RFC/RFT] b43: A fix for DMA transmission sequence errors
Date: Thu, 14 Mar 2013 19:55:49 +0100 [thread overview]
Message-ID: <20130314195549.56fea051@milhouse> (raw)
In-Reply-To: <51421afb.xUa3KbaBuvmUk4RG%Larry.Finger@lwfinger.net>
On Thu, 14 Mar 2013 13:46:19 -0500
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> if (unlikely(slot != firstused)) {
> /* This possibly is a firmware bug and will result in
> - * malfunction, memory leaks and/or stall of DMA functionality. */
> + * malfunction, memory leaks and/or stall of DMA functionality.
> + */
> b43dbg(dev->wl, "Out of order TX status report on DMA ring %d. "
> "Expected %d, but got %d\n",
> ring->index, firstused, slot);
> - return;
> + if (slot == firstused + 2) {
I guess you need to handle wrap-over here.
This would probably do:
if (slot == next_slot(ring, next_slot(ring, firstused)))
--
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20130314/bbcb41a3/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <m@bues.ch>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Michael Buesch <mb@bu3sch.de>,
zajec5@gmail.com, isedev@gmail.com,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: Re: [RFC/RFT] b43: A fix for DMA transmission sequence errors
Date: Thu, 14 Mar 2013 19:55:49 +0100 [thread overview]
Message-ID: <20130314195549.56fea051@milhouse> (raw)
In-Reply-To: <51421afb.xUa3KbaBuvmUk4RG%Larry.Finger@lwfinger.net>
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
On Thu, 14 Mar 2013 13:46:19 -0500
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> if (unlikely(slot != firstused)) {
> /* This possibly is a firmware bug and will result in
> - * malfunction, memory leaks and/or stall of DMA functionality. */
> + * malfunction, memory leaks and/or stall of DMA functionality.
> + */
> b43dbg(dev->wl, "Out of order TX status report on DMA ring %d. "
> "Expected %d, but got %d\n",
> ring->index, firstused, slot);
> - return;
> + if (slot == firstused + 2) {
I guess you need to handle wrap-over here.
This would probably do:
if (slot == next_slot(ring, next_slot(ring, firstused)))
--
Michael
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-03-14 18:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 18:46 [RFC/RFT] b43: A fix for DMA transmission sequence errors Larry Finger
2013-03-14 18:55 ` Michael Büsch [this message]
2013-03-14 18:55 ` Michael Büsch
2013-03-14 20:17 ` Rafał Miłecki
2013-03-14 20:17 ` Rafał Miłecki
2013-03-15 6:37 ` Rafał Miłecki
2013-03-15 6:37 ` Rafał Miłecki
2013-03-15 16:48 ` Larry Finger
2013-03-15 16:48 ` Larry Finger
2013-03-20 11:26 ` ISE Development
2013-03-20 11:26 ` ISE Development
2013-03-20 13:43 ` Chris Vine
2013-03-20 13:43 ` Chris Vine
2013-03-20 14:53 ` Larry Finger
2013-03-20 14:53 ` Larry Finger
2013-03-20 15:04 ` ISE Development
2013-03-20 15:04 ` ISE Development
2013-03-20 16:10 ` Chris Vine
2013-03-20 16:10 ` Chris Vine
2013-03-15 0:09 ` ISE Development
2013-03-15 0:09 ` ISE Development
2013-03-15 2:07 ` Larry Finger
2013-03-15 2:07 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314195549.56fea051@milhouse \
--to=m@bues.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=isedev@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.