From: Larry Finger <Larry.Finger@lwfinger.net>
To: isedev@gmail.com
Cc: Michael Buesch <mb@bu3sch.de>,
zajec5@gmail.com, b43-dev@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: [RFC/RFT] b43: A fix for DMA transmission sequence errors
Date: Thu, 14 Mar 2013 21:07:33 -0500 [thread overview]
Message-ID: <51428265.1090202@lwfinger.net> (raw)
In-Reply-To: <2065763.l9B10YbWFg@wks001.ise.net>
On 03/14/2013 07:09 PM, ISE Development wrote:
> On Thursday 14 Mar 2013 13:46:19 Larry Finger wrote:
>> + if (unlikely(!skip))
>> + txstat = status;
>> + else
>> + txstat = &fake;
>
> The logic should probably be reversed. It's more unlikely to skip than not to
> do so (hopefully!)...
Yes, you are correct.
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: isedev@gmail.com
Cc: Michael Buesch <mb@bu3sch.de>,
zajec5@gmail.com, b43-dev@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [RFC/RFT] b43: A fix for DMA transmission sequence errors
Date: Thu, 14 Mar 2013 21:07:33 -0500 [thread overview]
Message-ID: <51428265.1090202@lwfinger.net> (raw)
In-Reply-To: <2065763.l9B10YbWFg@wks001.ise.net>
On 03/14/2013 07:09 PM, ISE Development wrote:
> On Thursday 14 Mar 2013 13:46:19 Larry Finger wrote:
>> + if (unlikely(!skip))
>> + txstat = status;
>> + else
>> + txstat = &fake;
>
> The logic should probably be reversed. It's more unlikely to skip than not to
> do so (hopefully!)...
Yes, you are correct.
Larry
next prev parent reply other threads:[~2013-03-15 2:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 18:46 [RFC/RFT] b43: A fix for DMA transmission sequence errors Larry Finger
2013-03-14 18:55 ` Michael Büsch
2013-03-14 18:55 ` Michael Büsch
2013-03-14 20:17 ` Rafał Miłecki
2013-03-14 20:17 ` Rafał Miłecki
2013-03-15 6:37 ` Rafał Miłecki
2013-03-15 6:37 ` Rafał Miłecki
2013-03-15 16:48 ` Larry Finger
2013-03-15 16:48 ` Larry Finger
2013-03-20 11:26 ` ISE Development
2013-03-20 11:26 ` ISE Development
2013-03-20 13:43 ` Chris Vine
2013-03-20 13:43 ` Chris Vine
2013-03-20 14:53 ` Larry Finger
2013-03-20 14:53 ` Larry Finger
2013-03-20 15:04 ` ISE Development
2013-03-20 15:04 ` ISE Development
2013-03-20 16:10 ` Chris Vine
2013-03-20 16:10 ` Chris Vine
2013-03-15 0:09 ` ISE Development
2013-03-15 0:09 ` ISE Development
2013-03-15 2:07 ` Larry Finger [this message]
2013-03-15 2:07 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51428265.1090202@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=isedev@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.