All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: ppcdev <linuxppc-dev@lists.ozlabs.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 1/4] uprobes: add trap variant helper
Date: Sat, 23 Mar 2013 19:08:01 +0100	[thread overview]
Message-ID: <20130323180801.GA4667@redhat.com> (raw)
In-Reply-To: <20130322151627.GB20010@in.ibm.com>

On 03/22, Ananth N Mavinakayanahalli wrote:
>
> Some architectures like powerpc have multiple variants of the trap
> instruction. Introduce an additional helper is_trap_insn() for run-time
> handling of non-uprobe traps on such architectures.

Looks fine to me.

I am going to take this into my tree, hopefully Ben won't object. The
main change is arch-agnostic and the changes in arch/powerpc are trivial.

Oleg.

WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	benh@kernel.crashing.org, ppcdev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 1/4] uprobes: add trap variant helper
Date: Sat, 23 Mar 2013 19:08:01 +0100	[thread overview]
Message-ID: <20130323180801.GA4667@redhat.com> (raw)
In-Reply-To: <20130322151627.GB20010@in.ibm.com>

On 03/22, Ananth N Mavinakayanahalli wrote:
>
> Some architectures like powerpc have multiple variants of the trap
> instruction. Introduce an additional helper is_trap_insn() for run-time
> handling of non-uprobe traps on such architectures.

Looks fine to me.

I am going to take this into my tree, hopefully Ben won't object. The
main change is arch-agnostic and the changes in arch/powerpc are trivial.

Oleg.


  parent reply	other threads:[~2013-03-23 18:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22 15:16 [PATCH v2 1/4] uprobes: add trap variant helper Ananth N Mavinakayanahalli
2013-03-22 15:16 ` Ananth N Mavinakayanahalli
2013-03-22 15:17 ` [PATCH v2 2/4] uprobes: refuse uprobe on trap variants Ananth N Mavinakayanahalli
2013-03-22 15:17   ` Ananth N Mavinakayanahalli
2013-03-26 12:06   ` Srikar Dronamraju
2013-03-26 12:06     ` Srikar Dronamraju
2013-03-22 15:18 ` [PATCH v2 3/4] uprobes/powerpc: teach uprobes to ignore gdb breakpoints Ananth N Mavinakayanahalli
2013-03-22 15:18   ` Ananth N Mavinakayanahalli
2013-03-26 12:06   ` Srikar Dronamraju
2013-03-26 12:06     ` Srikar Dronamraju
2013-03-22 15:19 ` [PATCH v2 4/4] uprobes/powerpc: remove additional trap instruction check Ananth N Mavinakayanahalli
2013-03-22 15:19   ` Ananth N Mavinakayanahalli
2013-03-26 12:07   ` Srikar Dronamraju
2013-03-26 12:07     ` Srikar Dronamraju
2013-03-23 18:08 ` Oleg Nesterov [this message]
2013-03-23 18:08   ` [PATCH v2 1/4] uprobes: add trap variant helper Oleg Nesterov
2013-03-26 12:06 ` Srikar Dronamraju
2013-03-26 12:06   ` Srikar Dronamraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130323180801.GA4667@redhat.com \
    --to=oleg@redhat.com \
    --cc=ananth@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.