Re: [PATCH] kexec: use Crash kernel for Crash kernel low

[Vivek Goyal <vgoyal@redhat.com>]

On Wed, Mar 20, 2013 at 12:22:09PM -0700, Yinghai Lu wrote:
> We can extend kexec-tools to support multiple "Crash kernel" in /proc/iomem
> instead.
> 
> So we can use "Crash kernel" instead of "Crash kernel low" in /proc/iomem.
> 
> Suggested-by: Vivek Goyal <vgoyal@redhat.com>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>

Hi Yinghai,

This patch along with second version of kexec-tools patch works for me.
I had a small concern.

- Older version of kexec-tools do not work when multiple "Crash Kernel"
  entries show up in /proc/iomem. They error out with following.

Memory for crashkernel is not reserved
Please reserve memory by passing "crashkernel=X@Y" parameter to the kernel

I am assuming that crashkernel=X changes will break older kexec-tools
anyway on most of the machines (As it reserves memory as high as possible
by default) and older kexec-tools will not be able to load kernel that
high.

So it is a forgone conclusion that these new kernel changes to 
crashkernel=X in 3.9 are incompatible with older kexec-tools and one
needs to upgrade kexec-tools.

Other syntax of crashkernel=X@Y will continue to work though.

Thanks
Vivek

> 
> ---
>  kernel/kexec.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/kernel/kexec.c
> ===================================================================
> --- linux-2.6.orig/kernel/kexec.c
> +++ linux-2.6/kernel/kexec.c
> @@ -55,7 +55,7 @@ struct resource crashk_res = {
>  	.flags = IORESOURCE_BUSY | IORESOURCE_MEM
>  };
>  struct resource crashk_low_res = {
> -	.name  = "Crash kernel low",
> +	.name  = "Crash kernel",
>  	.start = 0,
>  	.end   = 0,
>  	.flags = IORESOURCE_BUSY | IORESOURCE_MEM